From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f48.google.com (mail-pg0-f48.google.com [74.125.83.48]) by dpdk.org (Postfix) with ESMTP id AC3282BA8 for ; Sun, 18 Dec 2016 00:32:08 +0100 (CET) Received: by mail-pg0-f48.google.com with SMTP id a1so23448361pgf.1 for ; Sat, 17 Dec 2016 15:32:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2R7aR4p4hBPwsRhdha3uYeiEgcmtCpy5SoioGcjbgzM=; b=Z4cr6vRsqgTJz9hrwTTh/ZuViYdnaUFKayANR1ddiPf9rV9Ba4iiauCVpQd99VbM/7 fHEH4FH7vlY+J6O4Tq2Nr9aujtchW1wfdyvQO5hc+YOLLSorD5kX2sl5I5S5OFeKrz8S xs87UP3byFfFEPqTWStjNiClsaO+FbAue8i0o9j0b617EPuddoUBV3DCzN26YE80+BHf QuTWmdHdYP07z0o8El0mWybqI08Ej/A5Xrl99otzbtbEeJtDPA81sebedxit8tpSN+UQ v+JMlTkNufY1XOPSkBHmPHZkLwvyB4T9AKgdm7GW0SFx6Crq3QkihxTUYbhHJtLGf2sb sICg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2R7aR4p4hBPwsRhdha3uYeiEgcmtCpy5SoioGcjbgzM=; b=PAqLm1Noj6ftcV92XhGkUXj8j+yOfbxQBGy0SaENSlgVH1kfkkViTBE1Y12H74y0tD 6AGG5weIIq/0OcVBqtINvuwQPzHCmbJUh2ha7cd0hJE0EXfZWxU0SKsSv2y94LhEdSlC 6l4c4PPqdm4wv31KM3K7AzptSuenIChKsBrPmQXbNbAPL3RBE2yKGOi4OfBoaJU86d+d pGCEW0nnwBqzwP9S1JG6E9Lx07oU9LiZVeBkI4M+UnflP+XaXc/nEEy5lgo7paDSG/8Z ssCfYh9svJAlZ01BecZTvFkHnK/BjisQrz4Qu8ZzL8UE94/Zae0Av2Tllc/SYjrErlPG DBPw== X-Gm-Message-State: AKaTC03Lai+BhB2MLqagw7gFsc3Qz//4Qfewu/gVzy/vdOVeIbEkOek4UEHzjte+l3S3FQ== X-Received: by 10.84.172.67 with SMTP id m61mr20575030plb.60.1482017527899; Sat, 17 Dec 2016 15:32:07 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id a24sm21134789pfh.57.2016.12.17.15.32.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Dec 2016 15:32:07 -0800 (PST) Date: Sat, 17 Dec 2016 15:32:00 -0800 From: Stephen Hemminger To: Chas Williams <3chas3@gmail.com> Cc: dev@dpdk.org Message-ID: <20161217153200.4d05d711@xeon-e3> In-Reply-To: <1481997835-23288-1-git-send-email-3chas3@gmail.com> References: <1481997835-23288-1-git-send-email-3chas3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/af_packet: initialize link interrupt callback queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2016 23:32:09 -0000 On Sat, 17 Dec 2016 13:03:55 -0500 Chas Williams <3chas3@gmail.com> wrote: > This patch initializes the eth_dev->link_intr_cbs queue which is > used when af_packet is passed into rte_eth_ev_callback_register(). > > Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks") > > Signed-off-by: Chas Williams <3chas3@gmail.com> > --- > drivers/net/af_packet/rte_eth_af_packet.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c > index a1e13ff..ea5070a 100644 > --- a/drivers/net/af_packet/rte_eth_af_packet.c > +++ b/drivers/net/af_packet/rte_eth_af_packet.c > @@ -708,6 +708,7 @@ rte_pmd_init_internals(const char *name, > (*eth_dev)->data->drv_name = pmd_af_packet_drv.driver.name; > (*eth_dev)->data->kdrv = RTE_KDRV_NONE; > (*eth_dev)->data->numa_node = numa_node; > + TAILQ_INIT(&((*eth_dev)->link_intr_cbs)); This code really needs to have a local variable for eth_dev and not deref a pointer in every statement.