From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0082.outbound.protection.outlook.com [104.47.36.82]) by dpdk.org (Postfix) with ESMTP id 50814FB7A for ; Tue, 20 Dec 2016 14:09:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UhncNXVZuxqx9E93FmfTxF3f4IyI0HXrsewT/lHj+OU=; b=RXkdGuC7I5bQKktIuFezCRGYtnwN3GDOD8tSAtlFWOJk4SnNuAVOPM/DOLUw3lQfbtOmyWGqxD0plCkPI/ZxJhwaGjMxGN0Av2gls4FMEfDjc/V85fXqzbKVlSKbDjPmhp4exp7xRguBPO4btyldWTLDr2jqO1Ap3+ewI16NtuY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.171.35.214) by BN3PR0701MB1720.namprd07.prod.outlook.com (10.163.39.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Tue, 20 Dec 2016 13:09:46 +0000 Date: Tue, 20 Dec 2016 18:39:30 +0530 From: Jerin Jacob To: Bruce Richardson CC: , , , , Message-ID: <20161220130929.GA5901@localhost.localdomain> References: <1480798539-13360-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482070895-32491-1-git-send-email-jerin.jacob@caviumnetworks.com> <20161220111342.GA201880@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161220111342.GA201880@bricha3-MOBL3.ger.corp.intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [122.171.35.214] X-ClientProxiedBy: BM1PR01CA0041.INDPRD01.PROD.OUTLOOK.COM (10.163.199.13) To BN3PR0701MB1720.namprd07.prod.outlook.com (10.163.39.19) X-MS-Office365-Filtering-Correlation-Id: 334bfca6-6710-44b9-eeae-08d428d97a08 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BN3PR0701MB1720; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 3:8J7B+oDw6jsVlWJSGhtisQnLy7hBikIAhTu3BLklVd1GYN81Ku3Z6aNExWSd/QjZDmA3VwFmIIBDgY1qoJ6eUrit40QQbXeBRHskrdpR+wFWBrNlC1+yMdK7wxBBavqyRZSijbwBcSG7yKZpFJlm/g5jz5R1wFpWnbXQUTJRDgf4HM1R0j/hVMSzbCeFtUwZdy071sHjTcfTJgVD7DPu6tBzQ2U5qYPymk97wuMbU93K8597RY/f1KLmfBGAZ5Fv9c2qmfGjjv4J2Db+PIPykQ== X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 25:2u5xoH5aX2MFHIKVW8rB63/xha3Dr8PFHupp0bXDaCjeJbNhV5ve+cVSZ3UqI2v0tid9gRv0Jefh/CiH9uSCZxnLywO/9ubJEquXa9MiCvKUregJmrcMLgmmPe6pkDCt8FUCBKQ2ytD55o3gLzljyu8jKNUMeMGuQd3vmkV2CIUC0qfxditICzNscnLEVzntKQqniSGdsRaDyKXPIWPjc+cac7J49/cyTY3mzsoftMqGYgEPPQkw0NblwcJ5r5VQwMS0KLe63Aq5zMtwsTHs4NqXOVf4ELZ2ewX4U3V/qTSJsIw2pOQ+93009XvagHjHM09gmtfdsgNo06rL9HqGhJ4AqaGln5Ks6C3oPJFh0Bh4TTbfpowr/xZepvtPti85c8FKVBpYz9arITWzaqps1UJ2os6ZE8x27VI2WQ6Kngqtr7LkZn/j5N9hY1ufB7s2Q99rrQnkkrzVpxRZKdoWVYHmr5rwyH8/qGrVgOBlI+cPHFma37y3Q8cPCQ36mqMYsrfZlZ1H5rbMRdZfY1WSwuDAhQX7cA0ewkX9Fk4Tm8ZjEB7BKAzkQ14T4SX9GurFGpoRxMVJftWBTLlSn7ruLT6E/dYjIko89RRdy5EDchyYm+u/W3edpgwTJmoU5BWpj3tIIS1NtTnh/4iuIQIl034n11GikExvaIfWHPPloA2ide0C7EIktXk3IQ2U1msyBGpKdJS/5kmriFsjbfnjGKGoW0mfmqeZVQdjryZFjOA2o2hVEsKeg+BdENJIEOAou536virEVbd/fVFDITJqB3N6XYpDqYkUn7Mbad2yBykN2F2yN6rlAWGP30FzCgXh/wqMORDxBPYKIj0BQMG5p2Zk9ZpRD4QN5CSPqTLj6J1KxwCYfQ/jeZS84eMz6HM7 X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 31:ZLuWnhVrZQ04Z9xns9s1C+RtjgXbs2rhHzTt9kUkTDG7cuTiYreJzDkx1S8Bfv+pdEBMAkUDaUSp0NtKRi7b2Gz/4h3pVizcEPcJlZGGElEEY/4/GrvHGwiPelieZaV2yOe2RkRi2guEodmNHOWVI7p8Y4IRagCzWbF4S8A8ZqcK53ZVBNi4yRaVlJsAIkvgyOv0IBI/LNzNcmht3s0FTZWwVdL2vZKIVT7OeoNSZE6PwJ4IoIi5cDSfYK6OKDVAmi772C+Dg48UHj+fOU6Yhw==; 20:nMPCO1mz/x0zjqn7cV6klYAWgyhT3Hm2g72S4qvAmX6akJ6HzGJELUXpUHtZb+cHMUHGvSlSM2ERPHJXBuAPxuKhuDALcndzbhrqFX3lbtgw5StQBReaLCzJfAWPbuBzWslErJF63LQVgLd5HcAh/m+deyTeiyu7tUClTFbGuYWZXS9zp+R2zCvSr7piafKcVvxsGzxSVTne0nfFau2KRIRzsw5QlXv2TCZy7KSJoRYOxjqMKY54gxSTa1MqTcHekOzG4DiaI0sZMVE2+Kdmw2zI6w+UnGWaQLwKKluwNK0QzEKC2N8ZcCZxl2b6srpv+YyouN5DrQqbmKhLqj+Q2EDIycZbsswqmp6DhjBrMTld9Abjj7jDj3cG1NJdUWE1fVHagWcD2kQmqtL8v5K0fgqnSaSRMtlEE0OsY/n4SX8Lw/a7DpN3rfoCelcIEv9RphHwcRZe46LjXRFQjGBth7RMpe0dtn5H8DsqNSWrlD+CfGBJBtH7dnT5WidjjO1//hgL/K0cH6phlwDglKL/ZORv2/gnNH1QEiiOmF3Gwx/js/2296PvYMI3o+Mgiu03hUDoF+dhpHrJRyVjq1GHbYLPgkgbHBQvQZaH4ei9bXs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(6072148); SRVR:BN3PR0701MB1720; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1720; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 4:aG44M5Csp5YvpT/OT2yRuy/sgtHQZvULJ+Bk9cDHQ1ag0VWSQn5ACR77Id3Pz8Zd1k+H8b6A0JSeR30g6YUVN9JTkdYqooTG9UJeiv3b2oCaFHU53an+LgKVulscmhjL08ZA7LJpfhW1C1nAlgQrbfjV9geZOilzJPmlXS6bveaXNSad3vTRGihhSL1gksENc6rko/RLJRUkcmVhZ7lK6gq9BiHz87s3a6JwJxQjjyCksTFuf5c/twjPHtIFH6JmlMiAcDzc+x6+HW7vtl1LM/X+gpVdEEykr38eZWcdPMksA2ddqKFB7US0uBKeSkvhlG/nP4KvtYCTLk6TcYsoOTfqAB37Mu5FW+l8Y7cpAsxXxStFES2OocuN0I/XzrDwr4Wu1MSLvrGC+M1TZRG8fbRS012u+uQPeYHON8sPnhSWOyPvMPW9Gif20e1kyF1g48C21KS7kBuMrBpEwJSDuz96AzRSQp/Bq2wmLi/WPyP2p49zWWDOPTMlUrjloowU4F0NSvt/ZPwPK3/TVaeVzNSoho6TnLBGZ7dY89eqnrPQLwvi70V/OtxY+M4aKCXhD9MR3xARW94DZ7S7UGhhuBrPTe43s5nfpE/tnCme23gZMzzXzdDp7WAyIXm5FqhH X-Forefront-PRVS: 0162ACCC24 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(39450400003)(189002)(199003)(24454002)(66066001)(4326007)(106356001)(105586002)(42186005)(47776003)(81156014)(81166006)(50986999)(8676002)(8666005)(2906002)(7736002)(101416001)(305945005)(76176999)(54356999)(25786008)(15395725005)(68736007)(61506002)(189998001)(23726003)(3846002)(229853002)(5660300001)(6506006)(97756001)(50466002)(6116002)(33656002)(42882006)(6666003)(2950100002)(6916009)(46406003)(38730400001)(110136003)(1076002)(4001350100001)(92566002)(83506001)(97736004)(9686002)(18370500001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1720; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1720; 23:yCisiHCMYLs141jq9YZLvEy6Yk7OcmOimGR4lcw?= =?us-ascii?Q?DW/x1RMH8i0j/4vvfXH9urmD9sbBzQR3KtDjUcJnipeUpwNY22cGbKmAK5iA?= =?us-ascii?Q?3nQs9dGPdWKyChp0Xe8EHt5w2M0TFDsVNXV2p+TBr0VpIaD9i3ds4+I6BBKW?= =?us-ascii?Q?KWt+MRpx7CKK53OGAe2G2RwgDeY+e7g7p6AT/lUf9ijp11xipDjajpJAQmUI?= =?us-ascii?Q?u7Bwg4wV0QNiQp4wZ5YTGdiHC8vaVPlVm/3KHfbiCWxYC8j55bep4UV43rc5?= =?us-ascii?Q?88zrpiyAlDIxcuVAxw+N7JfB65ndv1ovbwhDcPfZOPSniQe1FlJ/lXZe//fL?= =?us-ascii?Q?le42R6USlv+6O1+fVAOcFGSpAibRXZyHIDpV/wjOxQxijRglsLNlOYxN6Qdr?= =?us-ascii?Q?7icmIlMmdupDS3JdWSLJY0cY2LwSCP7OPCtOXltyMia5/g2W1tgVypaxXWAV?= =?us-ascii?Q?vPmGv/n2oBUppncEX+NfmO7CNETHg/xemruQgqJhAqEMIJ87Ce3iERfVSaUx?= =?us-ascii?Q?wkUVN4N0mapGIWLfPHB5SvigYd0g3RrhgZgns4bwbjamztffByg43hNOP1H7?= =?us-ascii?Q?XpTkeySmif92JejVRQdtVvl/9OG1MiAmqzAi+wo8N0kcrgZAwvT7jRVm6z8D?= =?us-ascii?Q?EyksowdEDbVqH66UokAk8achZNAZifcIi4wIeIuGEJcWN9eOXhftkLtDmuaz?= =?us-ascii?Q?kTAJqnxxQ6ytiG8xALpZVPANKUDZcIfYzL1JIGY6nS0DLzd9avcJshwsLhFG?= =?us-ascii?Q?mgdLAz35+QP/35nExV4LjVN+OpNCZ3YbkeRDIpsBfnhqExIEcQTrW0UChfgj?= =?us-ascii?Q?KVpFlYUvCoT2PRpXIyEP+tXnq7O5ZwJrY/22NN5O5Jeclz3WBUnwYK8jEujo?= =?us-ascii?Q?P/i20CLnWWEwcBmy6VsGkjnPfM/snoBfxG2qN0PG7yYwjDOMrhgvOCE0U4Vt?= =?us-ascii?Q?70BjcmmWvb1s7H8s24Z4jsNVniOexwF9weeeWnCQiobIkaHDu88T5746Cfpk?= =?us-ascii?Q?/XN6GtBoe6AuYa99TBOAdssQLKvMW9NThNu1EINVssBDyjMpkDOyLA7JbdcA?= =?us-ascii?Q?4FDvfPEkN0hzytTdxD4c0Idn3fgC1/K96YWyBFtQ3c20k0PJ7j/mXDep48BH?= =?us-ascii?Q?Z4uPiJUVm5f04ZOmPTyZ1j68NnFREz7uIZGSRCePzhlylhsoPJTd8ywOwuU5?= =?us-ascii?Q?3Sej8NlaDMlnnrfWCpt7WYzKf1b18ZxUovqZ1pIs1oNQLI0pNiZ/+f1yiRvK?= =?us-ascii?Q?hPizmaNX/2qnvMy5tOEAidV2vueXqYt7r7opb5DvJbQ5MKB72HVCgJ/2Sl+J?= =?us-ascii?Q?jcw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 6:cT/eXSzOcTJO2UAXm9t0G1/wxb6+D521ugQPFNGjl/Rdo0dbWaQTuk9uOuCgL1rSE4K4urYtKOTzRH1h+v0P8vfq9897gFTGQVcbyxh0MgaqPcsmz/Bvk1kCsQI3QPhZeTcPYo+Rg8ggmuFmlR7mTWyGWlYN7c/aFfJ6mHoq1TrnC+VOs5w6/932uRySwsYHhC5VY+ATxNARkXLMMrZxbcNwHM5OmOdvlLlw04NX1VwN/6Rbsmj/gdzfKd2JQ4XClqRpZfXl+5Tp5Wh0DbrizQIpf/nqiTZavE4/mOwpbquvyNZYQHI3pL54X9I2j2cu7ZXZNiGk/RGwv8trRqhEGPJL1epezCplGLjSuvsrg39HWbizKVHjev0csH2liHTXc23a+6Roiz8e+GCDYiu2Z1B6KkE2d3RAzkEAoqQzbEQ=; 5:rwaWI0Tm2uKOqw1VMNeBRVkPV0+2yz5FjaIXZGbOeSuAHZTTRt7bGAwcIqR4kEqeH9MJYDu9RdVHHPjFmOntJv07qrslHM6DVuwYLrObl40AnBtvzZIfE00vO3CEi2wNSitnPPZeEOxs2BLwIoKeWNb80gI8Y4JIlxw2rlvm5TY=; 24:1f4xFn5tlnV5CMpSda+jf4n4KkE5zndCvkKYcZIfhsw3bu7L/XdB3yVbRJtG3dhgw1GSpY627vMamXUzsVtF57lf1PrxF6bkG+3XKuJJieg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 7:FkVy6BFjID41bHqlnYddJrwHJDmYu4F2JMJRMUPgWmOO9Sy+5gnLXvVv4DOGMc65maIPNcYjR3i2J2slTP1E0TQTj/Nks15Q77xAq7TZg37Qwp7sxMZ0q9RJPw9NP7xk4IiAn/mmrFQ+C67UJEwOKQYRbJnov/vb4KAmiGcBUe2jJmMPmUa3yHNB0HPRsFJJGr8BnBJQXpHtvVjkUsiWMr/c/UVZliyf+IUSL71UD37Ts2UAYrwcV8+pnoroeF2Qgvr/gx8nRWjtOKmDcPzHFSRzp/9tLLwJWXjhFuYGmfCKb7XGE2DmdCjlJUSHGQU17EmJY/fTZOUZM076ORV3mof4fDpRTDDZDr0g1DWLL5ccqkHWPzTb+oOXXnKAlexaywjIs5EPbDmoq3VT9/i7F+IlirFLKqbDgAl3J3JyPOH084CEamdo8Q3KIwD2NxtYgQo2aR8R6yVFF5mWd+voyQ== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2016 13:09:46.5595 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1720 Subject: Re: [dpdk-dev] [PATCH v3 0/6] libeventdev API and northbound implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 13:09:50 -0000 On Tue, Dec 20, 2016 at 11:13:42AM +0000, Bruce Richardson wrote: > On Sun, Dec 18, 2016 at 07:51:29PM +0530, Jerin Jacob wrote: > > As previously discussed in RFC v1 [1], RFC v2 [2], with changes > > described in [3] (also pasted below), here is the first non-draft series > > for this new API. > > > > [1] http://dpdk.org/ml/archives/dev/2016-August/045181.html > > [2] http://dpdk.org/ml/archives/dev/2016-October/048592.html > > [3] http://dpdk.org/ml/archives/dev/2016-October/048196.html > > > > v2..v3: > > > > - This patch set is check-patch clean with an exception that > > 03/06 has one WARNING:MACRO_WITH_FLOW_CONTROL > > - Looking forward to getting additional maintainers for libeventdev > > > > TODO: > > 1) Create user guide > > > > Jerin Jacob (6): > > eventdev: introduce event driven programming model > > eventdev: define southbound driver interface > > eventdev: implement the northbound APIs > > eventdev: implement PMD registration functions > > event/skeleton: add skeleton eventdev driver > > app/test: unit test case for eventdev APIs > > > Hi Jerin, Hi Bruce, > > other than the couple of comments I've made in replies to the individual > patches, this looks pretty good to me. Only additional comment I have is Thanks > that some of the macro names are a little long, and maybe we can shorten > them For example, you've added "_FLAG_" into the config flag macros, > and I'm not sure that is necessary. Similarly, I think we can drop > "_DEV_" from the PRIORITY names to shorten them. OK. I will remove the explicit _FLAG_ to shorten macro name. The _DEV_ in PRIORITY is not that long. So I would like to keep it for consistency and to denote it across priorities in event dev. > > Irrespective of these naming suggestions, once the other couple of > comments are taken care of, I think this set is suitable for merging to > the next-event tree. I will send v4 with fixes and your suggestions. If their is no further comment on that, we will merge to next-event tree > > Series Acked-by: Bruce Richardson > > Regards, > /Bruce >