From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f51.google.com (mail-pg0-f51.google.com [74.125.83.51]) by dpdk.org (Postfix) with ESMTP id 7C97F10CBB for ; Wed, 21 Dec 2016 19:06:44 +0100 (CET) Received: by mail-pg0-f51.google.com with SMTP id g1so48585782pgn.0 for ; Wed, 21 Dec 2016 10:06:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0lbOs0hoVsV1ahRM26isYjlQE2MbxkX75ldjIZp0reU=; b=Kj6Ouq4cm3r05au6JWESQznLkLYc6Yt0AXIiH8mVZvwesf5ujZzWZfCVq0ANqsNNZ+ VIV060lHgfA9gSzpQOA8fCcVSF9d1jIgfe3GpRA1eXQ/7RrMk+WtDa+OKUpsqkZqT9Oy CfBYBbIthg/jS8eI0UEnopbAW3T0Ptq+QtBob8ZY1Q0BJrF1aYZB5Y4PxQFLapYxNxGw eOspE8daABU7Eq5GAwMoaANAz1AZIDfIbkDgpMeT4PaCTZMxxH6gAc6E9H9AgwOGzmYQ K0ArApZrRbicoh+RhIZJAMNIhnSHYvD6iZx157u2nxbn5doUOYuTNGob3x0QdFiG0BKK ClZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0lbOs0hoVsV1ahRM26isYjlQE2MbxkX75ldjIZp0reU=; b=Eg+LS0N1Kt5jCbl+NJH2woCCfzpBfYBY/NzllLpXzL9mIe523czJ4Jlvghwtohhfma ApEbkxvSvk1mUYp/Mg7gpzhH/mNCNdu34N72lO5/gO7P2NwxGGCLGVZkoZ8+FASn1XM7 NjpHwgxVxeRDgHtKDvVGF2Ats3ym1m+Zx0L+YBNEMRdRtPVh2QVBdaPNF8arppyjVrF5 Umi1EGvDBev+0qPJQR7dgwd4QEpO6aTU+lAT13ROK4MAd+GATUw1KgsS2FPBERkwtMXe owBQ/4AJ9QcN372JcX0CaeQl4YVCir4MUdKM28tSWSMDJsf8dizilMWtzpQc1ziMi39e vgDw== X-Gm-Message-State: AIkVDXJczbeNsaxu/vI6sMfmHXWDPXoNHEMblLp5+yLRxJm2lXQFtYgvgLrsUpOWcjQB9g== X-Received: by 10.84.157.74 with SMTP id u10mr11028885plu.153.1482343603637; Wed, 21 Dec 2016 10:06:43 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id u64sm41336202pgc.39.2016.12.21.10.06.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Dec 2016 10:06:43 -0800 (PST) Date: Wed, 21 Dec 2016 10:06:36 -0800 From: Stephen Hemminger To: Yuanhan Liu Cc: dev@dpdk.org, Patrik Andersson , Jan Wickbom Message-ID: <20161221100636.71a27b22@xeon-e3> In-Reply-To: <1482313513-1709-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1481729401-27546-1-git-send-email-jan.wickbom@ericsson.com> <1482313513-1709-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6] vhost: allow for many vhost user ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2016 18:06:44 -0000 On Wed, 21 Dec 2016 17:45:13 +0800 Yuanhan Liu wrote: > From: Jan Wickbom > > Currently select() is used to monitor file descriptors for vhostuser > ports. This limits the number of ports possible to create since the > fd number is used as index in the fd_set and we have seen fds > 1023. > This patch changes select() to poll(). This way we can keep an > packed (pollfd) array for the fds, e.g. as many fds as the size of > the array. > > Also see: > http://dpdk.org/ml/archives/dev/2016-April/037024.html > > Reported-by: Patrik Andersson > Signed-off-by: Jan Wickbom > Signed-off-by: Yuanhan Liu Why not epoll()? It scales much better. The old System V poll is just as bad with 1023 fd's.