From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <adrien.mazarguil@6wind.com>
Received: from mail-wj0-f169.google.com (mail-wj0-f169.google.com
 [209.85.210.169]) by dpdk.org (Postfix) with ESMTP id CCAAE10BF9
 for <dev@dpdk.org>; Wed, 21 Dec 2016 12:31:34 +0100 (CET)
Received: by mail-wj0-f169.google.com with SMTP id v7so200458760wjy.2
 for <dev@dpdk.org>; Wed, 21 Dec 2016 03:31:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-disposition:in-reply-to;
 bh=HkN27VQggoMBfGgqF54DxB1OVHkiIDGN1iijHCTnzLU=;
 b=dtrBDZjyOnvTtHxULbneYCyQ++2JD2jWCqYCaB1aQtcD+gN/BQvkTEnRDaxOafKFnq
 7S4kJdbrGUPnxzM7O8ixEQPaz4M86n2EM5K33g4r1A3ufKHFzkEi48NnhVM68SuKvmXx
 CpFpF+o5H9phnlYNLLWv9Qt+KKbr54BVDVlzTvRs2u0SY3VWrcjhuvBhsAQzKwuiksh0
 122SgMUux6UbSq4VUDwd6zkQCBmio1ALy51NKMFbyJt3YWSiFQ9PcrTk9e+Yz3+D/rnv
 j4Y13Px4TTfmZdq3ERUsOWiOG7iBGbXQES/yhSt4Ln4vhCEsOpKSkWOU5dl9zGay/idw
 bQug==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:references
 :mime-version:content-disposition:in-reply-to;
 bh=HkN27VQggoMBfGgqF54DxB1OVHkiIDGN1iijHCTnzLU=;
 b=HZQoNHF6gwvttMSoxHcvXCet/gin51VVDTuTPd7UMiN7MFJWWskHGAsO655vtvAbDC
 1YwEwtA/x3yhnXHs1hCVI3HCouwiU7TwfP3Z3Wh8VyVXXVewWpsTkeRaj+N+HxcbcGFE
 9Bvu7GEHaz9pr/i6txSVX8ELV1XSrjfxdOaJM3TdNh+C6UOEFT9ZW0ios15k3adBF0Bu
 JTXmo/jrhrD9Ge5+cEnjju8d+VQdCNVN0TSR7kLphd0pdW+pqckPOkqteORZgApf98ZD
 ANoGYzzP74WEv8ZcIdvlEMZDlXBLaWY0L5qTLgf6GSqF3+ZeB+izWvHo8FkAjkHV8TeF
 dkOQ==
X-Gm-Message-State: AIkVDXLfNarq1fJF11rM2IonVMFkRp7/ALiBjSKF2enLgIN57kvEVLPWHZYo24ALEh43vaNk
X-Received: by 10.194.52.8 with SMTP id p8mr3839531wjo.38.1482319894249;
 Wed, 21 Dec 2016 03:31:34 -0800 (PST)
Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by smtp.gmail.com with ESMTPSA id k2sm30250000wjv.11.2016.12.21.03.31.32
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 21 Dec 2016 03:31:32 -0800 (PST)
Date: Wed, 21 Dec 2016 12:31:25 +0100
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20161221113125.GX10340@6wind.com>
References: <cover.1482168851.git.adrien.mazarguil@6wind.com>
 <cover.1482257521.git.adrien.mazarguil@6wind.com>
 <016063c97ffac7b759ded3d075abb960c97c450d.1482257521.git.adrien.mazarguil@6wind.com>
 <B27915DBBA3421428155699D51E4CFE20268B562@IRSMSX103.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20268B562@IRSMSX103.ger.corp.intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 02/25] doc: add rte_flow prog guide
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Dec 2016 11:31:34 -0000

Hi John,

On Wed, Dec 21, 2016 at 10:55:39AM +0000, Mcnamara, John wrote:
> Hi Adrien,
> 
> You missed out the changes I suggested to the table_rte_flow_migration_fdir
> which means that the pdf build is still broken. Also, the changes to
> table_rte_flow_migration_l2tunnel also break the PDF bulid.
> 
> You can test as follows:
> 
>     make doc-guides-pdf -j

OK, I'm unable to generate pdf documentation on my setup even though I've
installed the dependencies, I usually rely on HTML output only, that's why I
did not see the remaining issue.

> I'd suggest the following tables which retain the information and format
> that you are trying to achieve but which should compile:
> 
> .. _table_rte_flow_migration_fdir:
> 
> .. table:: FDIR conversion
> 
>    +----------------------------------------+-----------------------+
>    | Pattern                                | Actions               |
>    +===+===================+==========+=====+=======================+
>    | 0 | ETH, RAW          | ``spec`` | any | QUEUE, DROP, PASSTHRU |
>    |   |                   +----------+-----+                       |
>    |   |                   | ``last`` | N/A |                       |
>    |   |                   +----------+-----+                       |
>    |   |                   | ``mask`` | any |                       |
>    +---+-------------------+----------+-----+-----------------------+
>    | 1 | IPV4, IPv6        | ``spec`` | any | MARK                  |
>    |   |                   +----------+-----+                       |
>    |   |                   | ``last`` | N/A |                       |
>    |   |                   +----------+-----+                       |
>    |   |                   | ``mask`` | any |                       |
>    +---+-------------------+----------+-----+-----------------------+
>    | 2 | TCP, UDP, SCTP    | ``spec`` | any | END                   |
>    |   |                   +----------+-----+                       |
>    |   |                   | ``last`` | N/A |                       |
>    |   |                   +----------+-----+                       |
>    |   |                   | ``mask`` | any |                       |
>    +---+-------------------+----------+-----+                       |
>    | 3 | VF, PF (optional) | ``spec`` | any |                       |
>    |   |                   +----------+-----+                       |
>    |   |                   | ``last`` | N/A |                       |
>    |   |                   +----------+-----+                       |
>    |   |                   | ``mask`` | any |                       |
>    +---+-------------------+----------+-----+                       |
>    | 4 | END                                |                       |
>    +---+------------------------------------+-----------------------+
> 
> 
> .. _table_rte_flow_migration_l2tunnel:
> 
> .. table:: L2_TUNNEL conversion
> 
>    +---------------------------+--------------------+
>    | Pattern                   | Actions            |
>    +===+======+==========+=====+====================+
>    | 0 | VOID | ``spec`` | N/A | VXLAN, GENEVE, ... |
>    |   |      |          |     |                    |
>    |   |      |          |     |                    |
>    |   |      +----------+-----+                    |
>    |   |      | ``last`` | N/A |                    |
>    |   |      +----------+-----+                    |
>    |   |      | ``mask`` | N/A |                    |
>    |   |      |          |     |                    |
>    +---+------+----------+-----+--------------------+
>    | 1 | END                   | VF (optional)      |
>    +---+                       +--------------------+
>    | 2 |                       | END                |
>    +---+-----------------------+--------------------+

No problem, I'll include those changes along with a remaining bugfix and
testpmd support for additional protocol fields (requested by several
people). Brace yourself for v5!

Thanks for all the reviews.

-- 
Adrien Mazarguil
6WIND