From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Jerin.Jacob@cavium.com> Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0075.outbound.protection.outlook.com [104.47.36.75]) by dpdk.org (Postfix) with ESMTP id 18A4C10D1C for <dev@dpdk.org>; Thu, 22 Dec 2016 14:37:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TuRBlPgz4XHnIZIBjJ6Rr1hkVlpOHCowYygVUIBKdzI=; b=Dm2U8jdSTuFv51oeV2dRdO/iLNrzS4g4LZ0xv1lMJP3ueNwX2KLaYN6pyEGc4/hHZEkAp2uG/vPnZWyb4JJxQ8gukP09jMIWNw3tnkbxxgVQxKKFPXUX9xHHCfUp7/c8AGbAgIhN3QireOdnghY1DEkVs0lrmg7pnFTmr6QJkME= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (14.140.2.178) by BY1PR0701MB1722.namprd07.prod.outlook.com (10.162.111.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Thu, 22 Dec 2016 13:37:53 +0000 Date: Thu, 22 Dec 2016 19:07:34 +0530 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> CC: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>, <dev@dpdk.org>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "Richardson, Bruce" <bruce.richardson@intel.com> Message-ID: <20161222133732.GA12907@localhost.localdomain> References: <1477486575-25148-1-git-send-email-tomaszx.kulasek@intel.com> <3042915272161B4EB253DA4D77EB373A14F57CDE@IRSMSX102.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772583F0E2A74@irsmsx105.ger.corp.intel.com> <7594197.BWrLiCir60@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <7594197.BWrLiCir60@xps13> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: MA1PR01CA0002.INDPRD01.PROD.OUTLOOK.COM (10.164.117.9) To BY1PR0701MB1722.namprd07.prod.outlook.com (10.162.111.141) X-MS-Office365-Filtering-Correlation-Id: 4937a69a-3f2d-43a9-c7f0-08d42a6fbc60 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY1PR0701MB1722; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 3:/abGUilfyLSCghIR2xXPLMpLR9o2IlaUgB/G8nEQKJiUHNUzTcc9yXn2mbUx+LSAXEgSPzd7S8wiGTw2JAG4qsFHYxkZuJK39OY72Yv5Bdidnb3Up2uWhdLfhOHsVKNbyRx5dMHZOv2wlOFLFzL17/9rENTedosH2E4gU0kiXKZbmoqKx8DsWPWAGueUDKd1wApWiDm0S9Rai9NvAaY+MSJLo+v9EXePfHonwKJrYwXn2Sg0hgeeof7iRUzeduP8Ft7c/r3jKTxfJapLoAbfkQ==; 25:4d7qXdSNFoJgmYzVqDbw0J83DX7pS+cXhw0/vNXPF2tmfjRVdukU7/3oALdGMlxpNVRu6rHSrRbPOSdbPfxJQBHzvx3u8Y5Uo+vnMJ8odogsGH3Wag15yyeCLXTb8uSbmX7ZmOYC95LCiNvP3a8chqIUFc2EI5qadtN+ulEws+HAelGpVj/o4OZMoKeV9kskmxecgRWgeik/gCToNT9nO4it2OGPvgRjWwU8dDfWBfHambA9+HbyyD0uyc7OBo3wt0dY+8LQrYaNLhDaDzzBVGLRYn6RasBvnsrEFkYmU8BodsE2vXhq50L8BjJZ1vCZS4tRynvhHmzKhUpyLO1qPQTHAtcAVQa11vV7at9VtwMCUDuOuhWfHbXKKnwze4xBNgLoHwelC96EfL4yzPSGIfiXbK8sZ/QXnlnr6Hi/6mH4WK3TdYHteX+mMwoJqO788Kd0RXtLtZKLPveHCMXqxw== X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 31:1VZC8M93Adppc6LWK6hwVPO/l2VMnZTVC674ps8/NeAjx5lEXlsOVzFcNRu3xfABjLr2u/GjmngL58qW5UelsA7P718bifc6hse2ryC6skyUUeJ8fNcixfD8g5Ujxv9eRqZXW5Ves6TOyAHDhF06EJmN/WIyA6XHU6x/ih8HjAzDkyNJiZU3JMWZXPMAHA+GkwQVpopx1uJTdda0reZqoSH0lM3uRv1wOatJf3989nO9B8th9qrZm80gZiSrbAIeYDsWVbJ0prVn9N64xfoNxFNNg/0/e6C6g2iN7ZIkX1g=; 20:VFJnpFUcMdwrxyBjteux1mbsX+7s/g3rxhNLbWgUUFki/Rr3kNp2kQCZBC1rKVMIazBTQ6CJfwnfjCPb9YnuIvNk1iFYsllacwnBwr/orrZVR+sET0tixRQWIoWHZ4Dd14NtS6oBvFoFKIMq7UM8gRseMm9WxP9cyHBfa1W159UHzDMQRG1PfgRBTq5KYZZ56ULu6/YUFQWY2xvBEoqOQUQgJj8XYE5Dl4n8ApoibTED7TOLdz/3V6yirchy5zXxC7jusxd0/nxbJayhu4Vptr0I7zSm3jqGMguKT/K87c0B6VeZ1u9WPBYHMvJKQfHmCIa0GADsb+ZBG2yIINuWjlOmbSVR49Pjqh/12Tv+1TbQ21DHwUZ96lMORs73UndOC1kf8FqPbP4ZDGqetogWR2rQZ57t9xKb0nOf9jvahVO+diY2YOHc6rUwrPC1TEY2P4K+cwIG+SQmUMTn8bWAOCIezmxpS470NWql5JnCr327+S9ar8/oDkVwE5rM9ei246P2ycocj1ydka7zVpB7DskXlWhZt9+hgVdP3t20/Nke4fIH5qR9CufGcEAEX6jwf4ftjMPz1jjzFgaEGOgh188bKs3rHMBlG9sBzOGftSQ= X-Microsoft-Antispam-PRVS: <BY1PR0701MB1722C9F9A209034CBA6FE8F781920@BY1PR0701MB1722.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123560025)(20161123558021)(20161123555025)(20161123562025)(20161123564025)(6072148); SRVR:BY1PR0701MB1722; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1722; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 4:IU590slOrPsViIAERaGOgOvF+WMRunXgtwKY4DY7OUIZw1SwNE84uq3EoZpcXlLmLbHFtBq80hno8fqz+vuemkMau54HHTFrK2PHCkr2UCiOnmZC68ySpMdlQV+py2rDnTgNdjDr2rDdiZ4wyXMxrTNtIQRA9jAerNfHNto3tr6mheP7LId1EUD3y+LiMgfUKDXyEZaeLGIrUYBnV+8CdQsHYaqlEWWYvXZt0X5ptETJGon38izGC5/ZEQEF8FTI7sYgGLgTrjJjkeD68bEoQPH1kQo986YVVpes5BZBTRVhCgh2fkfsWwadzNqD22w4zr6QGffi17f1i477L8bdIz3WMHm6TSYfSw6fqWvOHjT2w/jlDGE3Gu9lb0W9csIg0kSN79HBvkefp93Yz+NtfQI8dH3iL01+F+FpOxILIXZZkZuA/jFRwl3GjB8L32pgljXoYj/YraIbFBDvaQBjWr9lsGXY2bESDEJGsJ5OGTzHxcnd6Y9Cfxyu/JOYLAvGm1BQEiNZ0zccJyR+O+iGezt/YIpW/Qe6V52g0lFv7y5OKPJu75yecPgxz5RZcN+xN7Fuz+qkiYqcS/RnXDRraSXepWwhrvgptyHR+ojg5IHycvfBoatk23KkkqLExOiO3QLVPfFPUpNQarCRPyL8AeHe6zjnQDNrcgg1NxZidfZgUbmZOJ7Gre0L9Mytzxvp X-Forefront-PRVS: 01644DCF4A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(39450400003)(24454002)(377424004)(199003)(189002)(305945005)(3846002)(23726003)(6116002)(4326007)(101416001)(42186005)(2906002)(7736002)(50466002)(189998001)(46406003)(97756001)(68736007)(92566002)(50986999)(1076002)(76176999)(47776003)(110136003)(54356999)(97736004)(66066001)(6506006)(5660300001)(6666003)(6916009)(2950100002)(42882006)(93886004)(61506002)(8676002)(38730400001)(229853002)(81166006)(106356001)(33656002)(81156014)(25786008)(105586002)(83506001)(5009440100003)(9686002)(4001350100001)(7099028)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1722; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1722; 23:qob5NLzWNY5Rbr101+Yndy7lHaTL923B3rNfkVM?= =?us-ascii?Q?BkyG+W1gkJzFrQC3jYLeh560pnx9dvhEgGmLb44I2Jm6U75ah89WmFrd4Xx7?= =?us-ascii?Q?lhtkvJq5V+uXSWqbs/v1k9haMpnCijvUYHSow7rXkq9wwzyJaB0xXyEVP0M5?= =?us-ascii?Q?5sAlPoyzFD7I8xBklgl0JaHxUICti8OyAdqqOeUyuQ8GU1AzEOSvWW1a11QH?= =?us-ascii?Q?UsUNLn4xepsAtrGwpupn3sPylT13LTargOKYeUnh3M6FXPNEHU50ITQCI2d3?= =?us-ascii?Q?cYmCXb3JgWLzVXE/7Gwx97K2Xz3eeraiLoHA6lE1Xai1WviDC25cvR0xd7tm?= =?us-ascii?Q?rstHjK+M2Vrp2moDwveRSS8WXo7oy+Ntf2IrspMHbaSYiBXeGhk+0VHHAlUX?= =?us-ascii?Q?drmWeex+3L8ciPcDE9C8v485xPTTTNqIt0nYh0JNBLtk8W75uMFlPQX6iRFt?= =?us-ascii?Q?nx5EoZSCOc/dKpgWR8wulGexi+YaYvchI4N7I0emIl92ebn1JXl6/YM6zeTn?= =?us-ascii?Q?HZM4GeQYte6XeddaGg1sP68PN3uELCzD8k5fivso3Dipk0wyrFH3jDD+jrZK?= =?us-ascii?Q?GztyfzMlx/xmizN3+nBdzvhdCMIsyobj+NEZ+u08AVsqF+KzSxgvVffVuqlU?= =?us-ascii?Q?BBvnbz4QK2itTTM/wHSx7fw0ZhykkWJTCJKFpegryRJ7b43rn8SoTIEbz1Il?= =?us-ascii?Q?3ssZEiJMhdNiMdfYVuDIrCvggm7rRdbZuTI3N2xO2aId6gPsRRYXZUrMw5f1?= =?us-ascii?Q?h3cAqNyPAU4LlWOJ67YwHvNVnRtCIZ9JoY/qOpdQnUIuSPjf5uzaBFrLnc1W?= =?us-ascii?Q?ryjYETbKOsiBywLS9SeYqdDi1kGVpu4Py62wWLm3s9TpiGfLCa41zaPIse7n?= =?us-ascii?Q?Sn4sztIp7oZ/BF6hOb6hU14SvNUuwxhAD8+xo8ekMLI6sBICtuNZfSbaGKEf?= =?us-ascii?Q?vZmDhHXNLk9MCPk/yIkDsr1p8cDc5p9sjXW4+j6sVhZeb2QyjJDm0zr5/59n?= =?us-ascii?Q?LZiiZc6KqAokZGWbgWiGai0UdXxXyDNEqMyUvctWFFK4YKvDmtkZ9lRIlqYx?= =?us-ascii?Q?CvhwtkHgdKkwUqqDqPyVnlM5l6T8YdXxpowVnblckSp60cnFau18JKR+7kBY?= =?us-ascii?Q?It2rUExb4DlEBNeR+io8d2lQNRqr62usbrntRWp6ZrCNRgcWkuuHNQHZGPsU?= =?us-ascii?Q?KlYVA5Fm1sJI3nLSsIXgCLR7JqfiBkrP91v2n8zfdhis2DnciH+D7WsvHy26?= =?us-ascii?Q?Ufjtys7qSzf7Y5yCh65Y3Hvh7UV/m5xKxExshImixpeXiWk/XxjhqJFlH3/p?= =?us-ascii?Q?bWOIO6uj3tDYlkNv0ELakkVKL5CctlAnnBPaW2F1wD3GSYQW9iHDrKWkiL+G?= =?us-ascii?Q?O0tj2zQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 6:MnDy3R9j4NcHwuB9L/3rCdwJrU49FcdO57IawQGzdNp64r6xF95o7uC5yt8V7zwWSjQW7SMn/dFqThxoqXx5b+kIz8kSCnKPwHqiJWfLOJkNpvMybwuq1jRvdJ/Xk6Q23h4zeMHQlGi+qGR+IjZp32+fzPzeWjYGNBm6IwhsjrqvMf7T53n8RTmsEHnpYy7KzU31BknR8ZK0xGUgBLH/MpG2lHb8p1zLKWYyx2069o3whnmRJqgSWD+0c8g019QhxyNjP286uyNp4/tGjK9KexZtHUe6gf9C7zjet37Fu6ZRWzgy1q/y5eDIfHNkKZwi37zG+uR0BDKDMrrD4ElPKARmrLyc0guZxaWesSpuPfgorusFtHwjY12CRKL/VtMLdicaxrc4Mds9qeR6HT3zPtBzHi3dtlnK/5Rq+mQmCKk=; 5:nZchZN3Am2dD63oSivgO3tKuE76D+oc/9bTK3LVa9YsmnFZmUvvTRLQ5sIEyo+sk3wQF34OsnFcJHzFkQxJ7qh2CcLpVs5yUibcI9RTBtvpF7tdsU7L0oSXh7dIjfgZJ/Yn07eZEDeIQPkCf3EaYjg==; 24:/P4m6wRMlnddT0GLDp+VEBkqxtTv/qjm4muRucou5GwcPd3uwtWwIQQD5fiYYDCwB5e00kxVZi/gRhX4UL71rjsnoFPCEhaPeXV3G7KVRPU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 7:x8ijnpVjtgEHnPJ59y8A1QaCun22fpbG7MeQgV4iC5I9asSr8THhLO1AnDnRlzN0ZMwjCujlxp7Nfma+GT4Ox/UPPxV1FLcDaHX1e63mUqPnQKWoe4Pp//izDsfRfGjgPhy2OJZPJiv1XW4dSqV+0sNDaU9l+stRu/MRoULzLbwOzAEWCoybs+euFyCAXiLNyAlaB7lOpOh+DUxCptB2u8JcWYK5f6CIhWVlSBSW/Qj2JpGbjFmP+yoMTvY/A1x932E8bA2VeCNOMUPAFQ2vWXNXC20ojqD7Wq3WLYYQPGU0Sklp4UJDE2ShSOaXLDM7b/5UZn5N0iD117scLV7R3rwuP3KtYS8kGvZm0hJcrc/DPkmqAU6Ry4iVo7cEU4JAAlZuXP4rbgGNPWFvQCktQPSx8gYinsiyV9uwb7adUtUsm+GhP2w7eDbRF9db7VBr6jKVaDtesvjSrj4IrlhoLw== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2016 13:37:53.2098 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1722 Subject: Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 22 Dec 2016 13:37:58 -0000 On Thu, Dec 22, 2016 at 02:14:45PM +0100, Thomas Monjalon wrote: > 2016-12-02 00:10, Ananyev, Konstantin: > > I have absolutely no problem to remove the RTE_ETHDEV_TX_PREPARE and associated logic. > > I personally don't use ARM boxes and don't plan to, > > and in theory users can still do conditional compilation at the upper layer, if they want to. > > Yes you're right. The application can avoid calling tx_prepare at all. There are applications inside dpdk repo which will be using tx_prep so in that case, IMHO, let the ifdef inside the DPDK library and disable it by default so that if required we can disable it in one shot on integrated controllers targets where is the system has only one integrated controller and integrated controller does not need tx_prep > No need of an ifdef inside DPDK.