From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f181.google.com (mail-wj0-f181.google.com [209.85.210.181]) by dpdk.org (Postfix) with ESMTP id 89B153DC for ; Mon, 26 Dec 2016 13:20:43 +0100 (CET) Received: by mail-wj0-f181.google.com with SMTP id sd9so113818457wjb.1 for ; Mon, 26 Dec 2016 04:20:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=G9VwDWmad7EGu6USRZiSmu33uBfEdniONseHtdCYNZ8=; b=p1O7ZRRyaoGt/fJQVRXff2sgqXmyF/X2jwDsHAG1dKT21mmGj+TYGbxYHPM42m6a0s sWv+V4WpvUkTB8Wa4Qif11N5vk90mRWOQXB4chhp/VvdW5lsVKGjgrFJzKGtrXFn6a77 mPun0kKcsS2rS/ES84CFXb+b4EcKuNn+pcjpxdRceSL4i4FaekozfAAgt3Gm4dhb3KOy wbnAezsh5p1iY+JmRgqcogYO1FF3P1iJTLvmZIvSGDpqafpfAnVyP2+PawOf9BZy+GDm YYBHx9W5h8ny82NhqZB0nc5fib9csBpn929ZWRYWoTI5f8GEW/FjmErYyuNwr1ev3qKB imfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=G9VwDWmad7EGu6USRZiSmu33uBfEdniONseHtdCYNZ8=; b=RRP3sKBky7Glj/5fVVMNxb+FVqcrGphtOQsn8fUtr1LirIUmwlRnxGZE0u8BhZt6Jc ZQh5Xg2POoYhodIVbmMXrPiaIkZgVMsG08NsL5RChU79UlhaJ0ru0SxYc2KCxHUFZD9F uQ6VqgfUjXFDsiBexbZnFb2ozkeVIvsmjh7YdwaJIGPXtNz0Ou/zaRs4KIDpaxDFu0zi ATbMtgNOHGu9v3w8Ss2D8G/hNLLxoSmRWTVw/1Ez4c0NCcNV8i7aw3L2vnV65ALuVWcG 3PfmVttk500HlZvw3yK2flWexC/O14WKvlR40xnP43urhuYGp2xZX45yhJBGArJitQvd vT7A== X-Gm-Message-State: AIkVDXIznx3+Jf7Hu5aEmHm55yMX+FmCoo8WIcknlVAOPELBPIy3XuJs+3UYonXeEG3A6L1W X-Received: by 10.194.243.231 with SMTP id xb7mr27377915wjc.60.1482754843257; Mon, 26 Dec 2016 04:20:43 -0800 (PST) Received: from autoinstall.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id l67sm50969417wmf.0.2016.12.26.04.20.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Dec 2016 04:20:42 -0800 (PST) Date: Mon, 26 Dec 2016 13:20:34 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ferruh Yigit Cc: dev@dpdk.org, Adrien Mazarguil Message-ID: <20161226122034.GK27385@autoinstall.dev.6wind.com> References: <1f1d914a-143b-94cd-9ade-f09e84c05df3@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1f1d914a-143b-94cd-9ade-f09e84c05df3@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 3/4] net/mlx5: add rte_flow rule creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Dec 2016 12:20:43 -0000 On Fri, Dec 23, 2016 at 12:21:10PM +0000, Ferruh Yigit wrote: > On 12/21/2016 3:19 PM, Nelio Laranjeiro wrote: > > Convert Ethernet, IPv4, IPv6, TCP, UDP layers into ibv_flow and create > > those rules when after validation (i.e. NIC supports the rule). > > > > VLAN is still not supported in this commit. > > > > Signed-off-by: Nelio Laranjeiro > > <...> > > > +static struct rte_flow * > > +priv_flow_create(struct priv *priv, > > + const struct rte_flow_attr *attr, > > + const struct rte_flow_item items[], > > + const struct rte_flow_action actions[], > > + struct rte_flow_error *error) > > +{ > > + struct rte_flow *rte_flow = NULL; > > Unnecessary assignment. > > <...> > > > + action = (struct action) { > > + .queue = -1, > > + .drop = 0, > > + }; > > + for (; actions->type != RTE_FLOW_ACTION_TYPE_END; ++actions) { > > + if (actions->type == RTE_FLOW_ACTION_TYPE_VOID) { > > + continue; > > + } else if (actions->type == RTE_FLOW_ACTION_TYPE_QUEUE) { > > + action.queue = ((const struct rte_flow_action_queue *) > > + actions->conf)->index; > > + } else if (actions->type == RTE_FLOW_ACTION_TYPE_DROP) { > > + action.drop = 1; > > + } else { > > + rte_flow_error_set(error, ENOTSUP, > > + RTE_FLOW_ERROR_TYPE_ACTION, > > + actions, "unsupported action"); > > + goto exit; > > + } > > + } > > + if (action.queue >= 0) { > > + queue = action.queue; > > + } else if (action.drop) { > > + queue = MLX5_FLOW_DROP_QUEUE; > > + } else { > > Not really so important, but as a note, ACTION_TYPE_VOID hits here. It > pass from validation, but gives error in creation. > > > + rte_flow_error_set(error, ENOTSUP, > > + RTE_FLOW_ERROR_TYPE_ACTION, > > + actions, > > + "no possible action found"); > > + goto exit; > > + } > > <...> Hi Ferruh, I will send (very soon) a v4 to handle this situation. Regards, -- Nélio Laranjeiro 6WIND