[dpdk-dev] [PATCH] examples/l3fwd: fix validation for queue id of config tuple

[dpdk-dev] [PATCH] examples/l3fwd: fix validation for queue id of config tuple

[Reshma Pattan]

Added validation for queue id of config parameter tuple.

This validation enforces user to enter queue ids of a port
from 0 and in sequence.

This additional validation on queue ids avoids ixgbe crash caused by null
rxq pointer access inside ixgbe_dev_rx_init.

Reason for null rxq is, L3fwd application allocates memory only for queues passed by user.
But rte_eth_dev_start  tries to initialize rx queues in sequence from 0 to nb_rx_queues,
which is not true and coredump while accessing the unallocated queue .

Fixes: Commit af75078f

Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
 examples/l3fwd/main.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
index 0e33039..f148d4e 100644
--- a/examples/l3fwd/main.c
+++ b/examples/l3fwd/main.c
@@ -264,8 +264,14 @@ get_port_n_rx_queues(const uint8_t port)
 
 	for (i = 0; i < nb_lcore_params; ++i) {
 		if (lcore_params[i].port_id == port &&
-			lcore_params[i].queue_id > queue)
+			lcore_params[i].queue_id > queue &&
+			lcore_params[i].queue_id == queue+1)
 			queue = lcore_params[i].queue_id;
+		else if (lcore_params[i].port_id == port &&
+				lcore_params[i].queue_id != queue+1)
+			rte_exit(EXIT_FAILURE, "queue ids of the port %d must be"
+					" in sequence and must start with 0",
+					lcore_params[i].port_id);
 	}
 	return (uint8_t)(++queue);
 }
-- 
2.5.0

Re: [dpdk-dev] [PATCH] examples/l3fwd: fix validation for queue id of config tuple

[Thomas Monjalon]

2016-03-18 10:35, Reshma Pattan:
> Added validation for queue id of config parameter tuple.
> 
> This validation enforces user to enter queue ids of a port
> from 0 and in sequence.
> 
> This additional validation on queue ids avoids ixgbe crash caused by null
> rxq pointer access inside ixgbe_dev_rx_init.
> 
> Reason for null rxq is, L3fwd application allocates memory only for queues passed by user.
> But rte_eth_dev_start  tries to initialize rx queues in sequence from 0 to nb_rx_queues,
> which is not true and coredump while accessing the unallocated queue .
> 
> Fixes: Commit af75078f

Fixes: af75078fece3 ("first public release")

>  	for (i = 0; i < nb_lcore_params; ++i) {
>  		if (lcore_params[i].port_id == port &&
> -			lcore_params[i].queue_id > queue)
> +			lcore_params[i].queue_id > queue &&

This check is not really useful if queue_id == queue+1

> +			lcore_params[i].queue_id == queue+1)
>  			queue = lcore_params[i].queue_id;
> +		else if (lcore_params[i].port_id == port &&

This line repeats the above check.
You can nest the "if" instead of "else if".

> +				lcore_params[i].queue_id != queue+1)
> +			rte_exit(EXIT_FAILURE, "queue ids of the port %d must be"
> +					" in sequence and must start with 0",
> +					lcore_params[i].port_id);
>  	}

[dpdk-dev] [PATCH v2] examples/l3fwd: fix validation for queue id of config tuple

[Reshma Pattan]

Added validation for queue id of config parameter tuple.

This validation enforces user to enter queue ids of a port
from 0 and in sequence.

This additional validation on queue ids avoids ixgbe crash caused by null
rxq pointer access inside ixgbe_dev_rx_init.

Reason for null rxq is, L3fwd application allocates memory only for queues passed by user.
But rte_eth_dev_start  tries to initialize rx queues in sequence from 0 to nb_rx_queues,
which is not true and coredump while accessing the unallocated queue .

Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
 v2:
 used nested if instead of if and elseif.

 examples/l3fwd/main.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
index 792894f..f297177 100644
--- a/examples/l3fwd/main.c
+++ b/examples/l3fwd/main.c
@@ -263,9 +263,14 @@ get_port_n_rx_queues(const uint8_t port)
 	uint16_t i;
 
 	for (i = 0; i < nb_lcore_params; ++i) {
-		if (lcore_params[i].port_id == port &&
-			lcore_params[i].queue_id > queue)
-			queue = lcore_params[i].queue_id;
+		if (lcore_params[i].port_id == port) {
+			if (lcore_params[i].queue_id == queue+1)
+				queue = lcore_params[i].queue_id;
+			else
+				rte_exit(EXIT_FAILURE, "queue ids of the port %d must be"
+						" in sequence and must start with 0",
+						lcore_params[i].port_id);
+		}
 	}
 	return (uint8_t)(++queue);
 }
-- 
2.5.0

Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix validation for queue id of config tuple

[De Lara Guarch, Pablo]

Hi Reshma,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Reshma Pattan
> Sent: Thursday, March 24, 2016 11:11 PM
> To: dev@dpdk.org; Ananyev, Konstantin
> Cc: Pattan, Reshma
> Subject: [dpdk-dev] [PATCH v2] examples/l3fwd: fix validation for queue id of
> config tuple
> 
> Added validation for queue id of config parameter tuple.
> 
> This validation enforces user to enter queue ids of a port
> from 0 and in sequence.
> 
> This additional validation on queue ids avoids ixgbe crash caused by null
> rxq pointer access inside ixgbe_dev_rx_init.
> 
> Reason for null rxq is, L3fwd application allocates memory only for queues
> passed by user.
> But rte_eth_dev_start  tries to initialize rx queues in sequence from 0 to
> nb_rx_queues,
> which is not true and coredump while accessing the unallocated queue .
> 

You forgot to include the Fixes line.

> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
>  v2:

[...]

> +		if (lcore_params[i].port_id == port) {
> +			if (lcore_params[i].queue_id == queue+1)
> +				queue = lcore_params[i].queue_id;
> +			else
> +				rte_exit(EXIT_FAILURE, "queue ids of the port
> %d must be"
> +						" in sequence and must start
> with 0",

You should include a return at the end of the sentence.

> +						lcore_params[i].port_id);
> +		}
>  	}
>  	return (uint8_t)(++queue);
>  }
> --
> 2.5.0

[dpdk-dev] [PATCH v3] examples/l3fwd: fix validation for queue id of config tuple

[Reshma Pattan]

Added validation for queue id of config parameter tuple.

This validation enforces user to enter queue ids of a port
from 0 and in sequence.

This additional validation on queue ids avoids ixgbe crash caused by null
rxq pointer access inside ixgbe_dev_rx_init.

Reason for null rxq is, L3fwd application allocates memory only for queues passed by user.
But rte_eth_dev_start  tries to initialize rx queues in sequence from 0 to nb_rx_queues,
which is not true and coredump while accessing the unallocated queue .

Fixes: af75078fece3 ("first public release")

Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
 v3:
 added Fixes line
 added "\n" at the end of err message.
 
 v2:
 used nested if instead of if and elseif.

 examples/l3fwd/main.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
index 792894f..97a1423 100644
--- a/examples/l3fwd/main.c
+++ b/examples/l3fwd/main.c
@@ -263,9 +263,14 @@ get_port_n_rx_queues(const uint8_t port)
 	uint16_t i;
 
 	for (i = 0; i < nb_lcore_params; ++i) {
-		if (lcore_params[i].port_id == port &&
-			lcore_params[i].queue_id > queue)
-			queue = lcore_params[i].queue_id;
+		if (lcore_params[i].port_id == port) {
+			if (lcore_params[i].queue_id == queue+1)
+				queue = lcore_params[i].queue_id;
+			else
+				rte_exit(EXIT_FAILURE, "queue ids of the port %d must be"
+						" in sequence and must start with 0\n",
+						lcore_params[i].port_id);
+		}
 	}
 	return (uint8_t)(++queue);
 }
-- 
1.7.4.1

Re: [dpdk-dev] [PATCH v3] examples/l3fwd: fix validation for queue id of config tuple

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Reshma Pattan
> Sent: Friday, March 25, 2016 3:14 PM
> To: dev@dpdk.org; Ananyev, Konstantin
> Cc: Pattan, Reshma
> Subject: [dpdk-dev] [PATCH v3] examples/l3fwd: fix validation for queue id of
> config tuple
> 
> Added validation for queue id of config parameter tuple.
> 
> This validation enforces user to enter queue ids of a port
> from 0 and in sequence.
> 
> This additional validation on queue ids avoids ixgbe crash caused by null
> rxq pointer access inside ixgbe_dev_rx_init.
> 
> Reason for null rxq is, L3fwd application allocates memory only for queues
> passed by user.
> But rte_eth_dev_start  tries to initialize rx queues in sequence from 0 to
> nb_rx_queues,
> which is not true and coredump while accessing the unallocated queue .
> 
> Fixes: af75078fece3 ("first public release")
> 
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Re: [dpdk-dev] [PATCH v3] examples/l3fwd: fix validation for queue id of config tuple

[Thomas Monjalon]

> > Added validation for queue id of config parameter tuple.
> > 
> > This validation enforces user to enter queue ids of a port
> > from 0 and in sequence.
> > 
> > This additional validation on queue ids avoids ixgbe crash caused by null
> > rxq pointer access inside ixgbe_dev_rx_init.
> > 
> > Reason for null rxq is, L3fwd application allocates memory only for queues
> > passed by user.
> > But rte_eth_dev_start  tries to initialize rx queues in sequence from 0 to
> > nb_rx_queues,
> > which is not true and coredump while accessing the unallocated queue .
> > 
> > Fixes: af75078fece3 ("first public release")
> > 
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied, thanks