From: Thomas Monjalon <thomas@monjalon.net>
To: Akhil Goyal <gakhil@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Zhigang Hu" <zhigang.hu@intel.com>,
"Fan Zhang" <fanzhang.oss@gmail.com>,
"David Marchand" <david.marchand@redhat.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [EXTERNAL] [PATCH] cryptodev: fix C++ include
Date: Thu, 19 Dec 2024 13:36:38 +0100 [thread overview]
Message-ID: <2016383.yKVeVyVuyW@thomas> (raw)
In-Reply-To: <CO6PR18MB44847E269BF14055E640ED9AD8062@CO6PR18MB4484.namprd18.prod.outlook.com>
19/12/2024 13:24, Akhil Goyal:
> > Some cryptodev functions were not included in the extern "C" block,
> > so it is moved to start before.
> >
> > An include is also moved to avoid being part of this block.
[...]
> > --- a/lib/cryptodev/rte_cryptodev.h
> > +++ b/lib/cryptodev/rte_cryptodev.h
> > @@ -21,6 +21,11 @@
> > #include <rte_rcu_qsbr.h>
> >
> > #include "rte_cryptodev_trace_fp.h"
> > +#include "rte_cryptodev_core.h"
>
> Fix is ok but rte_cryptodev_core.h should not be moved up.
> It is added in the middle to segregate the fast path APIs.
> And it is an internal header which cannot be included by app directly.
> I think the same schema is followed in ethdev as well.
Indeed, this is how it's done in ethdev:
#ifdef __cplusplus
}
#endif
#include <rte_ethdev_core.h>
#ifdef __cplusplus
extern "C" {
#endif
I'll do the same in v2.
next prev parent reply other threads:[~2024-12-19 12:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 10:41 The question for the modification against (lib/cryptodev/rte_cryptodev.h) in commit 719834a6 Hu, Zhigang
2024-12-19 11:45 ` [PATCH] cryptodev: fix C++ include Thomas Monjalon
2024-12-19 12:24 ` [EXTERNAL] " Akhil Goyal
2024-12-19 12:36 ` Thomas Monjalon [this message]
2024-12-19 11:48 ` The question for the modification against (lib/cryptodev/rte_cryptodev.h) in commit 719834a6 Thomas Monjalon
2024-12-19 13:30 ` [PATCH v2] cryptodev: fix C++ include Thomas Monjalon
2024-12-19 15:37 ` David Marchand
2024-12-19 16:36 ` Mattias Rönnblom
2024-12-19 16:34 ` Mattias Rönnblom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2016383.yKVeVyVuyW@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
--cc=zhigang.hu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).