From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E395645EEB; Thu, 19 Dec 2024 13:36:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81CC640290; Thu, 19 Dec 2024 13:36:43 +0100 (CET) Received: from fout-a4-smtp.messagingengine.com (fout-a4-smtp.messagingengine.com [103.168.172.147]) by mails.dpdk.org (Postfix) with ESMTP id B903E40265; Thu, 19 Dec 2024 13:36:41 +0100 (CET) Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id 393101380115; Thu, 19 Dec 2024 07:36:41 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Thu, 19 Dec 2024 07:36:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1734611801; x=1734698201; bh=HrmZPtc2FOrnb7j2XR9uUNTkvzMjzN/9UtlKtZMdyUM=; b= Nh9G3IC+pmvj3rKXHXQsMlq4J0bCvkaPs1mKU4QFtmVPoxzBLyXD0jXX/dJNk8NQ RCvXY1SotOzuDwGIyVYvNfrVqq/n/QEm6+MNLRjyTv97m4JVsajXsPfVhi0V9c5Y 8micKAMN2To4zL4Dx+Xr5aj/8pZLfI/ZxFECPSiKxQsg+fd2HntShMesSS7K/naB YeHa9/LagsgG2s6gwB35tLeVgeuqztAptoWPKu44Ou1K2kptzRE4FZzT17seOoaA /3aEwC4XnlIIJ5rew2jAMusmGg9vOmYCyP+q8VmBnvls+UssnIvfCuBjEbQKlm37 5am1hgND4a7AW1P3CufLRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1734611801; x= 1734698201; bh=HrmZPtc2FOrnb7j2XR9uUNTkvzMjzN/9UtlKtZMdyUM=; b=P 0LHIftvz8RSho0hTyii4cXZ481Le3N/BSpIx1lTZr3GYd0oL64MLtou4mdo6GX1b ZfWwYFYucOIN8R/A3mHHH7rLzgBhi6j/SorsZxq88650HPZXDP+lebCYNWAjhggI xzVYuIEsqH2o34BDuGyaFsHqhFIUXSwuYUKh2kP6gJwMUZIm18o+stdQEWKYkoAq uRWTmb9j1xtRHq9zaoIZP3nK1HBF88vdzmfg9AOPu+2UmsMN/ZqFUJ3OaZXzJRz9 VAX2e6wMNB3MNQFNHemJF3mnfy7klhY1ubpKMLSSjKjj5CybHmX6w4CmAtZO52mA bFQnfDYzy2pJDPRgjF7FQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddttddggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeekpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehgrghkhh hilhesmhgrrhhvvghllhdrtghomhdprhgtphhtthhopeguvghvseguphgukhdrohhrghdp rhgtphhtthhopehsthgrsghlvgesughpughkrdhorhhgpdhrtghpthhtohepiihhihhgrg hnghdrhhhusehinhhtvghlrdgtohhmpdhrtghpthhtohepfhgrnhiihhgrnhhgrdhoshhs sehgmhgrihhlrdgtohhmpdhrtghpthhtohepuggrvhhiugdrmhgrrhgthhgrnhgusehrvg guhhgrthdrtghomhdprhgtphhtthhopehmrghtthhirghsrdhrohhnnhgslhhomhesvghr ihgtshhsohhnrdgtohhmpdhrtghpthhtohepmhgssehsmhgrrhhtshhhrghrvghshihsth gvmhhsrdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Dec 2024 07:36:39 -0500 (EST) From: Thomas Monjalon To: Akhil Goyal Cc: "dev@dpdk.org" , "stable@dpdk.org" , Zhigang Hu , Fan Zhang , David Marchand , Mattias =?UTF-8?B?UsO2bm5ibG9t?= , Morten =?UTF-8?B?QnLDuHJ1cA==?= Subject: Re: [EXTERNAL] [PATCH] cryptodev: fix C++ include Date: Thu, 19 Dec 2024 13:36:38 +0100 Message-ID: <2016383.yKVeVyVuyW@thomas> In-Reply-To: References: <20241219114555.406331-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/12/2024 13:24, Akhil Goyal: > > Some cryptodev functions were not included in the extern "C" block, > > so it is moved to start before. > > > > An include is also moved to avoid being part of this block. [...] > > --- a/lib/cryptodev/rte_cryptodev.h > > +++ b/lib/cryptodev/rte_cryptodev.h > > @@ -21,6 +21,11 @@ > > #include > > > > #include "rte_cryptodev_trace_fp.h" > > +#include "rte_cryptodev_core.h" > > Fix is ok but rte_cryptodev_core.h should not be moved up. > It is added in the middle to segregate the fast path APIs. > And it is an internal header which cannot be included by app directly. > I think the same schema is followed in ethdev as well. Indeed, this is how it's done in ethdev: #ifdef __cplusplus } #endif #include #ifdef __cplusplus extern "C" { #endif I'll do the same in v2.