From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: remove unused fields
Date: Mon, 05 May 2014 18:05:43 +0200 [thread overview]
Message-ID: <2016976.lP8QZ899V2@xps13> (raw)
In-Reply-To: <20140418132323.GF4053@localhost.localdomain>
2014-04-18 09:23, Neil Horman:
> On Fri, Apr 18, 2014 at 02:58:08PM +0200, David Marchand wrote:
> > There is no need for a 'magic' field in struct rte_config, as this part of
> > the structure is local to each process. All threads of a process are
> > synchronised because of the run_once atomic.
> > So remove this field, as it is only adding confusion when reading code
> > that
> > references 'magic' field from struct rte_mem_config.
> >
> > Besides, there is no reference about the 'version' field, so remove it as
> > well.
> >
> > Signed-off-by: David Marchand <david.marchand@6wind.com>
>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Applied for version 1.7.0.
--
Thomas
prev parent reply other threads:[~2014-05-05 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 12:58 David Marchand
2014-04-18 13:23 ` Neil Horman
2014-05-05 16:05 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2016976.lP8QZ899V2@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).