From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A6B20689B; Wed, 4 Jan 2017 09:04:46 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP; 04 Jan 2017 00:04:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,458,1477983600"; d="scan'208";a="49879240" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga006.fm.intel.com with ESMTP; 04 Jan 2017 00:04:44 -0800 Date: Wed, 4 Jan 2017 16:06:31 +0800 From: Yuanhan Liu To: "Charles (Chas) Williams" Cc: dev@dpdk.org, mtetsuyah@gmail.com, stable@dpdk.org Message-ID: <20170104080631.GM21228@yliu-dev.sh.intel.com> References: <1483460563-5003-1-git-send-email-ciwillia@brocade.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483460563-5003-1-git-send-email-ciwillia@brocade.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4 1/2] net/vhost: create datagram sockets immediately X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 08:04:47 -0000 On Tue, Jan 03, 2017 at 11:22:42AM -0500, Charles (Chas) Williams wrote: > If you create a vhost server device, it doesn't create the actual datagram > socket until you call .dev_start(). If you call .dev_stop() is also > deletes those sockets. For QEMU clients, this is a problem since QEMU > doesn't know how to re-attach to datagram sockets that have gone away. > > To fix this, register and unregister the datagram sockets during device > creation and removal. > > Fixes: ee584e9710b9 ("vhost: add driver on top of the library") Both patches applied to dpdk-next-virtio. Thanks! Note that we prefer a title of "prefix: fix ..." for bug fixing patch. For this reason, I have changed the title for you while apply: net/vhost: fix socket file being deleted on dev stop Also, stable is cc'ed. --yliu