From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0068.outbound.protection.outlook.com [104.47.38.68]) by dpdk.org (Postfix) with ESMTP id A184F2BB9 for ; Wed, 4 Jan 2017 16:23:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4qUAHNE7nJbYchz/AFq1LEeOsIOgShz/7UDJXXMqct0=; b=IXO6V3TrT1rXDlSQsQorE74LhWh1YtRhDAtgOId7to8+iLXwq6HYzPXb1hDq82kgetS4anV0CKeBc6Kvc53OdrfJz9mXgW5+mJtGRKZaVKxtByoEzNA7tfvxntJlFhb+4ET7YssqIVSmANV9luNg3CMFtopfut8WutnAfdz68qo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from santosh-Latitude-E5530-non-vPro (14.140.2.178) by BN3PR0701MB1717.namprd07.prod.outlook.com (10.163.39.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.11; Wed, 4 Jan 2017 15:22:54 +0000 Date: Wed, 4 Jan 2017 20:52:27 +0530 From: Santosh Shukla To: Tiwei Bie CC: Jerin Jacob , , , , , , , Helin Zhang , Jingjing Wu , Satha Rao Message-ID: <20170104152225.GA7871@santosh-Latitude-E5530-non-vPro> References: <1481680558-4003-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482832175-27199-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482832175-27199-24-git-send-email-jerin.jacob@caviumnetworks.com> <20170104135339.GA56511@dpdk19> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170104135339.GA56511@dpdk19> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: PN1PR01CA0057.INDPRD01.PROD.OUTLOOK.COM (10.164.136.157) To BN3PR0701MB1717.namprd07.prod.outlook.com (10.163.39.16) X-MS-Office365-Filtering-Correlation-Id: 62f25586-3652-4322-e1fb-08d434b59065 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BN3PR0701MB1717; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717; 3:zqmW6ISxD26gkr50+mJ/hNrqLir2F3vfLLeXV6xL16ZJliy5/tAxzigia2IJj62bs+lxaKLtKDeaDH1v6/uXosRsKxKPHw81LZ2jSO16Yt1BrqwVzajXRjPrkWmkDsKy+IfTidMluHRRpsw+y2HQx7tFGwVEyZHMYGaWOeGwSKDCRRWOQDWDaTXLuq3lHS/B4WvshUTPeZPBNmSGVKG1at9NAfRYAAI83F76YyFmDgGoyWyDcXhyfsCZQAeBzTKea1aWZXW6tLZB0dR7mhLROQ== X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717; 25:BxhxWETIsnM+0VDzlGBhINt3gA82u3al9uOKtq2GH8Eawk4P1Ahk7NyulctbOJwp0+vBPn4YuNcxJedyTJFT59nCMwS1w2nJm8nwclF+BbanoniVNlDkiG5+YRgTkSB93njomWvG0lZ6IczPqlAPIxABd7i386GhFPRggVIKDrMHP6lA2RjEhp1qugOQ891ZECRVoOjyNu5mCSfHZW+y2RLtpAKRZP9F+McZvVRtz5ryF+wY3de27Ib/8g777J4J+mThpS86cZIoXccZRCfHpaA3ly3nEQLsAtmrEgxUFj+af7B+RdKOg7x9EcV6GnMG7mBN7QogPM/0g2+MqYcPxcVMcpeo27zkMGj9VpxDyWeJD9mkqkTX6MLxOPgRgFYJHntR4spu1HJPcQBMlr47clwxTdZfOCmHL8YFlOF4SYVM775edK1MF1+XLMCmLZ8toYJMOesIgTu8HbyZLgMaZtEvNlR1/sceGsBFxVyIhR2AuLJWLn91pOhecwiW7cciRS3fI4VDmc7FeMvGp9op+AmpO5YyA7RSPoXqWsPqotBi0e70yDdglAiYssYhE9hzWyA3UO3WBJxKQhkNGn5I3GxBIE7Jq7hir4nQ12+TmTS0cCULBWhZKosBo74WeMghjs3quKCiDBvVhIGTB6uzwX12xOdoHYgzHLYOp2Krv9BNUV9+2BJY2DYDCV4UF3s0vMcXnDWUgPIdKtQy3FKodia2GaOeEyluAKvesO6oxwGbxbH0rJ3gT3qahthIpIg2wa2tuSabL5qOxoMXNihmgw== X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717; 31:yXltIXLKkyf/oXOlYF1KgGF2lINd1+lY8ddjd6sk9v1p7lSZWVyuJtXBoNDhD+KbS0lllXcdIHFzywX7vLXW42r2gHJS4c6TavPHS/9f/kMUUU3OnBq9tCx2lnHYkEbTxX3HhWq9vJfXTvTn52H5YSZQFGoSPIrlO/KHYIAZPd4TyBnXdzusZjeVOtO9u1CesF/gHKYECfU/+YUSW/UUA/fb1si08Xoh8nZ8DqKrtAmNqDx71zASlsRf3W0EKXZX1vGQ8cov0TSlEVEKv/pZTT1DQnIfrpVVDdUQEtol8GU=; 20:NOJdWZ2PEWS5/GZL9oOkitii9wBHGC2EwEGSwL/jN0GsoSUS9CbhxkuBk72zD4pEc/y6zXSXNk6BO+X6O+4h8azujwNEUbArngmqu4o4uhKqdEhYhM09yirWe5YY2w+mD3NBN9ka6i0NlpQbNnFE1Go+uVq91zxpVhzzfsuXyV0B6yRJPPsI5mHeLxH+WStLodgKdYQUV7j78eMXQy3q9eYjuCqb8K301A00Mg1yLlar/RngVvxNWPvvcDsF/bvyyhxvdu+PI9qxYoeEzUmmdlUmjVBMC6eAZyQE7m0W/zSVImkvqK9YmuRrm9FFynJ73p9gS7g+qWpiGvIcpN0dKFFSLrSKfCbzvcMFEMLBCeKcBb5kuzF05DvqyXuAAVgvpHGRyBhS7diqalX/zzzNyQCExbMdmYn2/DTfBq7Gnsk+8UDcm8tDDmtwNCfb8Fg/NEQpsC4181DZKLooR8D/aOemrPs19C1ixZs3Fc/ms3KD3El9wYGeZBifx4hzOgOGyghL+LEiZFnhSFVfH1VDetucOR9gFdLVDNfbNYwonTNP3TWXPHnfVM7icWTMbx9KKDKAby8uOTgGJdXq7KdDrrMrCGo8RSWI59rxhkhJa9s= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(6072148); SRVR:BN3PR0701MB1717; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1717; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717; 4:XDgnofowMdhfYUrKp0zzmLfTEVfJFMHiK/W7rEgL6pAfQ3Svx9Cfxyq0026ncbt7ftqUqSubURvgcWo1YGn+3iA+n3Y4eUQk8VfWnDrYidB2rN4JLoqbyKu/hJEsJevYPk0CBLoHWf10Uzf5e1RBl9veO9roMQmikPFqeKdmSN5Eidb6KyHlpfSSsOHt0NNMwB4lRj4J6vOWRisMBR/cbu3SsVk7W7rxRYHcJcXGEYzMl3rEsErNHQ0zIB0GhkpWciJcKGm1v0iVh1MFadLYsT9k2ELkVH1Lk/hi+WCZp+Tb+gUF1V3C3jNehz2pRgcLconYb6aTVtgSYraX3ddFIYRQaqsEyLRC78aGn/DzQr56UM5IeXvk34KokIDu1zBeOzCxrr13K4oNU880v+hoYKxL9+l/JJozLIjmeR8nnDLbrYrBbNdT2CC76MVO+UhD+M7gRyhAuIEwnUHNO8/QuRjirpWkeDZ6ImeWyscuUNhGR7Wgf1QFzCTgfE2XPcVmLhM6d7oaFLO+IdQ/1/Ft8QifRUmO0lrU8cbRH0dhiQ7GBh0TOPkw3l+9Nek8bANjKKAeuZJqjyP7BAyMSctAlw== X-Forefront-PRVS: 0177904E6B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(189002)(24454002)(199003)(76176999)(5660300001)(9686002)(54356999)(2950100002)(54906002)(97736004)(2906002)(50466002)(97756001)(93886004)(101416001)(38730400001)(23726003)(3846002)(25786008)(7736002)(6666003)(81156014)(33656002)(1076002)(4326007)(42882006)(83506001)(4001430100002)(6916009)(5009440100003)(50986999)(8676002)(6496003)(47776003)(105586002)(92566002)(68736007)(81166006)(6116002)(106356001)(55016002)(229853002)(305945005)(66066001)(4001350100001)(189998001)(110136003)(42186005)(33716001)(46406003)(107886002)(7099028)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1717; H:santosh-Latitude-E5530-non-vPro; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1717; 23:vYs9Tr3WCXfvD0zLP1arjEaUbTzrURrBnFhxRgx?= =?us-ascii?Q?zvdLqjojo+z8qVJC30CEAPu6eH36qi9urJLcRIrCh6B29ZTfOVx3vKPP2pfC?= =?us-ascii?Q?VfEq9uR6/Z7feI47YkeT0+HN5vjt2msJShLnye/8Eb31a76gF+SrYJU5elVg?= =?us-ascii?Q?GBGM9wfWoJAL9T2xWeudBfJagNBayXRfcKwSb2njyUfKGDaweHycNlhlCC/n?= =?us-ascii?Q?ddbJMSxXZS6MbhLGVtnwxZREZJxSLTidqQrlxz0CLVHn7Ve/v6sZwuAUE8qd?= =?us-ascii?Q?P4ZzLnveuMCmMSOU0LAtk25o90/6hvnDTUg6c2UhJTP7AGgO6sFgSvcaIxhK?= =?us-ascii?Q?m6sdCWr0ThY6HFuHiMrn3aqHGHl8YOIrQQ1nkNhpjzUqO3LIMJNpvhsKR5+U?= =?us-ascii?Q?4Yytue3HCaleXAHK4SQolLUekK7kk21HfC4jIJB0dekrn1JtKgqIhmOQnoBu?= =?us-ascii?Q?5HJHRZzcq2qTtpTuPXsh4UEa0E6GtyAzho/dTx5jwBrHt0BO6r/7Fk4DxgYk?= =?us-ascii?Q?vhOM9btBNM0qvXdZaqmtw1vG58vlCRwR0hXp7H/NJxXPyoAICH8DkCTkLykC?= =?us-ascii?Q?39bA2zPAVC0boV12TStCX7I7lLZ7ufQzNF13QI/5LzWCca+lXD3c26hw5Ayj?= =?us-ascii?Q?SRt6ylrJx+XojO1m3I6tzghV1cos068Jl0/r1b41RcIjZZshJi8sUgKZPdqG?= =?us-ascii?Q?PWYUvu/YY8rWNpo4HYY6xDOuMdjOGx1z4erROl5trbYKGxudzJ4ajUDR/cKr?= =?us-ascii?Q?tCp6lgCFN12sEZOZGOGbVUXaMMDzoIB/QCidaVSK3iTFp14ZrbdjxXr1S2/t?= =?us-ascii?Q?4ma5OP3an4CToj5C0FFXQgQIDwIvYQWjlLo8PYk/uzORH54MzDNwWxCfpeu8?= =?us-ascii?Q?ixtl2xLCSV5HhgjXqnsLv4+95ubKtgql3yTEklNlQlTpsDWnNZnROBwcAPq+?= =?us-ascii?Q?Usyaww+I3BCYyoq9gd3iWQ8gJIsxGenSPhFIJER5+nSYEAiGU99LWrF0KG9r?= =?us-ascii?Q?+1gDbbGXRnddGUdGKKimCR5b2DBszYjy4i1jrmjcSHMFmleS1N9WjFJnJNwj?= =?us-ascii?Q?fbZkbXqkROQk14E9y65VWusG4yTsLiRK/ad8Vh+jJ3pdXPeuPu3dNoCHR/tQ?= =?us-ascii?Q?gdFMBpJ0FHc/pol6C/ZCfGKjPgzFNrWpwr9yHpgOiS/tHP+wEQrrsIxCCGeU?= =?us-ascii?Q?igF676jwCKO05hQVtzJH1cdq8oeITXQ9xenprnuY2FctadWYR6Afj+iRvC1M?= =?us-ascii?Q?zYKzNan1bRBtd34XnUMET0EVMRxxv1Lw26NBK2/+4TX0zoYV8z0L4YRENCjO?= =?us-ascii?Q?Y5HELh9vdgXntCBLYJpU+VjDHi5G5U66OPCRWclgOsoahIPsuFxSRS7mJgSB?= =?us-ascii?Q?fh5OvwRUIGGDkSGz/dIf7h8sSC1ogxabzPn+vOod/8Jmao5jJ?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717; 6:dC5y+T2lcyovcDpTgwf/IGnB536VpkiE8YzyADkTdRoG6UIvtNoR26MKXA1Jd7c0fdF7TxsuZ4Y/E/jvvnmebqUvBtvkIYcTX+ejrjJt8qVbnR/SwcNLWL5jA91yMP/GWgesuV1usMRkqPq7sCVLHkS142TCzQa1p0z4D6hYMI8MzKQZNLxH7DFJms56QfMueB5MgfcSV3y/VRzKKUwYdoktZGBxTUfWj/O5kJqzY6db7xWN05QAS98/BBYalV1SVS96lB4Qr431FRzZRjQhapxUMzIGVKuxeonlyMyOqax9hkNPLqJUv5s8zFFvaDGEaJ2zB2RWyGTOK7veyeY1OhpB8WoqmE1kkZDXLwxu8o8jdNRR/pTR+ujcndVvM+kqmnh6XB0xMb3xh4XswuMX1q5vCMjEUzIeobOdWaRqnuk=; 5:x7gF0CwVvBcRyDoUyAmpmJm0eMIUpUZ4MtcodPMhN2R9eOJPNEjA5zbBJekMf4tFGwcwO2lv0sh+OY6J5BjsbosBQzRKtXMltzK48nu3oLavjyACiXWQWpJQWRS/mYlehG9Xs7y3u5pAnc5jwyR1Ag==; 24:+HD+zBiZXha8ViUxpCl3arZdoR4AFcHxpV183OfPh2b89yv/L9waDhia+7gl3rg7h3QT1Rq+4z876Ca13AZ5CeNu8MbND2pxfUDxfcKH+2Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717; 7:Dsg3k0Ix8pNONh+mvpikz7O3N7b1NBqQ3ANVf03LHF1mWMlHFvFoMtKns7dHKm7eID4d7tzX6oDREWg/IgDhDDoMWQvQAUwqfx4EVcStW+nCmD94WxLgVdPS7sng8wFcl4MhJxWaEjGrtzfhDWKsQ+ADFMqIsVyC5wn2A4B2URXcQZKQyBLtQ0LEhiJWn7YZ4xV2C5Ejd4cifb9sQzZdPw9CL/Twxmffm2OFYKxZDJ9ZlphvTGEnFXrGOIAQA+VZuTNy6WSGZNicr91KWgQKTJ3go4MlWNIhyRR6rgD0pOQBgwu8o04npWLIjAP/9iOziO8EizHBs60Knc4WjlvT5He7VxXwicz7MAOsaZe/pV5pnJtaTPSx3obghqDcMVsvghz/ErCPfmxqnRt2HfQC0FXWX3nUIKlNcmn1kerP7NjD3L71+Ac5MeVnZ6aLW5mj7AG4Yr2xisLA5mzExnPITQ== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2017 15:22:54.2270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1717 Subject: Re: [dpdk-dev] [PATCH v2 23/29] net/i40e: use eal I/O device memory read/write API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 15:23:01 -0000 On Wed, Jan 04, 2017 at 09:53:40PM +0800, Tiwei Bie wrote: > On Tue, Dec 27, 2016 at 03:19:29PM +0530, Jerin Jacob wrote: > > From: Santosh Shukla > > /* Update the tx tail register */ > > rte_wmb(); > > - I40E_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail); > > + I40E_PCI_REG_WRITE_RELAXED(txq->qtx_tail, txq->tx_tail); > > > > return nb_pkts; > > } > > Besides i40e_xmit_pkts() and tx_xmit_pkts(), i40e_rx_alloc_bufs() which is > called by rx_recv_pkts() is also in the fast path. So I40E_PCI_REG_WRITE() > called by it should also be replaced by the relaxed version: > > diff --git i/drivers/net/i40e/i40e_rxtx.c w/drivers/net/i40e/i40e_rxtx.c > index 7ae7d9f..55a707a 100644 > --- i/drivers/net/i40e/i40e_rxtx.c > +++ w/drivers/net/i40e/i40e_rxtx.c > @@ -581,7 +581,7 @@ i40e_rx_alloc_bufs(struct i40e_rx_queue *rxq) > > /* Update rx tail regsiter */ > rte_wmb(); > - I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->rx_free_trigger); > + I40E_PCI_REG_WRITE_RELAXED(rxq->qrx_tail, rxq->rx_free_trigger); > > rxq->rx_free_trigger = > (uint16_t)(rxq->rx_free_trigger + rxq->rx_free_thresh); > Yes. Will queue it in v3. > > -- > > 2.5.5 > >