From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <adrien.mazarguil@6wind.com>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id A46C02C36
 for <dev@dpdk.org>; Thu,  5 Jan 2017 11:38:29 +0100 (CET)
Received: by mail-wm0-f48.google.com with SMTP id t79so479852247wmt.0
 for <dev@dpdk.org>; Thu, 05 Jan 2017 02:38:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-disposition:in-reply-to;
 bh=h2Tv3/oe9IZsm5oBX0TXbkMd3+3VQ1RUXu4YYSHhWsw=;
 b=qRPtlYxVLcCEfRwhKR7t5JL7dG/q+4z3AObaznz23uKsl/WnL8Eca5ETydMJIVT5+A
 w6wbxA/atb0bSdDcpLB+vExJGNDFY7qqJUsVZvivqsG5h+1EcX64altbYCUKVwIi0ZKt
 /WoPyBdO4iyaVD09iqer54iHKjgZvLc81ihjBH8do+IjPC417tfQ2aJtjDP6bg0rhaa6
 D4gbBNPt1cm8o88uKEPba61oyvnarzEBpIj/psuJhfE23syi12d/D8Vfzk+f1tvrH0Ct
 lJdNN2ACpOyInCmb11NIrqKMRdwJgSrq7z2aCYygHkn9xHNP8KpajRbpkIiYu9WCey/r
 J5aA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:references
 :mime-version:content-disposition:in-reply-to;
 bh=h2Tv3/oe9IZsm5oBX0TXbkMd3+3VQ1RUXu4YYSHhWsw=;
 b=AKhJJjhKXRm1A167qW9evOXwXE0gP12xn02iS9sAsoETzAltoZ6tYAtBJR6h851bMC
 rh983v9oUssisqgIyIXeXmjczhmD4cKJ/MkUarP2LslDR7x8Pg0c1pPI5SpXr7fKVoU/
 x50fZ07GTNviQP39Uy3p1sxv4TelH9JOV2wDXK9doC13Liub9QPnXpBH3sYk3vLrEmri
 2g+SRrLKK+Qz3mAS9Mhz+nlCVDqJyDgHKGcN1shOPkKt5dmX71bK6MVdK8qrwl3kjysX
 QmkmzDPfwmHVWa/GsLcYyclZSzvR301AEFsrW7ohYVPj54niUF82wLR0ilHhEBGy+dHd
 3ySg==
X-Gm-Message-State: AIkVDXLsgXaVxMYrDKV+hBhj/aX3nhTzspVugqG/2ivZBCZA1XkknYcFaJkZ9ezhB0VPIzab
X-Received: by 10.28.191.130 with SMTP id o2mr66712487wmi.97.1483612709384;
 Thu, 05 Jan 2017 02:38:29 -0800 (PST)
Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by smtp.gmail.com with ESMTPSA id yw4sm2227859wjb.31.2017.01.05.02.38.27
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 05 Jan 2017 02:38:28 -0800 (PST)
Date: Thu, 5 Jan 2017 11:38:21 +0100
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: ferruh.yigit@intel.com, dev@dpdk.org
Message-ID: <20170105103821.GM12822@6wind.com>
References: <20170105023219.10146-1-yskoh@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170105023219.10146-1-yskoh@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: add support for ConnectX-5 NICs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jan 2017 10:38:29 -0000

Hi Koh,

On Wed, Jan 04, 2017 at 06:32:19PM -0800, Yongseok Koh wrote:
> Add PCI device ID for ConnectX-5 and enable multi-packet send for PF and
> VF.
> 
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> 
> ConnectX-5 is a newly announced NIC of Mellanox. This patch includes basic
> enablement of ConnectX-5.
> 
>  drivers/net/mlx5/mlx5.c        | 42 +++++++++++++++++++++++++++++++++++++-----
>  drivers/net/mlx5/mlx5.h        |  4 ++++
>  drivers/net/mlx5/mlx5_ethdev.c |  7 ++-----
>  drivers/net/mlx5/mlx5_txq.c    |  2 +-
>  4 files changed, 44 insertions(+), 11 deletions(-)
[...]

While the changes made by this patch are fine, it is missing the mandatory
update of related documentation, specifically:

- doc/guides/nics/mlx5.rst: places where ConnectX-4 is also mentioned must
  be updated.

- doc/guides/rel_notes/release_17_02.rst: support for ConnectX-5 must appear
  somewhere (you can use past release notes as a template).

-- 
Adrien Mazarguil
6WIND