From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 23ACC37A6 for ; Thu, 5 Jan 2017 21:26:57 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id a197so1079023wmd.0 for ; Thu, 05 Jan 2017 12:26:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Rtp8D0WNp8YxkKNxpDwCtM0/oegiQeNffEdlioII2fc=; b=Yx4g6QSVfelXaOaOmz6c3Z6Ek0+u5pZSZ2mkdnpbTP0Y83bu4iUbtHa0puab+zDbRs f79EENMHmEC4uYXJlNzOPOMdvnmUdfe7jZzkFBwQYlzz2hykviS+UiAv/DndYQnD3VKY O00Nin/owUePTV7z0eelUaRddCMTO25dh47OHhLGz69Bc7UX8FXZHGF+Z6PDKVD7Qfho byF3IVY/mp94pAvPz5Jx/bdQRILkYwoSBZFYbNVbYLCGEg5lFYsYj6YhtuZALtY4+mYE Tvnqvj/ucADkxvXua+8XCC4Zkiyqo4Yun4smHvbQG7yNXxU26TuaKFgoWL09ryqWC6yA ke0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Rtp8D0WNp8YxkKNxpDwCtM0/oegiQeNffEdlioII2fc=; b=PWqz/p6cw7DiSbQtwVws80tuT3rMDOxu8LjiJVfhliiI4U/38sUDSVjo0VEyWXkBEV z/rTMi7s5D78+9ULKJQWztXWEpNYeh6CO7vZrIixrX1bTzQOt4aiE67jDJ99HR740990 gXiqgNJbLZGO4srmVqEt9dhn1ed5wB33So3mEt4l2A641pZu+Ja6NgBK03aI+f7Anmk9 dgwx1xt7H1cxYJI9SnV67f++/yT9SEtmr3+6YbCsMduXp3RIpeVCuOxZwGtja8IoQ/OL /W3+nPUHZU8rxeZHG8Wzeqx6V7oP7GzpI0Omm5O12Ox/gd0gDlpoMDCTHNjQ7r34IkU0 k74Q== X-Gm-Message-State: AIkVDXL5/roZDlfhw7BG4DcB6TjsLkNCYOtmc1RykcoSQoyc0hdZQMbl6E0oXKieUTAAh4xI X-Received: by 10.28.69.17 with SMTP id s17mr65341725wma.141.1483648014589; Thu, 05 Jan 2017 12:26:54 -0800 (PST) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id ua15sm105470661wjb.1.2017.01.05.12.26.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2017 12:26:53 -0800 (PST) Date: Thu, 5 Jan 2017 21:26:46 +0100 From: Adrien Mazarguil To: Yongseok Koh Cc: ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20170105202646.GT12822@6wind.com> References: <20170105023219.10146-1-yskoh@mellanox.com> <20170105115254.27401-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170105115254.27401-1-yskoh@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for ConnectX-5 NICs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 20:26:58 -0000 Hi Koh, A few remaining comments, please see below. On Thu, Jan 05, 2017 at 03:52:54AM -0800, Yongseok Koh wrote: > Add PCI device ID for ConnectX-5 and enable multi-packet send for PF and VF > along with changing documentation and release note. > > Signed-off-by: Yongseok Koh > --- > > ConnectX-5 is a newly announced NIC of Mellanox. This patch includes basic > enablement of ConnectX-5 as well as documentation. > > config/common_base | 2 +- > doc/guides/nics/mlx5.rst | 37 +++++++++++++++++------------- > doc/guides/rel_notes/release_17_02.rst | 5 ++++ > drivers/net/mlx5/mlx5.c | 42 ++++++++++++++++++++++++++++++---- > drivers/net/mlx5/mlx5.h | 4 ++++ > drivers/net/mlx5/mlx5_ethdev.c | 7 ++---- > drivers/net/mlx5/mlx5_txq.c | 2 +- > 7 files changed, 71 insertions(+), 28 deletions(-) [...] > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst [...] > @@ -185,8 +185,8 @@ Run-time configuration > save PCI bandwidth and improve performance at the cost of a slightly > higher CPU usage. > > - It is currently only supported on the ConnectX-4 Lx family of adapters. > - Enabled by default. > + It is currently only supported on the ConnectX-4 Lx and ConnectX-5 > + families of adapters. Enabled by default. Minor nit, can you remove the double spacing here? I know there is another one in the same document but it does break the style, it will be fixed eventually. [...] > @@ -241,12 +242,16 @@ DPDK and must be installed separately: > > Currently supported by DPDK: > > -- Mellanox OFED **3.4-1.0.0.0**. > +- Mellanox OFED version: An empty line is missing after this line. It causes the list to not display properly once exported to other formats. > + - ConnectX-4: **3.4-1.0.0.0** or higher > + - ConnectX-4 Lx: **3.4-1.0.0.0** or higher > + - ConnectX-5: **4.0-0.0.8.1** or higher > > - firmware version: > > - - ConnectX-4: **12.17.1010** > - - ConnectX-4 Lx: **14.17.1010** > + - ConnectX-4: **12.17.1010** or higher > + - ConnectX-4 Lx: **14.17.1010** or higher > + - ConnectX-5: **16.18.0296** or higher "or higher" was implicit until now, if you want to make it explicit I think it's better to write it once in some other place (e.g. by clarifying "Currently supported by DPDK"). Falls outside the scope of this patch though. > Getting Mellanox OFED > ~~~~~~~~~~~~~~~~~~~~~ > @@ -288,8 +293,8 @@ behavior as librte_pmd_mlx4: > Usage example > ------------- > > -This section demonstrates how to launch **testpmd** with Mellanox ConnectX-4 > -devices managed by librte_pmd_mlx5. > +This section demonstrates how to launch **testpmd** with Mellanox > +ConnectX-4/ConnectX-5 devices managed by librte_pmd_mlx5. > > #. Load the kernel modules: > > diff --git a/doc/guides/rel_notes/release_17_02.rst b/doc/guides/rel_notes/release_17_02.rst > index 699487dfe..6da4d0f8d 100644 > --- a/doc/guides/rel_notes/release_17_02.rst > +++ b/doc/guides/rel_notes/release_17_02.rst > @@ -61,6 +61,11 @@ New Features > A new network PMD which supports Solarflare SFN7xxx and SFN8xxx family > of 10/40 Gbps adapters has been added. > > +* **Added support for Mellanox ConnectX-5 adpaters (mlx5).** Typo, "adpaters". -- Adrien Mazarguil 6WIND