From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com
 [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id 69DD6214A
 for <dev@dpdk.org>; Mon,  9 Jan 2017 00:05:16 +0100 (CET)
Received: by mail-pf0-f180.google.com with SMTP id f144so16156848pfa.2
 for <dev@dpdk.org>; Sun, 08 Jan 2017 15:05:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=rVQor/GdKiCEfiNpFosmzqxiI5EZRXuGuoq67q1gFVA=;
 b=SDBQ1L+60S0PIDIdZo0uPGiT/vzDXH/OkTX4rS/+3MDGa8UbqWXxO8rFj9XDRNKFkM
 2+Af86UI2hBFIYCwW1aoMKId39jowDIa0pV9bVbEURkgJsiBRCJCs4Vn/7LjDs7Z1fRm
 pwF0AC0XQKLy7iU24tCbWCyJZzr4uI6Fe8VCRCR4isbLLXcgnWCIvUz5F3hBq36040Hl
 wyd2Bd8kg8IzpQhbnli30AoawZ0+GOz1csRkE4tILKC/0pJGSpgHRx4iBGpf0Jhz+3/H
 kwyvzMcSHbQDV/YRDQenB0l2odmYI6uBsOUhVWSpwFSHdPE1I0zXt8kViFoykLVtPfRi
 iEZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=rVQor/GdKiCEfiNpFosmzqxiI5EZRXuGuoq67q1gFVA=;
 b=QCmc/occSjBvOa4p2QqNd+ukXh2ww0XGqDdsQ0qKhLsq5TbnYkXQLcIlRZKlA7qKfD
 CuLsOR9RDLM+tSRgnMLGtxt+Kr07NBoSCW86KSL2kfrE7jCu0g3N8B8tyWA8i07lgm5q
 c+36dxSaWkaayDmvm+uajV5sjd1xdIU921fK+XzTqsAt0Gy2p9XgHhpqjwKNTadYl4Je
 3V9kCS5UocVIyWYnz84bxkGXMD1q5JpsDpnEX6loV56LUBJKyCHljSEKKlJFWNFdOGDw
 7fUqRtJ174JldcJCpb04/EN5vSfU0N9zpGbyn5Yy/0IsVKIHROCkDPnEI2LeOvhAWrRm
 wu7Q==
X-Gm-Message-State: AIkVDXI8DHZiNPVSq7LuLOeHlN0nybUhlJ/s15dEX+LwCN9yIk4BvrzCSbUshbPBpnp36g==
X-Received: by 10.99.239.5 with SMTP id u5mr157388943pgh.61.1483916715770;
 Sun, 08 Jan 2017 15:05:15 -0800 (PST)
Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65])
 by smtp.gmail.com with ESMTPSA id z9sm22043391pfg.86.2017.01.08.15.05.15
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Sun, 08 Jan 2017 15:05:15 -0800 (PST)
Date: Sun, 8 Jan 2017 15:05:13 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Qiming Yang <qiming.yang@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, helin.zhang@intel.com,
 remy.horton@intel.com
Message-ID: <20170108150513.6a57d4f0@xeon-e3>
In-Reply-To: <1483848695-44643-2-git-send-email-qiming.yang@intel.com>
References: <1483531428-14481-1-git-send-email-qiming.yang@intel.com>
 <1483848695-44643-1-git-send-email-qiming.yang@intel.com>
 <1483848695-44643-2-git-send-email-qiming.yang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Jan 2017 23:05:16 -0000

On Sun,  8 Jan 2017 12:11:31 +0800
Qiming Yang <qiming.yang@intel.com> wrote:

>  void
> +rte_eth_dev_fw_version_get(uint8_t port_id, char *fw_version, int fw_length)
> +{
> +	struct rte_eth_dev *dev;
> +
> +	RTE_ETH_VALID_PORTID_OR_RET(port_id);
> +	dev = &rte_eth_devices[port_id];
> +
> +	RTE_FUNC_PTR_OR_RET(*dev->dev_ops->fw_version_get);
> +	(*dev->dev_ops->fw_version_get)(dev, fw_version, fw_length);
> +}

Maybe dev argument to fw_version_get should be:
   const struct rte_eth_dev *dev