From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stephen@networkplumber.org> Received: from mail-pg0-f44.google.com (mail-pg0-f44.google.com [74.125.83.44]) by dpdk.org (Postfix) with ESMTP id C318D152A for <dev@dpdk.org>; Mon, 9 Jan 2017 18:25:15 +0100 (CET) Received: by mail-pg0-f44.google.com with SMTP id 204so23157444pge.0 for <dev@dpdk.org>; Mon, 09 Jan 2017 09:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZQKhgb8RPCWqhtu3cBMP1apXzff5y/MQThfOuG7kVbU=; b=zlHWB4bAQqdNNPbRLu9bb4APolKNhbJSuND/ogS/Zo1gGkBch2KizQPiY5llETk8/a 6oKO7ITIQ125aeJwGrzs+jWl4CyH+0TKIMQ+X+rPecWO631t26avcDT6Xand2v6Vxb2Z yWHZZKyrqyk1S1kuQAxXgpP3r8PNnOs9TJ1rRLKZAnDa5NCb6l3XrD8R1ofh32LX965W KsVWhHQpQ7jP176qrN2lpikTu7FFFjCdcDSL63RnjAUAe9WqZ2GAMSDlwgfqlVNAWQjw 1G8s1dkdSx8Tgk30mgEQeZzmsxf0ciMrs3dN2YLE7fSVUXwa+uKHsCSk2sJ0+aOKYVvD 6fCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZQKhgb8RPCWqhtu3cBMP1apXzff5y/MQThfOuG7kVbU=; b=Pgc7q82G+4lKUSXJaHHLaLpb0W98GzA37Yc54gG9jxLQRAgINVi4eClh9pgljHyF1f IHvXuP5Q2/d36Czzun70WmDN+GeOmC4e63Oth5hIqi/5S9iMRi/SqW4OGm6h/pbaH6bF ub9+b1xLDuuHCRXuzgjNhStcvTR01jrQptrYZsJP08PxsOGsD5LhV5bLAV++PN/VF6P2 3y8sqb19wMkZ+Tdf464U7zHGyUx68xzuqH7f58enIkCNKzeKBuKvAzTQ9bHA+t6SsIcH /N13zcS5ewBlPDKg26O04AckR5TT+s9bNw0A4ikwud7Cyxis3tKJYa+FpF/LjkzhtDee DWCw== X-Gm-Message-State: AIkVDXL6lf9Fcn0Tz0TN3ELfNJ5R+RyKIye0x/sKSsnvZDixdZeshZaISsGjBN8dIF07aQ== X-Received: by 10.98.152.79 with SMTP id q76mr3361234pfd.147.1483982715047; Mon, 09 Jan 2017 09:25:15 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id e5sm180742742pfd.77.2017.01.09.09.25.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Jan 2017 09:25:14 -0800 (PST) Date: Mon, 9 Jan 2017 09:25:12 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Thomas Monjalon <thomas.monjalon@6wind.com> Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, Michal Miroslaw <mirq-linux@rere.qmqm.pl>, "Yigit, Ferruh" <ferruh.yigit@intel.com> Message-ID: <20170109092512.08d52b9b@xeon-e3> In-Reply-To: <2026939.L9sH03DzKe@xps13> References: <cover.1481590851.git.mirq-linux@rere.qmqm.pl> <9BB6961774997848B5B42BEC655768F810CC0197@SHSMSX103.ccr.corp.intel.com> <20170109120255.GA86544@bricha3-MOBL3.ger.corp.intel.com> <2026939.L9sH03DzKe@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 09 Jan 2017 17:25:16 -0000 On Mon, 09 Jan 2017 14:18:58 +0100 Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > 2017-01-09 12:02, Bruce Richardson: > > On Wed, Dec 28, 2016 at 03:51:56AM +0000, Wu, Jingjing wrote: =20 > > >=20 > > > =20 > > > > -----Original Message----- > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michal Miroslaw > > > > Sent: Tuesday, December 13, 2016 9:08 AM > > > > To: dev@dpdk.org > > > > Subject: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability > > > >=20 > > > > Signed-off-by: Micha=C5=82 Miros=C5=82aw <michal.miroslaw@atendesof= tware.pl> > > > > --- > > > > drivers/net/i40e/i40e_ethdev.c | 198 +++++++++++++++--------------= ------------ > > > > 1 file changed, 73 insertions(+), 125 deletions(-) > > > >=20 > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e= _ethdev.c > > > > index 39fbcfe..4d73aca 100644 > > > > --- a/drivers/net/i40e/i40e_ethdev.c > > > > +++ b/drivers/net/i40e/i40e_ethdev.c > > > > @@ -763,8 +763,7 @@ i40e_add_tx_flow_control_drop_filter(struct i40= e_pf > > > > *pf) > > > > pf->main_vsi_seid, 0, > > > > TRUE, NULL, NULL); > > > > if (ret) > > > > - PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control " > > > > - " frames from VSIs."); > > > > + PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control > > > > frames > > > > +from VSIs."); > > > > } =20 > > >=20 > > > You are right, it makes grep easily. But it will break the coding sty= le "Line length is recommended to be not more than 80 characters, including= comments." > > >=20 > > > Any comments from committers? > > > =20 > > Being able to grep error messages is more important that having lines > > wrapped at 80 characters. I believe checkpatch ignores long strings when > > checking line lengths. =20 >=20 > I agree keeping strings is more important than checkpatch conformity. > Please, if checkpatch complains, try to tune the script checkpatch.sh. > There are some options to manage strings. Checkpatch does not complain as long as string is on one line. i.e PMD_INIT_LOG(ERR, ""Failed to add filter to drop flow control frames from VSIs.= ");