From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D6BBC152A for ; Mon, 9 Jan 2017 15:06:39 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 09 Jan 2017 06:06:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="28023230" Received: from unknown ([10.237.221.61]) by orsmga002.jf.intel.com with SMTP; 09 Jan 2017 06:06:35 -0800 Received: by (sSMTP sendmail emulation); Mon, 09 Jan 2017 14:06:35 +0000 Date: Mon, 9 Jan 2017 14:06:34 +0000 From: Bruce Richardson To: Jianfeng Tan Cc: dev@dpdk.org, yuanhan.liu@linux.intel.com, ferruh.yigit@intel.com, cunming.liang@intel.com Message-ID: <20170109140634.GA94516@bricha3-MOBL3.ger.corp.intel.com> References: <1480689075-66977-1-git-send-email-jianfeng.tan@intel.com> <1483502366-140154-1-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483502366-140154-1-git-send-email-jianfeng.tan@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-dev] [PATCH v3 0/7] virtio_user as an alternative exception path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 14:06:40 -0000 On Wed, Jan 04, 2017 at 03:59:19AM +0000, Jianfeng Tan wrote: > v3: > - Drop the patch to postpone driver ok sending patch, superseded it > with a bug fix to disable all virtqueues and re-init the device. > (you might wonder why not just send reset owner msg. Under my test, > it causes spinlock deadlock problem when killing the program). > - Avoid compiling error on 32-bit system for pointer convert. > - Fix a bug in patch "abstract virtio user backend ops", vhostfd is > not properly assigned. > - Fix a "MQ cannot be used" bug in v2, which is related to strip > some feature bits that vhost kernel does not recognize. > - Update release note. > > v2: (Lots of them are from yuanhan's comment) > - Add offloding feature. > - Add multiqueue support. > - Add a new patch to postpone the sending of driver ok notification. > - Put fix patch ahead of the whole patch series. > - Split original 0001 patch into 0003 and 0004 patches. > - Remove the original vhost_internal design, just add those into > struct virtio_user_dev for simplicity. > - Reword "control" to "send_request". > - Reword "host_features" to "device_features". > > In v16.07, we upstreamed a virtual device, virtio_user (with vhost-user > as the backend). The path to go with a vhost-kernel backend has been > dropped for bad performance comparing to vhost-user and code simplicity. > > But after a second thought, virtio_user + vhost-kernel is a good > candidate as an exceptional path, such as KNI, which exchanges packets > with kernel networking stack. > - maintenance: vhost-net (kernel) is upstreamed and extensively used > kernel module. We don't need any out-of-tree module like KNI. > - performance: as with KNI, this solution would use one or more > kthreads to send/receive packets from user space DPDK applications, > which has little impact on user space polling thread (except that > it might enter into kernel space to wake up those kthreads if > necessary). > - features: vhost-net is born to be a networking solution, which has > lots of networking related featuers, like multi queue, tso, multi-seg > mbuf, etc. > > Signed-off-by: Jianfeng Tan > Sounds great. However, I think we'll need a how-to doc for this to help people get it up and running as a KNI replacement for packets to/from the kernel. Any plans to draw up such a doc? It would be good to include it in this patchset. /Bruce