From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f169.google.com (mail-pf0-f169.google.com [209.85.192.169]) by dpdk.org (Postfix) with ESMTP id 76C50326C for ; Tue, 10 Jan 2017 00:30:31 +0100 (CET) Received: by mail-pf0-f169.google.com with SMTP id f144so25714172pfa.2 for ; Mon, 09 Jan 2017 15:30:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1p6iNB/fvEMGhNN0HmuNpaw/o6MxRQYTHVtImnLYkzs=; b=ktEhqjIK/BOTZwhv8uuZMmX5P8BCH4cm1dGrft/mG37ICs7vKicq0A/Vk1C8yL/i2c cbuMxaKMkKm8HxPfQry+nfHUCCT6INdl/sSR6dG389wavNSIoCgCKP52/+zPsn8UOVxX +FQZX6vZodXxYyukhgGl6a6VYsmWpkITpttky8jD42X6vnvRsVfFlFd6Epnp6rcqHhmv NgTKRDm5hHfrvIJ4tMski70M7Vn5zI+wT+ClfGDe9wkC8sHUivBuTJn/hyYdiWPX4+3l vA10yw7QhxYAWy9q4y7peBk5Fcpfu+D2cQLMQVJdsmZYNL6TPZZ56tTJGuxbFYS+55TB GkdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1p6iNB/fvEMGhNN0HmuNpaw/o6MxRQYTHVtImnLYkzs=; b=Ot6Q/5Q/9gglv4SO5XSVe5rb0zpIuXGpdgoF9RTPmR/v34QgdEJ37YWrWb8X9lNbek 81Pmg36wN+sud4n/oDCiOqE78bJa9YsxXe8TthoCfgkaFhtP/SxknEGq6tOWq/U83kgE DDdCvwc2BVVRoQaDY2+KVPES0LyFNcIK/zgCW8svu3LjTrLhN6IGboB+QzesdgmI8RNn cUlJftoR4Tgkj2k2oKDUS9jCTniEO4GSSHnKyoyHst55uqiiSUGMT/6hbySwvqa3/2gB oEAx05iS4TmpFw0qdaynw7/2HL6mz1BtvQbisUsrFKM87+NZOVbmqYxpsVxtgUWVvQcu fAvQ== X-Gm-Message-State: AIkVDXIB42DYU1ocsvBTMq46+TjvypyxTlpJEJEntg7+4KaejmmnT9tSuMDyDJJVOBQZhQ== X-Received: by 10.99.63.193 with SMTP id m184mr245724pga.123.1484004630568; Mon, 09 Jan 2017 15:30:30 -0800 (PST) Received: from xeon-e3.wavecable.com (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id s78sm12658pfk.82.2017.01.09.15.30.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jan 2017 15:30:29 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 9 Jan 2017 15:30:16 -0800 Message-Id: <20170109233022.31154-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170109233022.31154-1-stephen@networkplumber.org> References: <20170109233022.31154-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 1/7] bonding, malloc, bitmap: remove useless return X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 23:30:31 -0000 return statements at end of void functions are unnecessary and unwanted. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- lib/librte_eal/common/rte_malloc.c | 1 - lib/librte_sched/rte_bitmap.h | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index c1796f22..dd9cfa47 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -241,8 +241,8 @@ arp_op_name(uint16_t arp_op, char *buf) default: break; } + snprintf(buf, sizeof("Unknown"), "%s", "Unknown"); - return; } #endif #define MaxIPv4String 16 diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c index f4a88352..09970b06 100644 --- a/lib/librte_eal/common/rte_malloc.c +++ b/lib/librte_eal/common/rte_malloc.c @@ -232,7 +232,6 @@ rte_malloc_dump_stats(FILE *f, __rte_unused const char *type) fprintf(f, "\tAlloc_count:%u,\n",sock_stats.alloc_count); fprintf(f, "\tFree_count:%u,\n", sock_stats.free_count); } - return; } /* diff --git a/lib/librte_sched/rte_bitmap.h b/lib/librte_sched/rte_bitmap.h index 010d752c..d432fdfe 100644 --- a/lib/librte_sched/rte_bitmap.h +++ b/lib/librte_sched/rte_bitmap.h @@ -453,8 +453,6 @@ rte_bitmap_clear(struct rte_bitmap *bmp, uint32_t pos) offset1 = (pos >> RTE_BITMAP_CL_BIT_SIZE_LOG2) & RTE_BITMAP_SLAB_BIT_MASK; slab1 = bmp->array1 + index1; *slab1 &= ~(1lu << offset1); - - return; } static inline int -- 2.11.0