From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f175.google.com (mail-pf0-f175.google.com [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 7EAC65320 for ; Tue, 10 Jan 2017 19:03:29 +0100 (CET) Received: by mail-pf0-f175.google.com with SMTP id y143so29783513pfb.0 for ; Tue, 10 Jan 2017 10:03:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Gr7ADQSD/zGkcTmAa/PQj95/EluUOOF2Wrn9pFtLntQ=; b=zypt0PpqpPDeTFDsExrdGXWf4FIvu0NNaQsLbRA1LcIYJ+1h+2OEKgJtZu/DRzaeBp OZt69bENAIDHmBcWRgzTQPQhms74I9iswfjCtdgaDkbbvFwcHJeEySjlXzeH2d0tFxOq g10cnsgR+QPKjnabyknZOyEJm0X1fWT6EI9y2rqF3hWKsVheC+fHkNvy3yBzB04zgtjo cqBKGXPxQ5ue5Ay4EkI7VzjMpXvbG3e6HnMJjZyNG3plh64Oquk6bn/9YzZpPNeJj6HC X+136XjYK0gADdL2hZdDAhTe+0MfHhCHcpHWD8KnrnsfFo9xfBny/NWK7ZQOdrLWMORX 9TLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Gr7ADQSD/zGkcTmAa/PQj95/EluUOOF2Wrn9pFtLntQ=; b=igOzWIl2fdKyPhRYuIYXoOJ6aPDZVJ4YPPJceExb+BTFKYrO1bfcqAzk0hhsySva80 VhOk5TWkBM5DX6SIKl2IKHxuY+NVfkNYlruFP+Htp91H2aEWAof0JRoBA+Si6wVEufKP Rz8DDtKFn5ToSWuOEjO7X6vsFT6j4aDorzaT3bUKlzibxuaf4pLU5N9M6S4X8btdiLKx OUH5yvQo7KBQ2gRM+zLsAZXuGAK/FNOcbvvfqraKWak/X4R0E2cY7X/62ef4xzuKi3ss EQ+JvLs73F3I6oto1kSrj6YU1s+yYYjdI0tt94U0aEUppE0GDhfQKmfVrDivfpsYqN+k ZTuQ== X-Gm-Message-State: AIkVDXK8jG9kJk9gQgXbVb/hSChtbf2KZF2vVjIDyZ35At6F2klKd+staBl+oCeALSmn/Q== X-Received: by 10.84.191.131 with SMTP id a3mr6661489pld.62.1484071408638; Tue, 10 Jan 2017 10:03:28 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id 21sm7393973pfy.4.2017.01.10.10.03.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Jan 2017 10:03:28 -0800 (PST) Date: Tue, 10 Jan 2017 10:03:21 -0800 From: Stephen Hemminger To: Jan Blunck Cc: dev@dpdk.org, Stephen Hemminger Message-ID: <20170110100321.4d53be0a@xeon-e3> In-Reply-To: References: <20170107181756.1944-1-sthemmin@microsoft.com> <20170107181756.1944-8-sthemmin@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 7/8] ethdev: break ethernet driver and pci_driver connection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 18:03:29 -0000 On Tue, 10 Jan 2017 17:11:15 +0100 Jan Blunck wrote: > On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger > wrote: > > There are multiple buses and device types now. Therefore it no longer > > makes sense that PCI driver information is part of the Ethernet driver > > structure. > > The Ethernet driver itself doesn't over alot of value from an > abstraction point of view. Its questionable if there ever will be an > Ethernet driver that is able to operate on different types of > low-level devices. The virtual devices are anyway able to operate > without an Ethernet driver structure. Most of that functionality > should get moved either into the bus abstraction or the low-level > device probe function. I agree that that 'struct eth_driver' is not adding a lot now. It should really be all folded back into 'struct rte_driver'. The concept of init, uninit and private data are all generic and not really specific to ethernet in anyway. If we kill off eth_driver then PCI devices only have rte_pci_driver and VMBUS can have rte_vmbus_driver.