From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f50.google.com (mail-pg0-f50.google.com [74.125.83.50])
 by dpdk.org (Postfix) with ESMTP id C9F92D592
 for <dev@dpdk.org>; Wed, 11 Jan 2017 17:15:12 +0100 (CET)
Received: by mail-pg0-f50.google.com with SMTP id 204so29346525pge.0
 for <dev@dpdk.org>; Wed, 11 Jan 2017 08:15:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=E5dX3BRzK1kpi+lVNyiM+Csipay5PE0hd8egNb+uz2o=;
 b=apxhxacLGdyvMhblxF4MrcB+gbhjwNe3KIjIn6tbJjKB4il6XZ6evJN+wXsASzIEjM
 y/A6JjS/fA4WREiPilj46ql7yIFOY2EJHk2BQoglrlMAY8GaStoaEykzXTlEqPDc9lM+
 FFZffuQJYyW5NDfqxUmlRjMmy2wPAdLmamzkjISmZ3T8PL7TtmdOtWOKDtgUqEVOqDHp
 3eSKNdEanFEafIEPpVGi5fJHKPjXCK9tPm+KCWq5z8UfAqaUtkBkKHjXbsgKylQqJb4o
 b0ORfrrYfnt+UYARnunmcW07t8oNLyGWz8PGG22iAoGXKo7pZUXVZZSInIrRkROlhJc5
 34uQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=E5dX3BRzK1kpi+lVNyiM+Csipay5PE0hd8egNb+uz2o=;
 b=c7OfrS1aCu7jrMlCf7BVs1yOv3a0nkn6IH0YIhEXKcxDvDJ18md51i8h3zOK4dRWSx
 xmVYbCnVK7phzG1H7vI5/nlMD2h7kuVARA8pxigr0eGhOhYFb+YF01f3jaQME6N7EBbl
 kxZwCcuGHq6Bac3XuUHq/a3oXOlpkBkAoa1zOBaooJfq59TO7jNi94Xd61kfVGcjfGC+
 N5KsXjoJ7ikYJ/WqHaChOk2b9vtF+2NlEwWdNechnnZ/80+zWtga4nm8cRoiByQXyy73
 /xknwUe1UXJfwZe3DjVBgL0O9N91TDm+L7WoFC0hOZoU14WHexeiSUAw1tqnIdSObd1i
 erSA==
X-Gm-Message-State: AIkVDXLLaQ5Ms1CnlAKb6qPbigsJxMUUirlK/2qx5hYEwq/Xz1HZiz7g4AdKNSbvxxmESg==
X-Received: by 10.98.152.79 with SMTP id q76mr11090405pfd.147.1484151312140;
 Wed, 11 Jan 2017 08:15:12 -0800 (PST)
Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65])
 by smtp.gmail.com with ESMTPSA id e5sm14963214pfd.77.2017.01.11.08.15.11
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 11 Jan 2017 08:15:11 -0800 (PST)
Date: Wed, 11 Jan 2017 08:15:02 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20170111081502.220f6824@xeon-e3>
In-Reply-To: <1484150594-3758-3-git-send-email-remy.horton@intel.com>
References: <1484150594-3758-1-git-send-email-remy.horton@intel.com>
 <1484150594-3758-3-git-send-email-remy.horton@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v6 2/4] lib: add bitrate statistics library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jan 2017 16:15:13 -0000

On Thu, 12 Jan 2017 00:03:12 +0800
Remy Horton <remy.horton@intel.com> wrote:

> +
> +struct rte_stats_bitrates_s *
> +rte_stats_bitrate_create(void)
> +{
> +	return rte_zmalloc(NULL, sizeof(struct rte_stats_bitrates_s), 0);
> +}
> +

You want these statistics to be cache aligned (ie not 0) to avoid
false cache sharing.

Since these statistics are often associated with a device would it
not make sense to have a NUMA socket associated with the alllocation?