From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0083.outbound.protection.outlook.com [104.47.33.83]) by dpdk.org (Postfix) with ESMTP id D3A042C6D for ; Fri, 13 Jan 2017 03:50:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=nuSJ9jtUSAnnOkkB3FPPGAoVRTPwLWbQKal5/n0NdpY=; b=YwKJLN5dt51OA+n2vsXeBW19D/K6iB+esYabSdQXOY3XChcsDAgyfsMk4zc2ckKcbfXQcu90iWsp6dC1/TF5HPEWdvfKBEVWYGEQejawSIb/P0LZJ0eS60Dri0ldMfsNVYgwwRh9TpbSeQ0H1AYu95N5cmqPCHR3d5f6tnV5zog= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (171.61.97.114) by BY1PR0701MB1724.namprd07.prod.outlook.com (10.162.111.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.817.10; Fri, 13 Jan 2017 02:50:24 +0000 Date: Fri, 13 Jan 2017 08:20:06 +0530 From: Jerin Jacob To: Ferruh Yigit CC: , Message-ID: <20170113025005.GA2951@localhost.localdomain> References: <1480205562-32745-1-git-send-email-jerin.jacob@caviumnetworks.com> <204efa1f-0631-ed9c-3d68-8c573edfbb76@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <204efa1f-0631-ed9c-3d68-8c573edfbb76@intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [171.61.97.114] X-ClientProxiedBy: PN1PR01CA0023.INDPRD01.PROD.OUTLOOK.COM (10.164.137.30) To BY1PR0701MB1724.namprd07.prod.outlook.com (10.162.111.143) X-MS-Office365-Filtering-Correlation-Id: ee4ca477-bd42-4f81-7caf-08d43b5eed50 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 3:Ii/muw8Kg+tKMCCA4sJD4liCLqcPEhvRKTsjPzjJd8NWqvhqe2TrGq/DndParRYbmqTedWsBLvxbV1hjKJdJqTdlmyxCO85h3CAniY5VeSi4Ik3bIjdwF98FGxhsUequAu8LU2UfL/3viJHhVfZAyXr2QjAQoOqam9T18ErIX1SJIoBBNQU9IQnMCt5T/kcmt2Fd6uSab1h0yqYcWjzYGBw/OReAbSylp/TrgdqzgxZV4lNkp9QakRfk21MCYQ1YHhNnEoPKJUZBRHj/m19jyA==; 25:LPVRSjCHm0Ce7rrLCjL2p4LY8gmjSlMnLFaYVqdOsFJU8UuWiUsmHHSxv67+JWuAOVj+aX0HdPJzgGBmeU5nCDczNH4LPq3McdmN23zU5dTkffp3saePyHWJfNhGopE2IwLPR+JBpyurDOtTtfFVKLAlEzClGVMLLwLeoROebM2k09fMFRdcWY4zd8uhl+UJ9DsnPQhVnFLmbeZvBb71eHSLDvocYK86p99fPxS3NHV5MQnSadMVzRy0q+bnfDACOTrxU4KwRij7M3PntoVrzq3vpXzyvjOwNv4/ZBn99dQB/16MJ+NznuoDhSQolGw9CMvHYqd8Zfe5bwDbNi8kNFkjqPRtSl6jA/tNaGk6FCvOYxRzghxNFeTS1fmx54s+FasOk3CWunGO6tfZER08Ky/Ca8LC8ToBs0q8ibTGDVHfFxo2Te0l9BygQDxbg0ZNYSXU1kE9uJVjIyRPgkpC7g== X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 31:Io7MZIw8lNRrz/3dUPrD4p1h8gfYZPqt2Bq2kRCzBntZ8qEoSgtCer4OlmYuvlv419ipdXAzFMDsg3WcJuVIRlQJFhaLIMi8XvLG5rJogw13rgyBorffDLRZXW2AOUzOSkkFJGQbclPsVq6M2Bf1YKofCgoI20v5ZHUnLjLfEuDx5cF5xBQzYtbR+CvfYb00LNahnHiVdT5MKIGT0ME0710xvU0dUPoQnbXQcL1HeC9hfG0qcQEkX9ZLerl2f3vBqkKC1ET3gJWbJccFpW5k45bppe+MN/5rT0DvNpOnkS4=; 20:EGOaOXcutA8OYUKRQEj+3CJ7AhnSNxzsY+2WjiBef3zgentIqYCz1h2GNl7gtV5UZDuQWDB15AIgnfEwgfUZM6i5V5Xbv+7HAYwmNe1Q2sXYn5UL23SKMgQ2PVWwUIUheyLoqm2LHyovQLkaRN6dC1UPQSKZw4QfRjmqFGXpFUXP7Bg+xf9iWCG14eaF3Urqw6t1PAP884dcg+01AtcGWZ4MlOTd+Hr8YrmJwbiLs873VNPDfoQCx7EhDIDHZiAKlS1g8LGqCwbJYqeb5skOEkvqGxRKYN7L+ZXRbppiRse5M0qbA7Jy6W3chD7ZlzO7wDF24S1r/i1GjhP8pE4wsAuM10+8UyN9aXyv1yPPTSJTkFbtTkbuhtfxjRE59Fdx1dMT4tvaEoRpnwTDo1rd0UicETEnzelamcpRMD/OC6t+aK0jdC/hkc8Cj40D970TkL56AAYQ8sDkhBGtuZMqgUOcak+mx5BcMBS7mkHx5IvndQIEXR8lF0haeSaMaiuFKJvo7RDJT/raiLPAYxZKOojoYMjA8uwtjXP9CMfzf6rREzZWFJMiIzkV1aNKG8HmpBhP3/RPizZLoHx5FUwdpg0FLJ0aoN+KSOQh66dzl9Q= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148); SRVR:BY1PR0701MB1724; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 4:gVSiOV02nASNpygPavMBZog94ZeyAfgDR/JLcnrOE1qm+xfRlDBrOWjZy01ttFFYac1zzHOoaD2R0cZLOKOHbXomVxLMikNoZG/41vapQRDugJ4D8F5EddrhCXhuhTG2a7PLHHLnCWR5e57VnxTIG3C2sb+L/GYJrUe/wT0VEPwhsRAEMq6zT1jvSRMfE0L9K+H3UViyPMAYUV9lBLGBHw1vrOTcp8UH8CfnIYQg/6xr5FwM4tiaFmqumR+owHRulI3YsLcdrHPmhjS3y/kofnCDzFRoSs6XCKVT3K/xiON/U5IF2rBUPMJQgdar1xk6D+FBE0qOobGN+SiyODFC5b3snqJcgOdh9iQ+WbuK+xuGFr4KneEFOeoRIwh6yAM0vRorWjUB29WioJ+yO6DO1/IFU9n7o38r8b4hdaxjXX11xpiaUmVEP6R4dXJxDJRH88O7qBWWiN1YZQ71M62ywMviUEjbXd6SsPpFx5Hm8eenO7CCL2q6AM4RHorfXN2Pwiy8la/oFAuYjhTODULiniMu7frYPHaKIMNiaw83qSffpYbfDGB2M7VqJGSe0rbES5deoxHTNVNdZbUI5DzwC10uxcMgEC2EPcNiamr4BT92OLYJyIQJZ7vr+WWdaC4p X-Forefront-PRVS: 018632C080 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(39450400003)(51914003)(199003)(189002)(24454002)(377454003)(68736007)(47776003)(46406003)(55016002)(7736002)(25786008)(189998001)(33656002)(2906002)(97756001)(4001350100001)(105586002)(97736004)(50986999)(76176999)(4326007)(54356999)(305945005)(5660300001)(101416001)(92566002)(106356001)(42186005)(81166006)(110136003)(81156014)(229853002)(66066001)(50466002)(1076002)(2950100002)(42882006)(6916009)(6666003)(8676002)(3846002)(61506002)(23726003)(6116002)(83506001)(6506006)(38730400001)(54906002)(9686003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1724; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1724; 23:TWFXMrErtzW1g8sFS5S1NnqLk7xkGY8zdCWsJkB?= =?us-ascii?Q?LVxNNvwBckMhZ+btfLQcXaBvyg9eXhgYw3fSjW8ZAbIPvohjht3p7NFzI59U?= =?us-ascii?Q?sjbfbAVOMZzWvS6cGhZ4kqFr2CesVF9tXR2pcoyN+RUCYZ5jp/p2vwSp3H4W?= =?us-ascii?Q?Uvv6LyxoBfj8vA0iEgnsvVrJB7W0/M4t9Rjx2iEK9hurdYr4MMTw+CmtCnOz?= =?us-ascii?Q?TIgC8jKxsA1/KiY4WjS9c51W6wOs6pWd4vZjo2htwW1D6DbLg9JBG2hUE983?= =?us-ascii?Q?nW4vsFkarJfXAy/B6zRUQHqq6XHlsGeFFAwTMW+ADLBFZ7npyiydx0nb08mc?= =?us-ascii?Q?n94Jx+y3zV66tqpuiQvhmYNLdKORk+SpJNyOwr2fJD4abDdqAjtAhtl77xTh?= =?us-ascii?Q?suH3Q01F35fbUjHGdum9H69zI5ITacI8qrRC/nY/+bfSgXELUxRhFadcZU0x?= =?us-ascii?Q?X4sU1O0mKH90ZowC6Wra63XfQqiKGC7Yp4qxanaAQRSOmXnz7pteox+AHy0K?= =?us-ascii?Q?lKDOLOsfiY6J2d75CSvMHRVGSvtKJ1Mh6kF8lX0rrlIs7leGlIqgyftd9OFd?= =?us-ascii?Q?4SD0YY07fpI0cRduGmp5qiEW3pmXAoyhCnvfXvfe4UudUL5rCvwLSaLAZuXm?= =?us-ascii?Q?rl+B3RQTKFQ3EIfkik4QdznId0pNeVh3ReQfB3v/SP88/Y1IyUYajmnjY1/1?= =?us-ascii?Q?KqJKUCzu6fZX5k7scoP8lppqPmEZEw68UTx8hcB4koIY2oWk1jfb9uXFgQEa?= =?us-ascii?Q?V5przQY28xDLVque+3u21vDkM7v5uY3Bu3VFjAqctDI81/6O+cvrVIqwtT0x?= =?us-ascii?Q?GA7PR+1ZVIQGKuk7CunS+V+utmGdSijb0KJo6WQQRjMNA7xet4y0sj4zcaDK?= =?us-ascii?Q?KsX6DSLBZ3DaghkBcytoENke4A4fhG2iM0AjtVzq+z/pVNj40PDN2DJc5DbI?= =?us-ascii?Q?dHLSb/o2aId4BWXH2LXUSEIute/KMHUBjDrkpFFvqs83UmodYu2IHtLKuBm6?= =?us-ascii?Q?B1JFrmoFVsibgJIRZqvwNo/32aYApNI2gzssOIj8TpqTo7ZPvGIHY+AJy9GV?= =?us-ascii?Q?aOlxzOIF6dFwuOeev4tUpbGLpdFnwa/+ghOQKs9AlT1MzJFRhfzpIlaAKt5z?= =?us-ascii?Q?5F3Ew+76P4ECeVPD9VLrTobsE6DX0/o5flqmmvXSYJ1G6sJDuBIljqwKyZbp?= =?us-ascii?Q?SN/exmfEz1rHZjPSXELlUcZ+Nw5Kx20HXtf4BtwF8HsxPzkKmLaiDbXU/UHA?= =?us-ascii?Q?MFRKNz/EmtOsQ+I1PvlUQVCVn2Ww+YtfgMR3hKgJn2HjJreSrmDwMyUZvxIv?= =?us-ascii?Q?lapEqYcQIJXD3EeXiuBJDBSQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 6:seGNuqwvUr4erabUE6rgmPPUYz9FTvpGRWzVdxOxpk4BAZKna2BafonymGvSklDEF7tXE9DVwfTO4JH633UOJJni1zoGqe5ErmzpsLHsnLL6DqMIXxBzJaKjg30AAc0cdqZcUJW18LJ0719enWfX+I3Kf9i/KYWfOLKnJ9YGFr/snr413dGsH/fcpcTIWxQPkwGZA+7vDz457aP4PBjKL13GXhjNq6ymd80JHtMRRGgZVEuab+uWv25Yt4ju9RSPJsKJaOnRuD5ZYOBLt3N4XHFZyIkUEafBbJ8Uzx9FAvl6Ev7PD7rAblQWAs9XZLjJerK0Cl/pSiklSAwoGogrngnrBHQRJPLrLV8yF36+6EeEFLUi3G1WFnBK13Ex8utcean8POmEUQ4gr3DMuYF4FD4habkJ0fQRXZXwueYL5R0=; 5:lx/ey0JlKlZX9A7LcqVOrkpNVD084CBflFABdEBhy1Y2Gr8we7eKpPuj8tquA6vnaOaH4FlaqFUm2B2kJEP9ldayfnP1pjf8qP0QU5ZqOXZnuq9fjEKoHWYRshgSGBJjK782zHqvw+4VtieEODsd1A==; 24:a1xuji/BsLHDhoWVRKbpYwbDrsu7FEc0HlBHzqGqWh/jCneRzfJRPTCxb++ej8TKARdqs/+PRgQ5T1aIZMjjWrLgZ0J+D+MaCk0Rx7p/SGo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 7:c7QCIVsar85ToCsyrxSuOjQBob5/FPNZSqTppfmIAcLRZH69eKH9qJ6PjS4WrLuVUw5LPFAhz6+S2/t9G0Zy+/b6DPg7Rh/DmYzw1ZnV3sElJHnm73NgEgCGW8YplbsIXpcLjZLJAyGo5HtzJDqUbVbU8Z8+nWtJU0PCIzUkg0M0/Q5z2Gkjx7HWiBJZkta9kPq22jaMGurne3OG2DmZWqMYyEa4rHLbsw99Wbod9JP2crJX8GA/9LFnFx5qDtv+WOCc2zz1Q47lU3E7O6myUdWmiY0xvWGmOG9lWwO4WwNmUw0grQjVA5w067+1QOe7/ePyNCQfqaoIB+ea0KCYKcEP0l+qnLlHpjtFzeH//9WnvODZHiafQyvGMkgR8suDULselW+z6gQs8FhJNA6j/qsJp5Ju+fkmsOQAOJyPm0YylhiNKugrat+0HN1c/Hcl5adRXhblXLwdZkQZtq0Glw== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2017 02:50:24.3548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1724 Subject: Re: [dpdk-dev] [PATCH] tools: add tags and cscope index file generation support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 02:50:28 -0000 On Thu, Jan 12, 2017 at 02:19:44PM +0000, Ferruh Yigit wrote: > On 11/27/2016 12:12 AM, Jerin Jacob wrote: > > This script generates cscope, gtags, and tags > > index files based on EAL environment. > > (architecture and OS(linux/bsd)) > > > > Selection of the architecture and OS environment > > is based on dpdk configuration target(T=) > > > > example usage: > > make tags T=x86_64-native-linuxapp-gcc > > make cscope T=x86_64-native-linuxapp-gcc > > make gtags T=x86_64-native-linuxapp-gcc > > > > Signed-off-by: Jerin Jacob > > <...> > > > + > > +if [ -n "$T" ]; then > <...> > > + usage $1 > > + exit > > I would prefer fallback to RTE_TARGET parsing, or processing all files ( > cscope -Rqn ), instead of exiting here, but that is your call. I would prefer avoid any fallback(sometimes RTE_TARGET can be "build" also) and print the usage and exit error if the requirements are not meet. > > > Also "tags.sh" needs to be moved into "devtools" after latest updates. Sure. I will send v2 to address this. > > Reviewed-by: Ferruh Yigit Thanks for the review.