From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 22E15F927 for ; Fri, 13 Jan 2017 14:49:31 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id r144so71668919wme.1 for ; Fri, 13 Jan 2017 05:49:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B1Z0u+NFh2EzsukQpKOqqkKtGCv5ml6Pw8u5Y2GvFOk=; b=lMlqnBsYrFDGE4XvzhqPXXXYwQXUvOy9jaxKWE2lQPqKAaWNzLr/20YkTsxEk0vj5A sTfa7nfT26CzH5pclrtb0XTJsc/Y3PpeOAdc8no8Ofd7IWy+qJkhsiR7L9xATv5nb92T 4hjscMs4KH9Ldd8YKVAqLgqHdtS90aIzQN2YoeOmfp892xp9v/czds99RZyrYl7O/c/I RT5M6AJV0ZNZUlpqYl6CNUBA83bHHo/24pkGz3T1dQukCmO5ZJ4MAfW/Y7TMzjnt+rF8 EkGVr+qqbCOowCcBJ/KSNbApWr6hU6sqJ1FxRXQiheV9/s71CWfukmFZfhrLCws7bknC iaNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B1Z0u+NFh2EzsukQpKOqqkKtGCv5ml6Pw8u5Y2GvFOk=; b=pxNBhcwghQP1XmwmAzciUPxVxuz7FInJ5GRTNZw5ni1iKxm0zu7oUjczs8WCs/axCM LyXubulEt0I4Crz956t2yaBcUj2wgWucVGqqtmGU+KOrc1ohu8wQQ3DR6W9Bn8RYvTZK xZtRuQ6HAj9/WCxH11/S52Nnwm7h9p3fUolJX5dCulSv+pHi6HwNN78Ncn2ZoER+Z6GJ LIkm4QcHyApKwtQxg3AEunV8qM+P+FXoyVFkXaxSAPLc5OEY/BoJQ5oqtmwsWBify22p UQCHR0Yk7cRvebqakAruzODFifjoC7HYJB6t9fo1sCzTyPsT47rADr+DZdNDUaVKJRQo ZL6w== X-Gm-Message-State: AIkVDXIbiKNydjqN9cmfQ7jcGYBg1pOrGMvvq8cGKynmbviXKyMUwjzzjhpKHvuaIZ4BDh7u X-Received: by 10.223.138.188 with SMTP id y57mr11664551wry.191.1484311708594; Fri, 13 Jan 2017 04:48:28 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id w18sm4096396wme.9.2017.01.13.04.48.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Jan 2017 04:48:28 -0800 (PST) Date: Fri, 13 Jan 2017 13:48:24 +0100 From: Olivier Matz To: Ferruh Yigit Cc: dev@dpdk.org, alejandro.lucero@netronome.com Message-ID: <20170113134824.6542fc5e@platinum> In-Reply-To: <2c9b018f-bad8-449a-acf7-e2da82bdc464@intel.com> References: <1484226296-540-1-git-send-email-olivier.matz@6wind.com> <2c9b018f-bad8-449a-acf7-e2da82bdc464@intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 13:49:31 -0000 On Fri, 13 Jan 2017 12:03:01 +0000, Ferruh Yigit wrote: > On 1/12/2017 1:04 PM, Olivier Matz wrote: > > Fix typo when checking that no Vlan offload flags are passed at port > > initialization. > > > > By the way, also fix a typo in the log. > > > > Fixes: d4a27a3b092a ("nfp: add basic features") > > > > Signed-off-by: Olivier Matz > > --- > > drivers/net/nfp/nfp_net.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > > index 65ba09f..ed3c9b8 100644 > > --- a/drivers/net/nfp/nfp_net.c > > +++ b/drivers/net/nfp/nfp_net.c > > @@ -2174,8 +2174,8 @@ nfp_net_vlan_offload_set(struct rte_eth_dev > > *dev, int mask) new_ctrl = 0; > > > > if ((mask & ETH_VLAN_FILTER_OFFLOAD) || > > - (mask & ETH_VLAN_FILTER_OFFLOAD)) > > - RTE_LOG(INFO, PMD, "Not support for > > ETH_VLAN_FILTER_OFFLOAD or" > > + (mask & ETH_VLAN_FILTER_EXTEND)) > > I can't find "ETH_VLAN_FILTER_EXTEND", > do you mean "ETH_VLAN_EXTEND_OFFLOAD" ? Erf... I'm sorry, my mistake, I copy/pasted the log below without verifying. I saw it while watching the code. Yes I mean ETH_VLAN_EXTEND_OFFLOAD. By the way, it could even be replaced ETH_VLAN_*_MASK, but it's the same value. For reference, here are the definitions from rte_ethdev.h: /* Definitions used for VLAN Offload functionality */ #define ETH_VLAN_STRIP_OFFLOAD 0x0001 /**< VLAN Strip On/Off */ #define ETH_VLAN_FILTER_OFFLOAD 0x0002 /**< VLAN Filter On/Off */ #define ETH_VLAN_EXTEND_OFFLOAD 0x0004 /**< VLAN Extend On/Off */ /* Definitions used for mask VLAN setting */ #define ETH_VLAN_STRIP_MASK 0x0001 /**< VLAN Strip setting mask */ #define ETH_VLAN_FILTER_MASK 0x0002 /**< VLAN Filter setting mask*/ #define ETH_VLAN_EXTEND_MASK 0x0004 /**< VLAN Extend setting mask*/ I'll submit another patch with ETH_VLAN_EXTEND_OFFLOAD. Thanks Ferruh. Olivier