* [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check
@ 2017-01-12 13:04 Olivier Matz
2017-01-13 11:36 ` Alejandro Lucero
2017-01-13 12:03 ` Ferruh Yigit
0 siblings, 2 replies; 9+ messages in thread
From: Olivier Matz @ 2017-01-12 13:04 UTC (permalink / raw)
To: dev, alejandro.lucero
Fix typo when checking that no Vlan offload flags are passed at port
initialization.
By the way, also fix a typo in the log.
Fixes: d4a27a3b092a ("nfp: add basic features")
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
drivers/net/nfp/nfp_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 65ba09f..ed3c9b8 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2174,8 +2174,8 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev, int mask)
new_ctrl = 0;
if ((mask & ETH_VLAN_FILTER_OFFLOAD) ||
- (mask & ETH_VLAN_FILTER_OFFLOAD))
- RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD or"
+ (mask & ETH_VLAN_FILTER_EXTEND))
+ RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or"
" ETH_VLAN_FILTER_EXTEND");
/* Enable vlan strip if it is not configured yet */
--
2.8.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check
2017-01-12 13:04 [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check Olivier Matz
@ 2017-01-13 11:36 ` Alejandro Lucero
2017-01-13 12:03 ` Ferruh Yigit
1 sibling, 0 replies; 9+ messages in thread
From: Alejandro Lucero @ 2017-01-13 11:36 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev
Acked.
Thanks!
On Thu, Jan 12, 2017 at 1:04 PM, Olivier Matz <olivier.matz@6wind.com>
wrote:
> Fix typo when checking that no Vlan offload flags are passed at port
> initialization.
>
> By the way, also fix a typo in the log.
>
> Fixes: d4a27a3b092a ("nfp: add basic features")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> drivers/net/nfp/nfp_net.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index 65ba09f..ed3c9b8 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -2174,8 +2174,8 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev,
> int mask)
> new_ctrl = 0;
>
> if ((mask & ETH_VLAN_FILTER_OFFLOAD) ||
> - (mask & ETH_VLAN_FILTER_OFFLOAD))
> - RTE_LOG(INFO, PMD, "Not support for
> ETH_VLAN_FILTER_OFFLOAD or"
> + (mask & ETH_VLAN_FILTER_EXTEND))
> + RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD
> or"
> " ETH_VLAN_FILTER_EXTEND");
>
> /* Enable vlan strip if it is not configured yet */
> --
> 2.8.1
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check
2017-01-12 13:04 [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check Olivier Matz
2017-01-13 11:36 ` Alejandro Lucero
@ 2017-01-13 12:03 ` Ferruh Yigit
2017-01-13 12:48 ` Olivier Matz
1 sibling, 1 reply; 9+ messages in thread
From: Ferruh Yigit @ 2017-01-13 12:03 UTC (permalink / raw)
To: Olivier Matz, dev, alejandro.lucero
On 1/12/2017 1:04 PM, Olivier Matz wrote:
> Fix typo when checking that no Vlan offload flags are passed at port
> initialization.
>
> By the way, also fix a typo in the log.
>
> Fixes: d4a27a3b092a ("nfp: add basic features")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> drivers/net/nfp/nfp_net.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index 65ba09f..ed3c9b8 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -2174,8 +2174,8 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev, int mask)
> new_ctrl = 0;
>
> if ((mask & ETH_VLAN_FILTER_OFFLOAD) ||
> - (mask & ETH_VLAN_FILTER_OFFLOAD))
> - RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD or"
> + (mask & ETH_VLAN_FILTER_EXTEND))
I can't find "ETH_VLAN_FILTER_EXTEND",
do you mean "ETH_VLAN_EXTEND_OFFLOAD" ?
> + RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or"
> " ETH_VLAN_FILTER_EXTEND");
>
> /* Enable vlan strip if it is not configured yet */
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check
2017-01-13 12:03 ` Ferruh Yigit
@ 2017-01-13 12:48 ` Olivier Matz
2017-01-13 13:17 ` Ferruh Yigit
0 siblings, 1 reply; 9+ messages in thread
From: Olivier Matz @ 2017-01-13 12:48 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, alejandro.lucero
On Fri, 13 Jan 2017 12:03:01 +0000, Ferruh Yigit
<ferruh.yigit@intel.com> wrote:
> On 1/12/2017 1:04 PM, Olivier Matz wrote:
> > Fix typo when checking that no Vlan offload flags are passed at port
> > initialization.
> >
> > By the way, also fix a typo in the log.
> >
> > Fixes: d4a27a3b092a ("nfp: add basic features")
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
> > drivers/net/nfp/nfp_net.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> > index 65ba09f..ed3c9b8 100644
> > --- a/drivers/net/nfp/nfp_net.c
> > +++ b/drivers/net/nfp/nfp_net.c
> > @@ -2174,8 +2174,8 @@ nfp_net_vlan_offload_set(struct rte_eth_dev
> > *dev, int mask) new_ctrl = 0;
> >
> > if ((mask & ETH_VLAN_FILTER_OFFLOAD) ||
> > - (mask & ETH_VLAN_FILTER_OFFLOAD))
> > - RTE_LOG(INFO, PMD, "Not support for
> > ETH_VLAN_FILTER_OFFLOAD or"
> > + (mask & ETH_VLAN_FILTER_EXTEND))
>
> I can't find "ETH_VLAN_FILTER_EXTEND",
> do you mean "ETH_VLAN_EXTEND_OFFLOAD" ?
Erf... I'm sorry, my mistake, I copy/pasted the log below without
verifying. I saw it while watching the code.
Yes I mean ETH_VLAN_EXTEND_OFFLOAD. By the way, it could even be
replaced ETH_VLAN_*_MASK, but it's the same value. For reference, here
are the definitions from rte_ethdev.h:
/* Definitions used for VLAN Offload functionality */
#define ETH_VLAN_STRIP_OFFLOAD 0x0001 /**< VLAN Strip On/Off */
#define ETH_VLAN_FILTER_OFFLOAD 0x0002 /**< VLAN Filter On/Off */
#define ETH_VLAN_EXTEND_OFFLOAD 0x0004 /**< VLAN Extend On/Off */
/* Definitions used for mask VLAN setting */
#define ETH_VLAN_STRIP_MASK 0x0001 /**< VLAN Strip setting mask */
#define ETH_VLAN_FILTER_MASK 0x0002 /**< VLAN Filter setting mask*/
#define ETH_VLAN_EXTEND_MASK 0x0004 /**< VLAN Extend setting mask*/
I'll submit another patch with ETH_VLAN_EXTEND_OFFLOAD.
Thanks Ferruh.
Olivier
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check
2017-01-13 12:48 ` Olivier Matz
@ 2017-01-13 13:17 ` Ferruh Yigit
2017-01-13 14:48 ` Olivier Matz
0 siblings, 1 reply; 9+ messages in thread
From: Ferruh Yigit @ 2017-01-13 13:17 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev, alejandro.lucero
On 1/13/2017 12:48 PM, Olivier Matz wrote:
> On Fri, 13 Jan 2017 12:03:01 +0000, Ferruh Yigit
> <ferruh.yigit@intel.com> wrote:
>> On 1/12/2017 1:04 PM, Olivier Matz wrote:
>>> Fix typo when checking that no Vlan offload flags are passed at port
>>> initialization.
>>>
>>> By the way, also fix a typo in the log.
>>>
>>> Fixes: d4a27a3b092a ("nfp: add basic features")
>>>
>>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>>> ---
<...>
>
>
> I'll submit another patch with ETH_VLAN_EXTEND_OFFLOAD.
If this will be the only change, I can update it if you want:
- (mask & ETH_VLAN_FILTER_OFFLOAD))
- RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD or"
- " ETH_VLAN_FILTER_EXTEND");
+ (mask & ETH_VLAN_EXTEND_OFFLOAD))
+ RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or"
+ " ETH_VLAN_EXTEND_OFFLOAD");
> Thanks Ferruh.
>
> Olivier
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check
2017-01-13 13:17 ` Ferruh Yigit
@ 2017-01-13 14:48 ` Olivier Matz
2017-01-13 14:57 ` Alejandro Lucero
0 siblings, 1 reply; 9+ messages in thread
From: Olivier Matz @ 2017-01-13 14:48 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, alejandro.lucero
On Fri, 13 Jan 2017 13:17:17 +0000, Ferruh Yigit
<ferruh.yigit@intel.com> wrote:
> On 1/13/2017 12:48 PM, Olivier Matz wrote:
> > On Fri, 13 Jan 2017 12:03:01 +0000, Ferruh Yigit
> > <ferruh.yigit@intel.com> wrote:
> >> On 1/12/2017 1:04 PM, Olivier Matz wrote:
> >>> Fix typo when checking that no Vlan offload flags are passed at
> >>> port initialization.
> >>>
> >>> By the way, also fix a typo in the log.
> >>>
> >>> Fixes: d4a27a3b092a ("nfp: add basic features")
> >>>
> >>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> >>> ---
>
> <...>
>
> >
> >
> > I'll submit another patch with ETH_VLAN_EXTEND_OFFLOAD.
>
> If this will be the only change, I can update it if you want:
>
> - (mask & ETH_VLAN_FILTER_OFFLOAD))
> - RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD
> or"
> - " ETH_VLAN_FILTER_EXTEND");
> + (mask & ETH_VLAN_EXTEND_OFFLOAD))
> + RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or"
> + " ETH_VLAN_EXTEND_OFFLOAD");
>
Looks good to me, thank you.
Olivier
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check
2017-01-13 14:48 ` Olivier Matz
@ 2017-01-13 14:57 ` Alejandro Lucero
2017-01-13 15:16 ` [dpdk-dev] [PATCH] net/nfp: fix VLAN " Ferruh Yigit
0 siblings, 1 reply; 9+ messages in thread
From: Alejandro Lucero @ 2017-01-13 14:57 UTC (permalink / raw)
To: Olivier Matz; +Cc: Ferruh Yigit, dev
I was assuming in my acked answer, that the patch had followed usual path
and automatic compilation did not fail.
But I forgot about the NFP PMD not being enabled by default :-)
Hopefully, this will change if this just sent patch is accepted:
http://www.dpdk.org/ml/archives/dev/2017-January/054890.html
By other hand, I have compiled the NFP PMD with this patch and it works.
So acked again.
Thanks
On Fri, Jan 13, 2017 at 2:48 PM, Olivier Matz <olivier.matz@6wind.com>
wrote:
> On Fri, 13 Jan 2017 13:17:17 +0000, Ferruh Yigit
> <ferruh.yigit@intel.com> wrote:
> > On 1/13/2017 12:48 PM, Olivier Matz wrote:
> > > On Fri, 13 Jan 2017 12:03:01 +0000, Ferruh Yigit
> > > <ferruh.yigit@intel.com> wrote:
> > >> On 1/12/2017 1:04 PM, Olivier Matz wrote:
> > >>> Fix typo when checking that no Vlan offload flags are passed at
> > >>> port initialization.
> > >>>
> > >>> By the way, also fix a typo in the log.
> > >>>
> > >>> Fixes: d4a27a3b092a ("nfp: add basic features")
> > >>>
> > >>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > >>> ---
> >
> > <...>
> >
> > >
> > >
> > > I'll submit another patch with ETH_VLAN_EXTEND_OFFLOAD.
> >
> > If this will be the only change, I can update it if you want:
> >
> > - (mask & ETH_VLAN_FILTER_OFFLOAD))
> > - RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD
> > or"
> > - " ETH_VLAN_FILTER_EXTEND");
> > + (mask & ETH_VLAN_EXTEND_OFFLOAD))
> > + RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or"
> > + " ETH_VLAN_EXTEND_OFFLOAD");
> >
>
> Looks good to me, thank you.
>
> Olivier
>
^ permalink raw reply [flat|nested] 9+ messages in thread* [dpdk-dev] [PATCH] net/nfp: fix VLAN offload flags check
2017-01-13 14:57 ` Alejandro Lucero
@ 2017-01-13 15:16 ` Ferruh Yigit
2017-01-13 15:18 ` Ferruh Yigit
0 siblings, 1 reply; 9+ messages in thread
From: Ferruh Yigit @ 2017-01-13 15:16 UTC (permalink / raw)
To: dev; +Cc: stable, Alejandro Lucero, Ferruh Yigit, Olivier Matz
From: Olivier Matz <olivier.matz@6wind.com>
Fix typo when checking that no VLAN offload flags are passed at port
initialization.
By the way, also fix a typo in the log.
Fixes: d4a27a3b092a ("nfp: add basic features")
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 31e72e2..ab2d331 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2174,9 +2174,9 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev, int mask)
new_ctrl = 0;
if ((mask & ETH_VLAN_FILTER_OFFLOAD) ||
- (mask & ETH_VLAN_FILTER_OFFLOAD))
- RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD or"
- " ETH_VLAN_FILTER_EXTEND");
+ (mask & ETH_VLAN_EXTEND_OFFLOAD))
+ RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or"
+ " ETH_VLAN_EXTEND_OFFLOAD");
/* Enable vlan strip if it is not configured yet */
if ((mask & ETH_VLAN_STRIP_OFFLOAD) &&
--
2.9.3
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] net/nfp: fix VLAN offload flags check
2017-01-13 15:16 ` [dpdk-dev] [PATCH] net/nfp: fix VLAN " Ferruh Yigit
@ 2017-01-13 15:18 ` Ferruh Yigit
0 siblings, 0 replies; 9+ messages in thread
From: Ferruh Yigit @ 2017-01-13 15:18 UTC (permalink / raw)
To: dev; +Cc: stable, Alejandro Lucero, Olivier Matz
On 1/13/2017 3:16 PM, Ferruh Yigit wrote:
> From: Olivier Matz <olivier.matz@6wind.com>
>
> Fix typo when checking that no VLAN offload flags are passed at port
> initialization.
>
> By the way, also fix a typo in the log.
>
> Fixes: d4a27a3b092a ("nfp: add basic features")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/master, thanks.
(I forget about stable tree, that is why need to re-send latest patch)
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-01-13 15:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-12 13:04 [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check Olivier Matz
2017-01-13 11:36 ` Alejandro Lucero
2017-01-13 12:03 ` Ferruh Yigit
2017-01-13 12:48 ` Olivier Matz
2017-01-13 13:17 ` Ferruh Yigit
2017-01-13 14:48 ` Olivier Matz
2017-01-13 14:57 ` Alejandro Lucero
2017-01-13 15:16 ` [dpdk-dev] [PATCH] net/nfp: fix VLAN " Ferruh Yigit
2017-01-13 15:18 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).