From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id D811D14EC
 for <dev@dpdk.org>; Fri, 13 Jan 2017 16:36:56 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga103.fm.intel.com with ESMTP; 13 Jan 2017 07:36:55 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,222,1477983600"; d="scan'208";a="1082603490"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61])
 by orsmga001.jf.intel.com with SMTP; 13 Jan 2017 07:36:53 -0800
Received: by  (sSMTP sendmail emulation); Fri, 13 Jan 2017 15:36:53 +0000
Date: Fri, 13 Jan 2017 15:36:53 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org
Message-ID: <20170113153653.GD201464@bricha3-MOBL3.ger.corp.intel.com>
References: <1482381428-148094-2-git-send-email-david.hunt@intel.com>
 <1483948248-91364-1-git-send-email-david.hunt@intel.com>
 <1483948248-91364-6-git-send-email-david.hunt@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1483948248-91364-6-git-send-email-david.hunt@intel.com>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.7.1 (2016-10-04)
Subject: Re: [dpdk-dev] [PATCH v4 5/6] example: distributor app showing
	burst api
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jan 2017 15:36:57 -0000

On Mon, Jan 09, 2017 at 07:50:47AM +0000, David Hunt wrote:
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
>  examples/distributor/main.c | 508 ++++++++++++++++++++++++++++++++++----------
>  1 file changed, 390 insertions(+), 118 deletions(-)
> 
check-git-log complains a bit about the title of the patch, and it would
be good to have a description of the app changes as a commit message
body.

As well as this checkpatch throws up the fact that there is a line
commented out with a C99 style comment. This line should be deleted if
it's commented out.

ERROR:C99_COMMENTS: do not use C99 // comments
#305: FILE: examples/distributor/main.c:331:
+               //struct rte_ring *out_ring = p->dist_tx_ring;

total: 1 errors, 0 warnings, 743 lines checked

/Bruce