Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check

[Olivier Matz <olivier.matz@6wind.com>]

On Fri, 13 Jan 2017 13:17:17 +0000, Ferruh Yigit
<ferruh.yigit@intel.com> wrote:
> On 1/13/2017 12:48 PM, Olivier Matz wrote:
> > On Fri, 13 Jan 2017 12:03:01 +0000, Ferruh Yigit
> > <ferruh.yigit@intel.com> wrote:  
> >> On 1/12/2017 1:04 PM, Olivier Matz wrote:  
> >>> Fix typo when checking that no Vlan offload flags are passed at
> >>> port initialization.
> >>>
> >>> By the way, also fix a typo in the log.
> >>>
> >>> Fixes: d4a27a3b092a ("nfp: add basic features")
> >>>
> >>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> >>> ---  
> 
> <...>
> 
> > 
> > 
> > I'll submit another patch with ETH_VLAN_EXTEND_OFFLOAD.  
> 
> If this will be the only change, I can update it if you want:
> 
> -   (mask & ETH_VLAN_FILTER_OFFLOAD))
> -       RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD
> or"
> -                       " ETH_VLAN_FILTER_EXTEND");
> +   (mask & ETH_VLAN_EXTEND_OFFLOAD))
> +       RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or"
> +                       " ETH_VLAN_EXTEND_OFFLOAD");
> 

Looks good to me, thank you.

Olivier