From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 0030814EC for ; Fri, 13 Jan 2017 15:48:05 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id c206so74190253wme.0 for ; Fri, 13 Jan 2017 06:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I6eXdgRFqKLZT8u9boTyNI6sqOsL7vVT5Zw995CjB68=; b=p9sjZn4OJy85OG24z5lTd4MU5aaPSDnxAM8ZKBUNhTQ3S5iPLIL+Hr1iKTAw3zc+ps Mk1MPTL2w+tEzCHaBRKhSLG3PoZ8fwgALUBk1ZmBq24Z/S5mEKJwvO/VPE1wNXXk/IIn HWTkVHYYJbvilk4HTijx3eP6txk0to1UW1Rl5MYdz7wfv6gmmY0hsVUXRBDM9QM3Ptq5 6RYl6JSwLN/TdTx0e2PgbVgndJhIerPC1CiQ4orh9NOoVHnFFGSCR0LAzC/oQr2WiEJp SiPZFu5ijr7fPiLOR2nYGtyQ9x+8IG3KvZXFMPVSvua4ecbp0Sh9mXXmEr1Rf6BPyV+d Xrgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I6eXdgRFqKLZT8u9boTyNI6sqOsL7vVT5Zw995CjB68=; b=CpRuWRWOmeI5mSAqSU+YBYFelOLCzp+XX8JdHHvHbS0zMGfDOd6HqLceBNTBQat0OT aYdZl4l1NFJ8VrRKrLN8DgDYXT1blnYvHNBBXeWn61UGfTNSHNmNYoB48glQpLJTwxDh cLIRv97RhqxxcY9ijPAnl7A/2CjvHpw8mK5uWejyAdrRQlAjy8kuOiifDCxc0BcD7t0e vYj2MHvz1pEXLj2erD+3LYX2muCZbqm/GTRTPb3bT2Bk+DNleBAPi7TPqspChu3PEeGV LyWCJNnA5XmUI213LDhQHw2dznTQauO+1Vybt30mq8Vq8bWxodU3LWwJNobl5BOd8sLL WvlQ== X-Gm-Message-State: AIkVDXJMjovPKdkFLveN4qpumqlLRLgahSctK38WL7DmBqgod29E2TUYqPNtQdGRVJqOv1Bo X-Received: by 10.223.128.17 with SMTP id 17mr13670218wrk.13.1484318885595; Fri, 13 Jan 2017 06:48:05 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id t194sm5056711wmd.1.2017.01.13.06.48.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Jan 2017 06:48:05 -0800 (PST) Date: Fri, 13 Jan 2017 15:48:02 +0100 From: Olivier Matz To: Ferruh Yigit Cc: dev@dpdk.org, alejandro.lucero@netronome.com Message-ID: <20170113154802.6166e529@platinum> In-Reply-To: <0fe55cec-99fe-8f61-9aa9-02cb51e9f990@intel.com> References: <1484226296-540-1-git-send-email-olivier.matz@6wind.com> <2c9b018f-bad8-449a-acf7-e2da82bdc464@intel.com> <20170113134824.6542fc5e@platinum> <0fe55cec-99fe-8f61-9aa9-02cb51e9f990@intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 14:48:06 -0000 On Fri, 13 Jan 2017 13:17:17 +0000, Ferruh Yigit wrote: > On 1/13/2017 12:48 PM, Olivier Matz wrote: > > On Fri, 13 Jan 2017 12:03:01 +0000, Ferruh Yigit > > wrote: > >> On 1/12/2017 1:04 PM, Olivier Matz wrote: > >>> Fix typo when checking that no Vlan offload flags are passed at > >>> port initialization. > >>> > >>> By the way, also fix a typo in the log. > >>> > >>> Fixes: d4a27a3b092a ("nfp: add basic features") > >>> > >>> Signed-off-by: Olivier Matz > >>> --- > > <...> > > > > > > > I'll submit another patch with ETH_VLAN_EXTEND_OFFLOAD. > > If this will be the only change, I can update it if you want: > > - (mask & ETH_VLAN_FILTER_OFFLOAD)) > - RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD > or" > - " ETH_VLAN_FILTER_EXTEND"); > + (mask & ETH_VLAN_EXTEND_OFFLOAD)) > + RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or" > + " ETH_VLAN_EXTEND_OFFLOAD"); > Looks good to me, thank you. Olivier