From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 9E8EEFAE3; Mon, 16 Jan 2017 07:10:32 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 15 Jan 2017 22:10:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,237,1477983600"; d="scan'208";a="213784099" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga004.fm.intel.com with ESMTP; 15 Jan 2017 22:10:30 -0800 Date: Mon, 16 Jan 2017 14:12:43 +0800 From: Yuanhan Liu To: Olivier Matz Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20170116061243.GK9770@yliu-dev.sh.intel.com> References: <1484154325-32204-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484154325-32204-1-git-send-email-olivier.matz@6wind.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix advertised Rx offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2017 06:10:33 -0000 On Wed, Jan 11, 2017 at 06:05:25PM +0100, Olivier Matz wrote: > When the virtio PMD is used on top of a vhost that does not support > offloads, Rx offload capabilities are still advertised by > virtio_dev_info_get(). But if an application tries to start the PMD with > Rx offloads enabled (rxmode.hw_ip_checksum = 1), the initialization of > the device will fail with -ENOTSUP and the following log: > > rx ip checksum not available on this host > > This patch fixes the Rx offload capabilities returned by > virtio_dev_info_get() to be consistent with features advertised by the > host. > > Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload") > Fixes: 86d59b21468a ("net/virtio: support LRO") Hi Olivier, This patch doesn't apply cleanly on top of next-virtio repo, would you midn to send v2, so that I can apply? Thanks. --yliu