From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 28F2A108F for ; Mon, 16 Jan 2017 11:52:43 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP; 16 Jan 2017 02:52:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,238,1477983600"; d="scan'208";a="54393191" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga006.fm.intel.com with ESMTP; 16 Jan 2017 02:52:42 -0800 Date: Mon, 16 Jan 2017 18:54:57 +0800 From: Yuanhan Liu To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org Message-ID: <20170116105457.GB10293@yliu-dev.sh.intel.com> References: <1479768194-6255-1-git-send-email-thomas.monjalon@6wind.com> <1b249c77-5685-8492-6f6b-3478a2731267@intel.com> <20170116095152.GQ9770@yliu-dev.sh.intel.com> <8e22bad7-53c6-6809-0604-63d72c01c7ae@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e22bad7-53c6-6809-0604-63d72c01c7ae@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] scripts: check cc stable mailing list in commit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2017 10:52:44 -0000 On Mon, Jan 16, 2017 at 10:38:02AM +0000, Ferruh Yigit wrote: > On 1/16/2017 9:51 AM, Yuanhan Liu wrote: > > On Wed, Nov 30, 2016 at 02:54:14PM +0000, Ferruh Yigit wrote: > >> On 11/21/2016 10:43 PM, Thomas Monjalon wrote: > >>> Add a check for commits fixing a released bug. > >>> Such commits are found thanks to scripts/git-log-fixes.sh. > >>> They must be sent CC: stable@dpdk.org. > >>> In order to avoid forgetting CC, this mail header can be written > >>> in the git commit message. > >>> > >>> Signed-off-by: Thomas Monjalon > >> > >> I think this is useful, thanks for the patch. > > > > Yes, it is. Thanks! (Sorry for late reply; hope it's not too late). > > > >>> +[ -z "$bad" ] || printf "Should CC: stable@dpdk.org\n$bad\n" > >> > >> This is good for developer, but since "CC: xx" tags removed when patch > >> applied, > > > > Again, I'd suggest to __not__ remove such tag. Firstly, why bother? And > > I will talk why this tag should be kept, as a stable tree maintainer. > > > > At the beginning, when people are not used to add "cc: stable" tag, I used > > to pick bug fix commits from master by something like: list all bug fixing > > patches and pick those that appliable to previous release. > > > > Later, kudos to Thomas, who wrote an handy script (git-log-fixes.sh) to > > do both, it indeeded make my life much easier. But it's still not enough. > > > > It lists a lot of patches (206 fix patches, while 728 in total: the > > ratio is near 30%): > > > > $ devtools/git-log-fixes.sh v16.07..v16.11 | wc -l > > 206 > > > > $ git rev-list v16.07..v16.11 | wc -l > > 728 > > > > Thus I dropped few of them, manually, resulting to 130 (still looks like > > a big number to me): > > > > $ git rev-list v16.07..v16.07.2 | wc -l > > 130 > > > > The policy I would expect is, leave this tag as it is, I then will apply > > all of them to a stable branch: I will no longer do the picking job. Instead, > > I may just need handle those can't apply cleanly and ask the author to > > do backport. > > Won't all patches that has CC:stable... also would have Fixes: line? Yes, but it's not the reverse. And we now pick stable patches by the fixline. --yliu