Re: [dpdk-dev] [PATCH] net/mlx: remove link update lock

[Adrien Mazarguil <adrien.mazarguil@6wind.com>]

On Wed, Jan 11, 2017 at 05:44:01PM +0100, Olivier Matz wrote:
> From: Matthieu Ternisien d'Ouville <matthieu.tdo@6wind.com>
> 
> Retrieving link status information through the link update callback should
> be quick and non-blocking.
> 
> Mellanox PMDs retrieve this information through ioctl() calls on the
> related kernel netdevice. This appears to take a long time to
> complete and may cause significant slowdowns in applications.
> 
> While these system calls cannot be accelerated, removing the lock on the
> private structure allows applications to perform other control operations
> from separate threads in the meantime. This function remains safe without
> locking as it does not write the private structure, it is only used to
> retrieve the name of the netdevice.
> 
> Signed-off-by: Matthieu Ternisien d'Ouville <matthieu.tdo@6wind.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>  drivers/net/mlx4/mlx4.c        | 32 ++++++--------------------------
>  drivers/net/mlx5/mlx5.c        |  2 +-
>  drivers/net/mlx5/mlx5.h        |  1 -
>  drivers/net/mlx5/mlx5_ethdev.c | 30 ++++++------------------------
>  4 files changed, 13 insertions(+), 52 deletions(-)

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND