From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by dpdk.org (Postfix) with ESMTP id 84B921094 for ; Mon, 16 Jan 2017 15:03:32 +0100 (CET) Received: by mail-lf0-f52.google.com with SMTP id k86so83850496lfi.0 for ; Mon, 16 Jan 2017 06:03:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jH3ptAbfKWZDCgQ9DRqMEskkLfdkcrm4LXMy15GGcGQ=; b=2O8+qUekSrT6zfBDdaEWhhBryC5zQU5fGETKvJWKCYTWJCDd9m72WX3FSCmoy6J9de 55z5g0KEQnolgc25VSiGsVI4fZ0jvCCl1q/aRudWiPz5fGCvuEKbqG0ezQ7+Mo9byQj0 4qEMuQ2xZBkf+B0xmt/bS176sZYN5PPcbSg8z9cfVR8gjb544N9/7T9PTaZ/XwtY8NJy S6Y9RfnoowXpBhOqlJ1EDCXa1FtrpAlgWxyiyb6Kcbji+XhHmLL84CrGffHrW4aiov68 hiHSo6gHLd8Yydfz+ENJcxE0JF04KjW4NQevCYe+ngheyWppvMo3QtFda9HsipynRXE1 JdYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jH3ptAbfKWZDCgQ9DRqMEskkLfdkcrm4LXMy15GGcGQ=; b=EPr1ntOuyrzSIFJ/ZkHQIsdqkqQgD6iOKh93Ep7oLjpLVfXq4wD+cvi0NLih4O4pyZ I1iuRVWUKQp+3/EQhCcNW4h/5JqZ/x25g6lbOOkZAYov7HcrQ9US5r5tJc4Z7tciLWTW Eaq4EKdIala6sr05fiqJLknVGsXy1R8zTT+cUa9RPKXgejxzGVaosA8W1RUSb8H4z4UG xe/z6dXgekSiL2XPWWUjBG609PJLjPlKHpXRB/5TPr6MIvaooOGxujNW+6B427dPCUhv ME/oToUyT1iDq0NRUykDpNSENDGEPz7tEQuGTACwZiYbh3AnqqXejcPuthx2Jx2YVCs+ Qf7g== X-Gm-Message-State: AIkVDXLf2e0a7tFE+Xvxn+VPStMSxanjm0tR4x7WhM7+v8YrXGUjebgUq/z8lY2OT9Feq02s X-Received: by 10.46.83.19 with SMTP id h19mr7593323ljb.72.1484575412044; Mon, 16 Jan 2017 06:03:32 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 25sm3144701ljt.11.2017.01.16.06.03.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Jan 2017 06:03:30 -0800 (PST) Date: Mon, 16 Jan 2017 15:03:23 +0100 From: Adrien Mazarguil To: Olivier Matz Cc: dev@dpdk.org, Matthieu Ternisien d'Ouville Message-ID: <20170116140323.GD3779@6wind.com> References: <1484153041-18034-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484153041-18034-1-git-send-email-olivier.matz@6wind.com> Subject: Re: [dpdk-dev] [PATCH] net/mlx: remove link update lock X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2017 14:03:32 -0000 On Wed, Jan 11, 2017 at 05:44:01PM +0100, Olivier Matz wrote: > From: Matthieu Ternisien d'Ouville > > Retrieving link status information through the link update callback should > be quick and non-blocking. > > Mellanox PMDs retrieve this information through ioctl() calls on the > related kernel netdevice. This appears to take a long time to > complete and may cause significant slowdowns in applications. > > While these system calls cannot be accelerated, removing the lock on the > private structure allows applications to perform other control operations > from separate threads in the meantime. This function remains safe without > locking as it does not write the private structure, it is only used to > retrieve the name of the netdevice. > > Signed-off-by: Matthieu Ternisien d'Ouville > Signed-off-by: Olivier Matz > --- > drivers/net/mlx4/mlx4.c | 32 ++++++-------------------------- > drivers/net/mlx5/mlx5.c | 2 +- > drivers/net/mlx5/mlx5.h | 1 - > drivers/net/mlx5/mlx5_ethdev.c | 30 ++++++------------------------ > 4 files changed, 13 insertions(+), 52 deletions(-) Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND