From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 2E504201
 for <dev@dpdk.org>; Tue, 17 Jan 2017 06:14:00 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 16 Jan 2017 21:14:00 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,242,1477983600"; d="scan'208";a="1083833903"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by orsmga001.jf.intel.com with ESMTP; 16 Jan 2017 21:13:59 -0800
Date: Tue, 17 Jan 2017 13:16:11 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, stephen@networkplumber.org, lei.a.yao@intel.com
Message-ID: <20170117051611.GJ10293@yliu-dev.sh.intel.com>
References: <1484578022-92705-1-git-send-email-jianfeng.tan@intel.com>
 <1484578022-92705-10-git-send-email-jianfeng.tan@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1484578022-92705-10-git-send-email-jianfeng.tan@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v3 09/10] examples/l3fwd-power: add
	parse-ptype option
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jan 2017 05:14:01 -0000

On Mon, Jan 16, 2017 at 02:47:01PM +0000, Jianfeng Tan wrote:
> +#if (APP_LOOKUP_METHOD == APP_LOOKUP_LPM)
> +	if (ptype_l3_ipv4)
> +#else
> +	// APP_LOOKUP_EXACT_MATCH

No c++ comment.

Besides, this patchset misses the release note. Also bear in mind I
think this feature deserves a howto doc.

	--yliu