From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f41.google.com (mail-lf0-f41.google.com [209.85.215.41]) by dpdk.org (Postfix) with ESMTP id 37049DE5 for ; Tue, 17 Jan 2017 11:33:49 +0100 (CET) Received: by mail-lf0-f41.google.com with SMTP id n124so34664475lfd.2 for ; Tue, 17 Jan 2017 02:33:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CjI8aEv6XpjlQ5yz6OMHcd79vw8b45gop0qFgCUe4GA=; b=EH3LhN4yg5h8T55vwM0FfO4qGjnCy3p5E3yPzqrbV+BIurpn0xRIhd1qaxEMrtXtOE 6w6Ej53fR0aTIT57DwEOyzTTdOU7yVvHQ8+MJwBdMc/sdcmKIu/PyrqgtMxA7oxtMtQd G9qnlas/Ag7PeAzQbPYOI2cI6R4UqMgjMZ2pWXb7Vu9wKOEUvhwhsbjjf8sdTh/USNoT C1Yd0++of8GpgAq7Fa/2eryJ8kCC0PCzNBG9NRvralpGH3BxAmuw/EPPQjTthMwx+g8F EMzE6Dn5TKc2zUPKOTPUaf2X4HvdhBCdgCfofyKyuux0o1BfYpl2QbUqN7SgTNU3Cvvj 3mHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CjI8aEv6XpjlQ5yz6OMHcd79vw8b45gop0qFgCUe4GA=; b=N2iHt6uMGAIo70lhy9YeByKHtHZ66NkGeXLSdeEc+dHbDtjMryAJd6wxgbtR5NA62E 4QTnRv4j9TuqM4KnttajQyOyIzbDPBtJmC7/4PFxK4UESDdsrbIKbgcMYYQWT/m96sqS 7QmAW2WunOPNp6lCV6fgunnNknrmK1WSa8avjtVBA9PP51R3HaUqYN3Ug+8T+FTupWFP /1PM9LZXqAATL/UHAr4txddXlThMsjuZpKX7kbS6Iu7PrPr0cUraDJFwqMxb+OVjvo7A xQaHjptdMW/O49pmruRq6jcR6g4EVVeLeVECRVMnbcXRP7HuEItJ2j0qAWiDS6ybKgIr R5uA== X-Gm-Message-State: AIkVDXL1lU1K9iU18/dOSVRONRp9CIJ84Atb+/EKkoG9+o502MIr+GJVDv+Jlz3Kr5b8FE9R X-Received: by 10.46.33.158 with SMTP id h30mr15734290lji.53.1484649228717; Tue, 17 Jan 2017 02:33:48 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id z26sm801426lja.36.2017.01.17.02.33.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Jan 2017 02:33:48 -0800 (PST) Date: Tue, 17 Jan 2017 11:33:45 +0100 From: Olivier Matz To: Yuanhan Liu Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20170117113345.75fc46f3@platinum> In-Reply-To: <20170116061243.GK9770@yliu-dev.sh.intel.com> References: <1484154325-32204-1-git-send-email-olivier.matz@6wind.com> <20170116061243.GK9770@yliu-dev.sh.intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix advertised Rx offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 10:33:49 -0000 On Mon, 16 Jan 2017 14:12:43 +0800, Yuanhan Liu wrote: > On Wed, Jan 11, 2017 at 06:05:25PM +0100, Olivier Matz wrote: > > When the virtio PMD is used on top of a vhost that does not support > > offloads, Rx offload capabilities are still advertised by > > virtio_dev_info_get(). But if an application tries to start the PMD > > with Rx offloads enabled (rxmode.hw_ip_checksum = 1), the > > initialization of the device will fail with -ENOTSUP and the > > following log: > > > > rx ip checksum not available on this host > > > > This patch fixes the Rx offload capabilities returned by > > virtio_dev_info_get() to be consistent with features advertised by > > the host. > > > > Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload") > > Fixes: 86d59b21468a ("net/virtio: support LRO") > > Hi Olivier, > > This patch doesn't apply cleanly on top of next-virtio repo, would you > midn to send v2, so that I can apply? Sure, will do.