From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 62A2E3277 for ; Wed, 18 Jan 2017 09:52:22 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 18 Jan 2017 00:52:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,248,1477983600"; d="scan'208";a="214699581" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga004.fm.intel.com with ESMTP; 18 Jan 2017 00:52:20 -0800 Date: Wed, 18 Jan 2017 16:54:34 +0800 From: Yuanhan Liu To: Thomas Monjalon Cc: Ferruh Yigit , dev@dpdk.org, pablo.de.lara.guarch@intel.com, bruce.richardson@intel.com Message-ID: <20170118085434.GP10293@yliu-dev.sh.intel.com> References: <1484664872-26859-1-git-send-email-thomas.monjalon@6wind.com> <1860075.ojoIIAvjcn@xps13> <20170118044150.GN10293@yliu-dev.sh.intel.com> <21531262.6kCXYB22gk@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21531262.6kCXYB22gk@xps13> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] devtools: check stable tag in fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 08:52:22 -0000 On Wed, Jan 18, 2017 at 09:32:22AM +0100, Thomas Monjalon wrote: > > Yes, it's just part of the committer job, say, adding Tested-by, > > Reviewed-by, that kind of stuff. > > So it should be stressed in the contribution guide that it is the > responsibility of the author and the maintainer to put this Cc: tag. Yes, I will do that. > > > > Last thing, if this tag will remain in the commit log, is this only for > > > > stable tree, or any "Cc: " can stay in the history? > > > > > > I do not see the benefit of keeping other Cc in the history. > > > > Again, I really don't know why you bother to remove it, manually, commit > > by commit. What's the gain here? It just adds more burden to a committer. > > Honestly, I never do that. > > I had the personal feeling that if the Cc: person is not in SoB, Ack or > Review tags, it means he's not interested in this patch. > After thinking more, I was probably wrong. It's just not commonly used in DPDK, just like people here seldom use Reviewed-by while everyone just throw an Acked-by. > > It actually has benefits. Keeping the cc tags allows us to cc them when > > we find a bug in that patch and make a fix patch later: they are likely > > to want to know any follow updates on that original patch. > > > > It also helps when I send out a stable patch review: I send a copy to > > all guys on the Cc list, on the Ack/Review, SoB list. I think they might > > also want to know that patch is a candidate for a specific branch. He may > > even give some comments, something like "if you pick this one, you might > > want to pick another one", or "why bother to port it to a stable release", > > that kind of thing. > > OK Yuanhan, thanks for the explanations. Thanks for "listening"! :) > I will send a v2 to relax the constraint of blank line below Fixes: tag, > and change the warning when Cc: tag is missing. Or remove the warning? > What do you think of: "Reminder: is it a candidate for stable@dpdk.org backport?" Yes, I think such Reminder is enough. It might put him thinking more. Thanks. --yliu