From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: remove default toolchain prefix for ThunderX
Date: Mon, 23 Jan 2017 15:09:51 +0530 [thread overview]
Message-ID: <20170123093950.GA14840@localhost.localdomain> (raw)
In-Reply-To: <1485162957-2497-1-git-send-email-thomas.monjalon@6wind.com>
On Mon, Jan 23, 2017 at 10:15:57AM +0100, Thomas Monjalon wrote:
> The environment variable CROSS must be set when using a cross-toolchain.
> However it is counter intuitive to set a default value, considering
> the toolchain required to build this architecture is well known.
> It is especially weird when using a native toolchain and requiring to
> unset this variable on the command line.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Reviewed-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> mk/machine/thunderx/rte.vars.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mk/machine/thunderx/rte.vars.mk b/mk/machine/thunderx/rte.vars.mk
> index 81da1b4..ad5a379 100644
> --- a/mk/machine/thunderx/rte.vars.mk
> +++ b/mk/machine/thunderx/rte.vars.mk
> @@ -47,7 +47,7 @@
> #
>
> # ARCH =
> -CROSS ?= aarch64-thunderx-linux-gnu-
> +# CROSS =
> # MACHINE_CFLAGS =
> # MACHINE_LDFLAGS =
> # MACHINE_ASFLAGS =
> --
> 2.7.0
>
next prev parent reply other threads:[~2017-01-23 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 9:15 Thomas Monjalon
2017-01-23 9:39 ` Jerin Jacob [this message]
2017-01-29 14:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123093950.GA14840@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).