DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] mk: remove default toolchain prefix for ThunderX
@ 2017-01-23  9:15 Thomas Monjalon
  2017-01-23  9:39 ` Jerin Jacob
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2017-01-23  9:15 UTC (permalink / raw)
  To: Jerin Jacob; +Cc: dev

The environment variable CROSS must be set when using a cross-toolchain.
However it is counter intuitive to set a default value, considering
the toolchain required to build this architecture is well known.
It is especially weird when using a native toolchain and requiring to
unset this variable on the command line.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 mk/machine/thunderx/rte.vars.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mk/machine/thunderx/rte.vars.mk b/mk/machine/thunderx/rte.vars.mk
index 81da1b4..ad5a379 100644
--- a/mk/machine/thunderx/rte.vars.mk
+++ b/mk/machine/thunderx/rte.vars.mk
@@ -47,7 +47,7 @@
 #
 
 # ARCH =
-CROSS ?= aarch64-thunderx-linux-gnu-
+# CROSS =
 # MACHINE_CFLAGS =
 # MACHINE_LDFLAGS =
 # MACHINE_ASFLAGS =
-- 
2.7.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] mk: remove default toolchain prefix for ThunderX
  2017-01-23  9:15 [dpdk-dev] [PATCH] mk: remove default toolchain prefix for ThunderX Thomas Monjalon
@ 2017-01-23  9:39 ` Jerin Jacob
  2017-01-29 14:51   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Jerin Jacob @ 2017-01-23  9:39 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

On Mon, Jan 23, 2017 at 10:15:57AM +0100, Thomas Monjalon wrote:
> The environment variable CROSS must be set when using a cross-toolchain.
> However it is counter intuitive to set a default value, considering
> the toolchain required to build this architecture is well known.
> It is especially weird when using a native toolchain and requiring to
> unset this variable on the command line.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Reviewed-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  mk/machine/thunderx/rte.vars.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mk/machine/thunderx/rte.vars.mk b/mk/machine/thunderx/rte.vars.mk
> index 81da1b4..ad5a379 100644
> --- a/mk/machine/thunderx/rte.vars.mk
> +++ b/mk/machine/thunderx/rte.vars.mk
> @@ -47,7 +47,7 @@
>  #
>  
>  # ARCH =
> -CROSS ?= aarch64-thunderx-linux-gnu-
> +# CROSS =
>  # MACHINE_CFLAGS =
>  # MACHINE_LDFLAGS =
>  # MACHINE_ASFLAGS =
> -- 
> 2.7.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] mk: remove default toolchain prefix for ThunderX
  2017-01-23  9:39 ` Jerin Jacob
@ 2017-01-29 14:51   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-01-29 14:51 UTC (permalink / raw)
  To: Jerin Jacob; +Cc: dev

2017-01-23 15:09, Jerin Jacob:
> On Mon, Jan 23, 2017 at 10:15:57AM +0100, Thomas Monjalon wrote:
> > The environment variable CROSS must be set when using a cross-toolchain.
> > However it is counter intuitive to set a default value, considering
> > the toolchain required to build this architecture is well known.
> > It is especially weird when using a native toolchain and requiring to
> > unset this variable on the command line.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Reviewed-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-29 14:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-23  9:15 [dpdk-dev] [PATCH] mk: remove default toolchain prefix for ThunderX Thomas Monjalon
2017-01-23  9:39 ` Jerin Jacob
2017-01-29 14:51   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).