From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0904C2A5B for ; Mon, 23 Jan 2017 12:22:22 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP; 23 Jan 2017 03:22:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,274,1477983600"; d="scan'208";a="56445432" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga005.fm.intel.com with ESMTP; 23 Jan 2017 03:22:20 -0800 Date: Mon, 23 Jan 2017 19:24:45 +0800 From: Yuanhan Liu To: Ferruh Yigit Cc: dev@dpdk.org, Thomas Monjalon , Remy Horton Message-ID: <20170123112445.GE10293@yliu-dev.sh.intel.com> References: <1484899493-11051-1-git-send-email-yuanhan.liu@linux.intel.com> <6e706e07-455f-de57-4f85-eb4e506528f1@intel.com> <4d897cf9-f1f4-d924-10cd-63e95b12b411@intel.com> <20170122024529.GZ10293@yliu-dev.sh.intel.com> <3451afa6-12fb-dc65-f379-873facc0301c@intel.com> <20170123103417.GB10293@yliu-dev.sh.intel.com> <53a23156-dcb9-b41f-c27c-5bd13d5874f6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53a23156-dcb9-b41f-c27c-5bd13d5874f6@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] ethdev: fix wrong memset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2017 11:22:23 -0000 On Mon, Jan 23, 2017 at 11:05:25AM +0000, Ferruh Yigit wrote: > >>>>>> lib/librte_ether/rte_ethdev.c | 2 +- > >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>>>> > >>>>>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > >>>>>> index 4790faf..61f44e2 100644 > >>>>>> --- a/lib/librte_ether/rte_ethdev.c > >>>>>> +++ b/lib/librte_ether/rte_ethdev.c > >>>>>> @@ -225,7 +225,7 @@ struct rte_eth_dev * > >>>>>> return NULL; > >>>>>> } > >>>>>> > >>>>>> - memset(&rte_eth_devices[port_id], 0, sizeof(*eth_dev->data)); > >>>>>> + memset(&rte_eth_dev_data[port_id], 0, sizeof(struct rte_eth_dev_data)); > >>>>> > >>>>> Not directly related to the this issue, but, after fix, this may have > >>>>> issues with secondary process. > >>>>> > >>>>> There were patches sent to fix this. > >>>> > >>>> I mean this one: > >>>> http://dpdk.org/ml/archives/dev/2017-January/054422.html > >>> > >>> d948f596fee2 ("ethdev: fix port data mismatched in multiple process > >>> model") should have fixed it. > >> > >> Think about case, where secondary process uses a virtual PMD, which does > >> a rte_eth_dev_allocate() call, shouldn't this corrupt primary process > >> device data? > > > > Yes, it may. However, I doubt that's the typical usage. > > But this is a use case, and broken now, I thought it was broken since the beginning? > and fix is known. And there is already a fix? > Should be > fixed I think. Sure. > > > Besides that, > > most of virtual PMDs don't support Multipleprocess: git grep shows pcap > > is the only one that does claim Multipleprocess is supported. > > I guess you searched for NIC feature documentation for this. Yes. > But as far > as I know, all virtual drivers can be used in both primary and secondary > process. Maybe. But it becomes very error-prone to me then when vdev are involved in both primary and secondary process. I don't think current code is (or designed to be) strong enough to support that. I don't know it's allowed to use hotplug or not in the multiple process model. If yes, I think there would be many ways to break it. Honestly, the multiple process doesn't look like a good/clean design to me, especially when some piece of code claim to support it while some other doesn't. So my point was, yes, there is a bug, we should fix it. But it seems that there could be so many bugs if we hugely expand the test coverage of the multiple process feature. --yliu