From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 74A232C38 for ; Mon, 23 Jan 2017 14:19:40 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id r126so132501721wmr.0 for ; Mon, 23 Jan 2017 05:19:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YFO/s1oYZZ1eD00R/vASSgBoRfEzEmnvas5gKFPmUG4=; b=F5Jv4YBausoJACgMqhPgKt7u1OgZOZqgmtYjvg/HPKMMeEkNNcfdWunE9p/XGLdIIQ PWY2axtou1NWRu6cXTqsChTel3L8ebmNRRV3mCZE/ZnnrQOhZ5BI9jUKbhpSx4bte+wd +MgztnOjIl9jJ8gG/Pum815b6f14dpAHvvD+WLdWSgCK8VrJqi8tD3kIo6eL7BODyVSB yaw0A1pql0my6J1llmvjwJM9NvrQmZDksy8Bia2RMeqwVef75wHp1TESUc3z5tV/+/pC RV2Ak/a4/YyMFIMM1YRYHoH6DCE2H2H8hoMWbzDNTBJf78DPSswbaj32nHnnyBRPPmJ2 EiLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YFO/s1oYZZ1eD00R/vASSgBoRfEzEmnvas5gKFPmUG4=; b=O/wi7DxYLsqpQMsY17K6MneJXiNUY0lIZrHNYoYGW0Pvo/tJvnBaJ4AU6x2oi5AQs0 XEdx70Vh7McuXEsfzPpfsfOrvFRWB4mh19W7ZDbuYDKRbMd8Xn3PYh6srt/PO4p8ipkv 38Ug+tLKKfvvgZHDjuFU78eAqvjecqRpr9EFSiyLLCT1ORrW+VkVStF85zLsBvPAt3jw oB+QwOKGulpvfwvhHjGB7PZRs2Cl+PV2QdE4g+pxrH8ICJCqnhMyKefcufExSI0C6heu RcWaslq7dAzi9mgHAWDt1lDTUrGfdnleMKpeL1FHn9VbJMoFSVU9rUF0LgW7yimkFIpd LDpQ== X-Gm-Message-State: AIkVDXINpuqD3wZrkDZDrKfur+6jll05wFXJNvYGyudipN5Ix5REQnmW9NKvjRDJ2K5YOBGH X-Received: by 10.28.150.202 with SMTP id y193mr14437454wmd.106.1485177580181; Mon, 23 Jan 2017 05:19:40 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id r6sm21110831wmd.4.2017.01.23.05.19.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jan 2017 05:19:40 -0800 (PST) Date: Mon, 23 Jan 2017 14:19:37 +0100 From: Olivier Matz To: Sergey Vyazmitinov Cc: konstantin.ananyev@intel.com, stephen@networkplumber.org, yuanhan.liu@linux.intel.com, ferruh.yigit@intel.com, dev@dpdk.org, mirqus@gmail.com Message-ID: <20170123141937.75390eef@platinum> In-Reply-To: <20170123135947.0e5cbe83@platinum> References: <1484801219-1312-1-git-send-email-s.vyazmitinov@brain4net.com> <1484801219-1312-2-git-send-email-s.vyazmitinov@brain4net.com> <20170123135947.0e5cbe83@platinum> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 1/2] kni: add bulk function to free mbufs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2017 13:19:40 -0000 Hi, [resent and updated, previous mail was sent from the wrong address] On Mon, 23 Jan 2017 13:59:47 +0100, Olivier Matz wrote: > > + * @param mbufs > > + * The packets mbufs array to be freed. > > + * @param n > > + * Number of packets. > > + */ > > +static inline void rte_pktmbuf_free_bulk(struct rte_mbuf **mbufs, > > + unsigned int n) > > I suggest we could use mbuf instead of pktmbuf in the function name. > It's a bit shorter, and the function would also apply on ctrlmbuf. Sorry, please ignore this one. It's more consistent to have a rte_pktmbuf_free and rte_pktmbuf_free_bulk having the same prefix. Also a small comment on the title: it should be "mbuf:", not "kni:". In the other patch, the uppercase in "Use" could also be changed to lowercase (seen with ./devtools/check-git-log.sh). Thanks, Olivier