From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 70EE1108D
 for <dev@dpdk.org>; Tue, 24 Jan 2017 09:42:42 +0100 (CET)
Received: by mail-wm0-f54.google.com with SMTP id r144so196557382wme.1
 for <dev@dpdk.org>; Tue, 24 Jan 2017 00:42:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:date:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=vt+xYZ4T2Dg8IkwZO4EFrAiVgwqZswaYTvLao852bAQ=;
 b=fellrIMSnC2NpNm4wY5Ztm5nZcev7QrUyq8fg+d8fFmzW+VoZ/ehMnHXjzzNMCz4MU
 E3CjauEg99XM4A1r9pto4Tpjf6PUHTnH+ioWaNYYhpUj0vSOlCiGOYaj0eUtmXtSiO7Z
 VzzIIxc986NmW94H2Lg/eaVB5eIFeMbX6ZTakoMYCoxo2pzWaBKZOxL8KbfhVZ1SdxBX
 ZO2XkQito9bAWo4XjOikehCfTevejR9J+bJiEMz+MXUYKjGCSbtCUkJSHGRqfmK689b0
 UCEWf9Y4qkl6EM7Q89LaX+zUgCtAXj2GkXTT2WwP6AmU6tGpDLQJqsQpQXF3gLLl7+/o
 00rA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:date:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=vt+xYZ4T2Dg8IkwZO4EFrAiVgwqZswaYTvLao852bAQ=;
 b=U0LUO5k7l3pqs09oNCS1lTLaLN2KZ6DTatMB7U70JizqoYoNYwNMbfBDU3Hga31mkj
 Zbv/P3fHbnJUzqnbe52bHp1zqGnv+Dnecg2ypWAQuX8OMVvsnRsnI1ONx9hn7mJGuu5l
 KZAiWVuax+r/ywebt4/KDjqloN7m7RtsQuHa8snBLTRPl5kDoSOW3thO6DrM0lP3lm9S
 rZBh9jI8Z3qP1tdLcY81fWVGL6UKyMJbsy+CzpRYQv+A2+xv6wy8ah0MjL3iT3RMH7V3
 XepV9TZdwHgJ251bSidwYPflYPdrkKK+ihqCRdXWaBx74SozXTZ7EeyGTWU4z/Zrci8q
 Y3og==
X-Gm-Message-State: AIkVDXKDV3Cd9p2VSDnPXAVFt5WyeKF5E40LaKJWEIwM3rkosSghQPNRpEosP4IalXQCe01S
X-Received: by 10.223.146.196 with SMTP id 62mr19809173wrn.199.1485247362135; 
 Tue, 24 Jan 2017 00:42:42 -0800 (PST)
Received: from glumotte.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.
 [62.23.145.78])
 by smtp.gmail.com with ESMTPSA id t103sm17093536wrc.43.2017.01.24.00.42.41
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Tue, 24 Jan 2017 00:42:42 -0800 (PST)
From: Olivier MATZ <olivier.matz@6wind.com>
X-Google-Original-From: Olivier MATZ <olivier.matz@dev.6wind.com>
Date: Tue, 24 Jan 2017 09:42:35 +0100
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: Olivier Matz <olivier.matz@6wind.com>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon
 <thomas.monjalon@6wind.com>
Message-ID: <20170124094235.7fda08cc@glumotte.dev.6wind.com>
In-Reply-To: <5C15197B-7CD8-490D-B756-B0580CBFFA50@intel.com>
References: <20170122015034.19824-1-ferruh.yigit@intel.com>
 <20170123181813.00567e47@platinum>
 <5C15197B-7CD8-490D-B756-B0580CBFFA50@intel.com>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] mk: parallelize make config
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jan 2017 08:42:42 -0000

Hi Keith,

On Mon, 23 Jan 2017 17:50:27 +0000, "Wiles, Keith"
<keith.wiles@intel.com> wrote:
> > On Jan 23, 2017, at 10:18 AM, Olivier Matz <olivier.matz@6wind.com>
> > wrote:
> > 
> > Hi Ferruh,
> > 
> > On Sun, 22 Jan 2017 01:50:34 +0000, Ferruh Yigit
> > <ferruh.yigit@intel.com> wrote:  
> >> make config dependency resolving was always running serial,
> >> parallelize it for better performance.
> >> 
> >> $ time make T=x86_64-native-linuxapp-gcc config
> >> real    0m12.633s
> >> 
> >> $ time make -j8 T=x86_64-native-linuxapp-gcc config
> >> real    0m1.826s
> >> 
> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>  
> > 
> > I have a patch that fix the same issue (configuration takes to
> > long), but done differently. It is more intrusive, since it rework
> > the way DEPDIRS are used, but it does not require to use -j.  
> 
> I tested the patch and the performance is very quick and seems to
> work very nicely. I have not looked at the other patch yet are they
> both compatible and could be combined or not?

No, I don't think they could be combined.

Ferruh's approach looks less risky, since it's a parallelization
of the config. My approach changes the way dependencies are processed,
and also how they are declared. I think it's faster, but more intrusive.

Regards,
Olivier