From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 4C2A41023 for ; Tue, 24 Jan 2017 12:19:56 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id c206so203712856wme.0 for ; Tue, 24 Jan 2017 03:19:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G3wd1psCrVAWlDMI+JH7KY5C4/ahmXuINV1gmOkawGs=; b=wFJpKUEAo5phWBqZ3ekklkbDLOAM4gtvyEk3Jl4Fk4b75KbOdv5sY1rSftCU8Z+836 oITHi7HWRR/p96hTco+9qeeMxU+4rYhRi2sJy7QCOkZvvvMZO7dEWzApcQ9LRhJFfba/ i84MmyLWe2vs/huj6Bf1RkniXB0cx/SdpUrkH2t1tomqYZns1dJEvx6E8TlYHnJavA9o vTI/x4Tk2DXCK+Oj5PSCfXLJPjqRMJR5C1Ugjd/E2uzQ3mvdKI3CPRG5HQyE1V7mvVzX e8k0DQd03JUnUTBLObnPi1gkxtRBFrLc135AONo0olUJdUqA7DRsfL5ZuuajG/8B5B+e 8ROA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G3wd1psCrVAWlDMI+JH7KY5C4/ahmXuINV1gmOkawGs=; b=PBlA5VYvI+67thJLoAw/KXKnbuLXUsfxjKTosuRYBKrYdC3ceepOTB4lKNSvuntEAV Nr8XuD8McsaMgaqiSpd+N5PWgvBmc7qmW9k3lVwqW6dZg6MiJwXVxZpTox7S/yaKeXgY XBffPDU4i+HRiyEK1x3FNaXSpltDuPoFmwLRGqlpFCTeQYKLlKPZVPirpP2wtRUr1ouQ QhmffyrBidxSmf0p1VR4HUwj+E6ZlRmlRGk0DnL5uDWWiWTO5VYZRqBR274ulWxtgml4 OCM5o6fyTOuv7l+bjh0wl2UwFFZrymEde/8WQnTm7enTN1wAj3cm7jbiQMIec5U2v6PF bdwA== X-Gm-Message-State: AIkVDXKsGrjw6OeYK+xpMECLsUfETB4hvqkiJG7yZ9I6wlm9c//ecB6nAt2Np2jdX9bGMdPr X-Received: by 10.223.139.142 with SMTP id o14mr28669432wra.6.1485256795983; Tue, 24 Jan 2017 03:19:55 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id c9sm25902206wmi.16.2017.01.24.03.19.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Jan 2017 03:19:55 -0800 (PST) Date: Tue, 24 Jan 2017 12:19:49 +0100 From: Robin Jarry To: Olivier Matz Cc: dev@dpdk.org, ferruh.yigit@intel.com, thomas.monjalon@6wind.com Message-ID: <20170124111949.6jcif4uliwg6bgxv@6wind.com> References: <20170123181813.00567e47@platinum> <1485191953-2613-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1485191953-2613-1-git-send-email-olivier.matz@6wind.com> User-Agent: NeoMutt/20161126 (1.7.1) Subject: Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2017 11:19:56 -0000 Hi Olivier, 2017-01-23, Olivier Matz: >Before this patch, the management of dependencies between directories >had several issues: > >- the generation of .depdirs, done at configuration is slow: it can take > more than one minute on some slow targets (usually ~10s on a standard > PC). Indeed, on a Qualcomm development board where disk I/O is quite slow: $ git describe v17.02-rc1-3-g61207d014fc9 $ time make config T=arm64-armv8a-linuxapp-gcc real 1m4.308s >- for instance, it is possible to expressed a dependency like: s/expressed/express/ >- we cannot use "make -d" for debug, because the output of make is used >for the generation of .depdirs. That is really annoying when debugging makefiles. After applying this patch: $ git am mk-optimize-directory-dependencies.patch Applying: mk: optimize directory dependencies $ rm -rf build/ $ time make config T=arm64-armv8a-linuxapp-gcc real 0m0.111s Almost 600 times faster than before! I prefer this solution to the one proposed by Ferruh (which is interesting but requires to run parallel make). Here is a test with the other patch: $ git am mk-parallelize-make-config.patch Applying: mk: parallelize make config $ rm -rf build/ $ grep -c processor /proc/cpuinfo 24 $ time make config T=arm64-armv8a-linuxapp-gcc -j24 real 0m11.253s Here only 6 times faster than before, even when using 24 parallel processes. Tested-by: Robin Jarry