From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stephen@networkplumber.org> Received: from mail-pg0-f54.google.com (mail-pg0-f54.google.com [74.125.83.54]) by dpdk.org (Postfix) with ESMTP id 260DEDE5 for <dev@dpdk.org>; Wed, 25 Jan 2017 05:54:26 +0100 (CET) Received: by mail-pg0-f54.google.com with SMTP id 14so61018449pgg.1 for <dev@dpdk.org>; Tue, 24 Jan 2017 20:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lFZlnlialdtl1BrW9UVgTX9BkpJUKn+KtsUeg0GtQ+c=; b=rcLtCyZr7TcBTAzw5yPHsTw3cVxWVyxzq51m4TdErFm/+TAVoYsEeJ2u6oYD7tXL7V +QEfMxe/cJacj53MG1BkfLxdYTtPmhb9QJr7bb+789VbC8GMO778cjocPMCPR1o7xmqp 0IXubDGeRbRQ95Crn1je36Nf/fKvtPf64SkX07UCFGm7qopy0BuwKNqHtEdro7Vlm864 yUPW9kgj1CDSNqCpsGQK/XW75kB6I/uxQOvtqxHlIfPFYFquRNTIINLiBlHj4eS5ml+4 FBtzqDWPjQuip0LSAg88lUWvGs3mkudkjJUmYDTisC9yFSt1phVAZlfCz6/ID0TCP0cK AZPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lFZlnlialdtl1BrW9UVgTX9BkpJUKn+KtsUeg0GtQ+c=; b=f6zUxKlcB8ZUtEx/157HJ1tjV5dFJxe3exkRB968hcaluk1z9LmJcD/oM4LA6nWsf8 GNl1oYFpwP81BWUulxM456u5sLE6BZ58IinZ3LutKjnA6Ql0Z93/P0JhuAzM2Dikl8l0 a2KgcSW7+6zIQHbCpFO0qlAKUwy1UtDvYVWASSuYKqHunwPa/Bsyl/ASvdVvd5a2+EzH JLJBW8eTEV2TDplt68AQ+WWLGDs6uWNhQRySaqYKwoc3yyEatQiUcIuzpM/uTDhXHkKb gpknlQ5EyHc0OztFbn5LGF1RLicCFsRJM3xDDf1s+5wkfr3GrknmfiN/97pL/lGDE1Sd GnJg== X-Gm-Message-State: AIkVDXJ6JauVdJH3CJi+SY+VQbAeQzwZ5H/kSSJAvSRG1RX8POFJ9DfKjf3M7Y/RniPpRA== X-Received: by 10.98.210.3 with SMTP id c3mr44107647pfg.7.1485320066164; Tue, 24 Jan 2017 20:54:26 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id e90sm48334000pfl.32.2017.01.24.20.54.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Jan 2017 20:54:25 -0800 (PST) Date: Tue, 24 Jan 2017 20:54:18 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Shreyansh Jain <shreyansh.jain@nxp.com> Cc: <dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>, <thomas.monjalon@6wind.com>, <declan.doherty@intel.com>, <pablo.de.lara.guarch@intel.com>, <jblunck@infradead.org> Message-ID: <20170124205418.40ca5795@xeon-e3> In-Reply-To: <aa100e68-5fbf-7654-bc1b-8fd425b31a96@nxp.com> References: <1484730970-2832-1-git-send-email-hemant.agrawal@nxp.com> <aa100e68-5fbf-7654-bc1b-8fd425b31a96@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] cryptodev: decouple from PCI device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 25 Jan 2017 04:54:27 -0000 On Wed, 25 Jan 2017 10:18:01 +0530 Shreyansh Jain <shreyansh.jain@nxp.com> wrote: > On Wednesday 18 January 2017 02:46 PM, Hemant Agrawal wrote: > > This makes struct rte_cryptodev independent of struct rte_pci_device by > > replacing it with a pointer to the generic struct rte_device. > > > > This is inline with the recent changes in ethdev > > > > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> > > --- > > drivers/crypto/qat/qat_qp.c | 12 +++++++++--- > > drivers/crypto/qat/rte_qat_cryptodev.c | 6 +++--- > > lib/librte_cryptodev/rte_cryptodev.c | 6 +++--- > > lib/librte_cryptodev/rte_cryptodev.h | 4 ++-- > > 4 files changed, 17 insertions(+), 11 deletions(-) > > > > Next step would be to remove rte_pci_driver from eth_driver > and rte_cryptodev_driver and make it generic. > > Reviewed-by: Shreyansh Jain <shreyansh.jain@nxp.com> > Agreed.