From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9557ADE5 for ; Wed, 25 Jan 2017 06:25:45 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP; 24 Jan 2017 21:25:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,282,1477983600"; d="scan'208";a="57919348" Received: from debian.sh.intel.com (HELO debian) ([10.239.67.170]) by fmsmga006.fm.intel.com with ESMTP; 24 Jan 2017 21:25:43 -0800 Date: Wed, 25 Jan 2017 13:24:43 +0800 From: Tiwei Bie To: "Lu, Wenzhuo" Cc: "dev@dpdk.org" Message-ID: <20170125052443.GA19560@debian> References: <1485311962-62335-1-git-send-email-wenzhuo.lu@intel.com> <20170125031647.GA6019@debian> <6A0DE07E22DDAD4C9103DF62FEBC09093B55DCF6@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B55DCF6@shsmsx102.ccr.corp.intel.com> User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2017 05:25:46 -0000 On Wed, Jan 25, 2017 at 01:13:32PM +0800, Lu, Wenzhuo wrote: > Hi Tiwei, > > > -----Original Message----- > > From: Bie, Tiwei > > Sent: Wednesday, January 25, 2017 11:17 AM > > To: Lu, Wenzhuo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get > > > > On Wed, Jan 25, 2017 at 10:39:22AM +0800, Wenzhuo Lu wrote: > > > It'not appropriate to call rte_eth_dev_info_get in PMD, as > > > rte_eth_dev_info_get need to get info from PMD. > > > Remove rte_eth_dev_info_get from PMD code and get the info directly. > > > > > > Signed-off-by: Wenzhuo Lu > > > --- > > > drivers/net/ixgbe/ixgbe_ethdev.c | 144 > > > ++++++++++++++++++--------------------- > > > 1 file changed, 68 insertions(+), 76 deletions(-) > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > > index 64ce55a..f14a68b 100644 > > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > > @@ -4401,17 +4401,17 @@ static int > > ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, > > > int rar_entry; > > > uint8_t *new_mac = (uint8_t *)(mac_addr); > > > struct rte_eth_dev *dev; > > > - struct rte_eth_dev_info dev_info; > > > + struct rte_pci_device *pci_dev; > > > > > > RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > > > > > > dev = &rte_eth_devices[port]; > > > - rte_eth_dev_info_get(port, &dev_info); > > > + pci_dev = IXGBE_DEV_TO_PCI(dev); > > > > > > - if (is_ixgbe_pmd(dev_info.driver_name) != 0) > > > + if (is_ixgbe_pmd(dev->data->drv_name)) > > > return -ENOTSUP; > > > > > > > The return value of is_ixgbe_pmd() is not boolean (actually I think it should be > > based on its name). If we omit the comparison with 0, the code looks weird. It > > looks like it'll return -ENOTSUP if the port's driver is ixgbe PMD. > > Yes, it’s weird. But what makes it weird is not the missing comparison but the function name. > Better changing it to ixgbe_pmd_check. How about it? > Yeah, I also prefer to change the helper function itself. But I'm not good at the naming. I'd like to hear others' opinion. :-) Best regards, Tiwei Bie