From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 4A9A91023 for ; Wed, 25 Jan 2017 17:39:42 +0100 (CET) Received: by mail-pf0-f182.google.com with SMTP id e4so59175495pfg.1 for ; Wed, 25 Jan 2017 08:39:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/iTvC48hPTy2qZ8WvvmOD1kGxJACJ+G7TViteIOGf+I=; b=OxwgtqjCzBUDCvGGdmzw5xuoVDtT5sW/S8wrpcvFcCbpggHWkipV/3jZZqiW2QdE3U 1Ib6Rx/cuyy2d+9D0w8aCYodzXZ3VYHjrFa8H/8j4hc5j26M0tjYC7P5EKfIOd4T1MDQ 1TYQL6rUH25QbkfMsEYg9Rlb4VPp9m5M92zudHnUxaiUpCyJKXSMYBROytSVk6YTWJvX qzxGxDvrQZDGsN5EsKeH4m0rBiWkMLOo37czcBJtJgjtrcVrdPCOSLfw92LttoChEFBy d+XEfNIwj9JthfH6d2lfDkLDBzRamz9qnPixro62PF22CAM+kf7ca1FCqZS75sDpsJ0t XgLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/iTvC48hPTy2qZ8WvvmOD1kGxJACJ+G7TViteIOGf+I=; b=KDOwvSmOtZTNZhuuxH5dg8ieJMTufNjphuCjoUjl3Jg/O7Luim/s3lQ4Ss9920t7cF uWAsSeP1ZJKvDKOUgCY7supDr1mCg9C29y59DX9/FtvztxkG1P1eYFlMnvTL6WnDdR0z drU3oMSW/mqj7N4knQ2v07FFo/ove8LodtSpGTKhm3PZEfxOxeJVepsB7SuuF3j+FhOp aOLkd4iyPEooMD4W2r1vSzmlhRs31kBk2f6DR1Vq7QQW1/LL+OeaTI047H1OqPoyvfWS g/hEm0YmxPZ9Y/knIRHIEj1NcVF4MXP1IRXQMAOD3VUh0mc+EB4ncXtCJSFZ4DlDFrbE 7XJQ== X-Gm-Message-State: AIkVDXLVjlOyVA4HONZXFHSxzkQ6gNzYM6q6Pd3K8FH2HM19XcIc60kep83f/GcMaORO9g== X-Received: by 10.84.168.131 with SMTP id f3mr5115203plb.163.1485362381528; Wed, 25 Jan 2017 08:39:41 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id 66sm2351914pfx.29.2017.01.25.08.39.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Jan 2017 08:39:41 -0800 (PST) Date: Wed, 25 Jan 2017 08:39:34 -0800 From: Stephen Hemminger To: Olivier MATZ Cc: Bruce Richardson , dev@dpdk.org Message-ID: <20170125083934.07678812@xeon-e3> In-Reply-To: <20170125142052.7989e0ec@glumotte.dev.6wind.com> References: <20170125121456.GA24344@bricha3-MOBL3.ger.corp.intel.com> <20170125142052.7989e0ec@glumotte.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] rte_ring features in use (or not) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2017 16:39:42 -0000 On Wed, 25 Jan 2017 14:20:52 +0100 Olivier MATZ wrote: > > * Who uses the watermarks feature as is? I know we have a sample app > > that uses it, but there are better ways I think to achieve the same > > goal while simplifying the ring implementation. Rather than have a > > set watermark on enqueue, have both enqueue and dequeue functions > > return the number of free or used slots available in the ring (in > > case of enqueue, how many free there are, in case of dequeue, how > > many items are available). Easier to implement and far more useful to > > the app. > > +1 I did use the watermark feature once, it was for case of ring between two threads. Only wanted to wake up other thread if > N packets were in ring.