From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com
[209.85.192.176]) by dpdk.org (Postfix) with ESMTP id 8CFB81023
for <dev@dpdk.org>; Fri, 27 Jan 2017 17:30:55 +0100 (CET)
Received: by mail-pf0-f176.google.com with SMTP id f144so74354731pfa.2
for <dev@dpdk.org>; Fri, 27 Jan 2017 08:30:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=c0DGvmWu7apY1x7GSTn+/eUJW30MjaiIF7LuAyPn6tY=;
b=LHXx2axEN5M6MvliyCVjQiCU8UA3AZoPCeh6RhATA3BBD3DYVAX+xXa+3fIkjP/HYn
JuPMgyfTo64VlcM8ClQPsaIgssQe6aLSmJ9Fz/RE8QEXT4cTTTVG+UgCJ7qGQY3PFFHX
G3vhAlLtiIJ9+oB923eSlHxw5mHF7vcWDVM1OszkrBt3R73+7n9iYm8JFGmTFN0OLqDk
Tw35u91IE2gtND5vqZ0Ng6aHxKjGuNBnLIJtPv+AbOArrfa4IhrzwMnBOwqqO91zfaU3
G6zVy6K3T7k7FKCJaX0z08IqqPKKpy9cHB1dSvxzngSuucZUP617Cw+HvxSfBHixb/CC
aDWA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=c0DGvmWu7apY1x7GSTn+/eUJW30MjaiIF7LuAyPn6tY=;
b=TXyqJOozjGjE0dV2FEr2BRotrzB6t2APVfHSLuVGkBQUFFaCzsHseHlrN37p0x4VvL
6qwMOVDoPMQbunw+sPnmFgxvhELt17BqRT1JnPTC2CWHT+rMbanGAOr3szHIJSSfOkFO
V53YOPjXSRdn9CgWp1/Etk4b8z5WPe+sHHdr/F9bWXY3KBS8sS04m5pCLWOKXX98zTrK
91D3Gjff6myp3Zmxc0SFJMI+50uQar3QolJkxoE+6z1AWdDLgo1o37i93fowzD3dQx9D
y0FmcCfXwPrPHOU9Nzy9AFdhFcpfKEqH18vONJz5uPV3ceo+VbCX+3K7/+Uj/Q+WuvZ6
EO/g==
X-Gm-Message-State: AIkVDXKgdWXCDQYhM4b4Gtgzw52rHO1kllbG7RyEZhtpUcQVkhWPO19gZMY/sVKnVTDoYA==
X-Received: by 10.98.194.22 with SMTP id l22mr10237736pfg.178.1485534654837;
Fri, 27 Jan 2017 08:30:54 -0800 (PST)
Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65])
by smtp.gmail.com with ESMTPSA id c11sm12593505pfk.14.2017.01.27.08.30.54
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Fri, 27 Jan 2017 08:30:54 -0800 (PST)
Date: Fri, 27 Jan 2017 08:30:47 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Aaron Conole <aconole@redhat.com>
Cc: dev@dpdk.org
Message-ID: <20170127083047.3159032b@xeon-e3>
In-Reply-To: <1485529023-5486-15-git-send-email-aconole@redhat.com>
References: <1485529023-5486-1-git-send-email-aconole@redhat.com>
<1485529023-5486-15-git-send-email-aconole@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 14/25] eal: do not panic on tailq init
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Jan 2017 16:30:55 -0000
On Fri, 27 Jan 2017 09:56:52 -0500
Aaron Conole <aconole@redhat.com> wrote:
> + /* no need to TAILQ_REMOVE, we are going to disallow re-attemtps
> + * for rte_eal_init(). */
Please put multi-line comments in form:
/*
* this is a long comment
* because there really is lots to say
*/
In many cases, having shorter comment is the best way to handle these.
Often developer writes long comment for themselves because what ever problem
they saw was urgent. Then comment becomes irrelevant later.
/* TAILQ_REMOVE not needed, error is already fatal */