From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id C7BA412A8 for ; Fri, 27 Jan 2017 17:32:02 +0100 (CET) Received: by mail-pf0-f176.google.com with SMTP id 189so74469830pfu.3 for ; Fri, 27 Jan 2017 08:32:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a8BPdOg950jj7/LbUDgxrz/Lp1yxMB6rdE1dxzt4VWY=; b=Rj3omtQAU6VizzptzrdNZJPc+QgRQrBzn+HapKVppjQ7+7lK+UF+Gx4NPFvc73w3xd tuxJ2KNWFwu/Oum5daAvOXNLGpvLDrx3eLu8yzSyppe2fP8wp6hfQHzH0vyV86rNhYV5 FTAk/xGqRdwkgGXjlJrR/7gbzuEmnHy3MMFJIdBUUVsUltxidf8U6vlndyySMvZBDJDv v7J+6PbTKmLQy+A1klCHaMWvmQT3OhnElqt1woyb9hAxFBaioOHfCZxTNQqda3y2Chun kAwIcXP1M0+W+ueplwblvvQvwY0tevKDI34cIvvSkjZs6HBz12RLjAvslnJoNPZNEGcX PoOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a8BPdOg950jj7/LbUDgxrz/Lp1yxMB6rdE1dxzt4VWY=; b=A2StvQoytu1p5EIiaJ7Z0KjJKnjBVtt7tpRVZQkfAi2LRrPg0RuLxJfs4oKW/Ro8eY 23HvqDUtU7NmNil+Lt85i2OyCU9ZV7PtrQ2cy1kQuTuYMgS7TPSNAQM2PGdCCdhy4Ryz KylFZOL1r1oJcyWPwSLC4JrQ5fJByZu/ueKBVd1V5uBDH+G93GqhxdtvcVQblcfGXwZ5 qCjWcTZhARYOmFYas9nkvjzjq6qZ4XlSvk5j9MqcpFxVUL2urMdtnsneZ8LrJIc4f/63 KGIpuzpkTvpn3tgsTkelIP0FSHYCNKdRqIWWbGs+LeWKAhXUO7dZPLyFzQUhvBz4Pb46 suKQ== X-Gm-Message-State: AIkVDXIYQA1S9MpoERxir81Q+rCE4VL6CzgFK605Fg/giRj+eX+cZBjberTdRT4gTZ3PGA== X-Received: by 10.98.214.209 with SMTP id a78mr10191993pfl.6.1485534722077; Fri, 27 Jan 2017 08:32:02 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id 19sm12585645pft.46.2017.01.27.08.32.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Jan 2017 08:32:01 -0800 (PST) Date: Fri, 27 Jan 2017 08:31:55 -0800 From: Stephen Hemminger To: Aaron Conole Cc: dev@dpdk.org Message-ID: <20170127083155.71fb20cb@xeon-e3> In-Reply-To: <1485529023-5486-16-git-send-email-aconole@redhat.com> References: <1485529023-5486-1-git-send-email-aconole@redhat.com> <1485529023-5486-16-git-send-email-aconole@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 15/25] eal: do not panic on alarm init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2017 16:32:03 -0000 On Fri, 27 Jan 2017 09:56:53 -0500 Aaron Conole wrote: > + if (rte_eal_alarm_init() < 0) { > + RTE_LOG (ERR, EAL, "Cannot init interrupt-handling thread\n"); > + /* rte_eal_alarm_init sets rte_errno on failure. */ > + errno = rte_errno; Hmm. DPDK in general does not reset errno but instead uses error code directly on return (best) or in some cases rte_errno