From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 55E99FFA
 for <dev@dpdk.org>; Fri, 27 Jan 2017 17:42:05 +0100 (CET)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga102.jf.intel.com with ESMTP; 27 Jan 2017 08:42:04 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,296,1477983600"; d="scan'208";a="57992485"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.252.2.47])
 by orsmga005.jf.intel.com with SMTP; 27 Jan 2017 08:42:02 -0800
Received: by  (sSMTP sendmail emulation); Fri, 27 Jan 2017 16:42:02 +0000
Date: Fri, 27 Jan 2017 16:42:02 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Aaron Conole <aconole@redhat.com>, dev@dpdk.org
Message-ID: <20170127164201.GA82692@bricha3-MOBL3.ger.corp.intel.com>
References: <1485529023-5486-1-git-send-email-aconole@redhat.com>
 <1485529023-5486-16-git-send-email-aconole@redhat.com>
 <20170127083155.71fb20cb@xeon-e3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170127083155.71fb20cb@xeon-e3>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.7.1 (2016-10-04)
Subject: Re: [dpdk-dev] [PATCH 15/25] eal: do not panic on alarm init
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Jan 2017 16:42:06 -0000

On Fri, Jan 27, 2017 at 08:31:55AM -0800, Stephen Hemminger wrote:
> On Fri, 27 Jan 2017 09:56:53 -0500
> Aaron Conole <aconole@redhat.com> wrote:
> 
> > +	if (rte_eal_alarm_init() < 0) {
> > +		RTE_LOG (ERR, EAL, "Cannot init interrupt-handling thread\n");
> > +		/* rte_eal_alarm_init sets rte_errno on failure. */
> > +		errno = rte_errno;
> 
> Hmm. DPDK in general does not reset errno but instead uses error code
> directly on return (best) or in some cases rte_errno

I think we'll disagree on what way of returning error codes is best :-), but
yes, DPDK does not generally modify errno.