From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stephen@networkplumber.org> Received: from mail-pf0-f175.google.com (mail-pf0-f175.google.com [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 850D4FFA for <dev@dpdk.org>; Tue, 31 Jan 2017 17:58:38 +0100 (CET) Received: by mail-pf0-f175.google.com with SMTP id f144so108421072pfa.2 for <dev@dpdk.org>; Tue, 31 Jan 2017 08:58:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EcGcAtmjIacKeD3aXGyv+j1DarAFyFBD1ms+pzVwl08=; b=NE9ztBxkNyssxYpStCtzs7KR2yE5/S4r1IWCUiVDJkdcdh/8/nwPXUn5/ZoYexVD1H pDTGtwGgjD8H97hCLw5KKqNSSxP36Rn9ezOj7VvRXfx1qM5djV8Zi4/KbZZN1JXWTkze JQPlHldh2av9eV5Qq4CeB4FlWNYCnZ6Y9MzT2MgSdpz3u+4SKkoPpsxOB15+c502APoJ umMMGPb0WGdls8CBogOLCaYvxap+ybZ+egeCbbmlfOjiVHc3getHZ7yF4YpUnv+ercP1 6LEY2Ynkq8y34AlztH0LI21vB12KxqB3cuUYKDnfj5iJSwemwNmLfdZRU5jDYuGTCnwQ dbEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EcGcAtmjIacKeD3aXGyv+j1DarAFyFBD1ms+pzVwl08=; b=Ia2hcLII1iuxtJXOprCbNp7Iz46yRzwhDbliwrtTuydAVE24bBF5E5cJeXkpQy4+a/ Cd2GNd4yZqKiuxj0FZpdQqsvBtEK92Gu45bDv2MjULwumc5+W2JHVhIqLRXR26YMDs83 7B7xJBdaAOH/LdSpBjHOO2sOjI7X3c2BzSwgTQeuURyFkA5kkLN+KSEi+m+u60AiRev7 Kn1R/Shz7ZPUsmeTLIrKHES16alyYLE1dMWV2WXkgtSPwDnBTDjn7Z+0IpjFXGUjQqKa 8dMJLyntY2R27L8zavZY+LwafwBBLLTIxvRDEBVHCZT+gg+TIA+dIgW0MLpDUF/csOKj qE4A== X-Gm-Message-State: AIkVDXKI3VIuDftFQlxFPpP4yWLMpXOx/UmFfz4Z36ISXqDBLbTGZdaRO+qRE5lZJCdoSQ== X-Received: by 10.99.174.71 with SMTP id e7mr31860412pgp.3.1485881917763; Tue, 31 Jan 2017 08:58:37 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id 75sm42527985pfp.80.2017.01.31.08.58.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jan 2017 08:58:37 -0800 (PST) Date: Tue, 31 Jan 2017 08:58:30 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: Pascal Mazon <pascal.mazon@6wind.com>, keith.wiles@intel.com, dev@dpdk.org Message-ID: <20170131085830.341b494d@xeon-e3> In-Reply-To: <e1545ede-ee4c-57a4-e47e-67b23a7a7677@intel.com> References: <1485855778-15496-1-git-send-email-pascal.mazon@6wind.com> <1485855778-15496-2-git-send-email-pascal.mazon@6wind.com> <e1545ede-ee4c-57a4-e47e-67b23a7a7677@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/6] net/tap: use correct channel for error logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 31 Jan 2017 16:58:38 -0000 On Tue, 31 Jan 2017 13:07:37 +0000 Ferruh Yigit <ferruh.yigit@intel.com> wrote: > On 1/31/2017 9:42 AM, Pascal Mazon wrote: > > Signed-off-by: Pascal Mazon <pascal.mazon@6wind.com> > > --- > > looks good to me. > Agreed, almost all uses of INFO as log level are wrong! Either the message is reporting a problem should be NOTICE, WARN, ERR or the message is often just developer checking the code and should be DEBUG.