From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id C2F001150 for ; Fri, 3 Feb 2017 10:32:35 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id b65so19421018wmf.0 for ; Fri, 03 Feb 2017 01:32:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=cfoFRO7pp4+j4cw3+EeE9wB+dK6kTNyG3ELlFCPXY3c=; b=F+3ZmaNSay4QRHQOaNUnUQau9NOWz/STydXpvbf4Ou52+8jFiWB6gK3JMwQPB8wT4d IahrgrNQclIMSxGjwpCgr0dZJxKM5y73nZE5SPNW/oyuvvzJlCf5nXzzSEgfMltQgKwp VSlBuTfkXDsWXx1LaIcLlbg/Tqczc5A5YD26RVi6Nvukj563RxsfPcaIgg+45W6wdyWN vcPKWZ864sj+6x039picPQ8wnIxLt6kxP+nDGi3jgI7ZLqw2fUpEhnNRPBU+D5Diaau7 rWreZyi5dVrEOFaW710PIW1Fu0PGhRoW2qkjjO6JyuBt1/x7q7LXF1ET0ERBZw0tueh5 3MOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=cfoFRO7pp4+j4cw3+EeE9wB+dK6kTNyG3ELlFCPXY3c=; b=FS5ZRLCyCYwKv1PFe+UvxLebRIhULpVVZucL/GvFRzycnsBf232w3JcEmaWCXkoCZH eyKcY7qEDCA/vt6333jcgtCJGnCpQDzswQFuu7U0npy/3Ilq6UH+SGDDY/IatFiH0n2A M5JYIg1HliqApLHS777qI7XA+RYRX6DAIxIrdXWYbs1CcqulDadLQlRC/6J+BIuQSCSk SJdRX7c+jJY8UOQ37iu8aiWEXFQGsGw3UQT8m3J0R5FLcw6mQCMI3JAjp8tSaFP63WF8 Q8/YDNuml+OlvmaEbkV9dsUZZsXUPYnudUK3W4jpINByHWinOwVAW4IcTKl3Y0U6jPUy WG6g== X-Gm-Message-State: AMke39nDLvxMmf3mVtLMvHEO8IzPZAGmXInmD8I+hmBpEoLz9LE5jfsDrLtn/mK8E3LDSrY3 X-Received: by 10.28.234.193 with SMTP id g62mr515207wmi.36.1486114355475; Fri, 03 Feb 2017 01:32:35 -0800 (PST) Received: from paques.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u47sm44332562wrb.15.2017.02.03.01.32.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Feb 2017 01:32:35 -0800 (PST) Date: Fri, 3 Feb 2017 10:32:27 +0100 From: Pascal Mazon To: Keith Wiles Cc: dev@dpdk.org Message-ID: <20170203103227.17fc8d66@paques.dev.6wind.com> In-Reply-To: <20170202223330.39240-1-keith.wiles@intel.com> References: <20170202223330.39240-1-keith.wiles@intel.com> Organization: 6WIND X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/5] nic/tap: fix tap docs for device name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 09:32:35 -0000 On Thu, 2 Feb 2017 16:33:26 -0600 Keith Wiles wrote: > Signed-off-by: Keith Wiles > --- > doc/guides/nics/tap.rst | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/doc/guides/nics/tap.rst b/doc/guides/nics/tap.rst > index 622b9e7..2ab60ff 100644 > --- a/doc/guides/nics/tap.rst > +++ b/doc/guides/nics/tap.rst > @@ -45,18 +45,18 @@ device. > These TAP interfaces can be used with Wireshark or tcpdump or Pktgen-DPDK > along with being able to be used as a network connection to the DPDK > application. The method enable one or more interfaces is to use the > -``--vdev=net_tap`` option on the DPDK application command line. Each > -``--vdev=net_tap`` option give will create an interface named dtap0, dtap1, > +``--vdev=net_tap0`` option on the DPDK application command line. Each > +``--vdev=net_tap1`` option give will create an interface named dtap0, dtap1, > and so on. > > The interfaced name can be changed by adding the ``iface=foo0``, for > example:: > - --vdev=net_tap,iface=foo0 --vdev=net_tap,iface=foo1, ... > + --vdev=net_tap0,iface=foo0 --vdev=net_tap1,iface=foo1, ... > > Also the speed of the interface can be changed from 10G to whatever number > needed, but the interface does not enforce that speed, for example:: > > - --vdev=net_tap,iface=foo0,speed=25000 > + --vdev=net_tap0,iface=foo0,speed=25000 > > After the DPDK application is started you can send and receive packets on the > interface using the standard rx_burst/tx_burst APIs in DPDK. From the host > @@ -97,7 +97,7 @@ following:: > > sudo ./app/app/x86_64-native-linuxapp-gcc/app/pktgen -l 1-5 -n 4 \ > --proc-type auto --log-level 8 --socket-mem 512,512 --file-prefix pg \ > - --vdev=net_tap --vdev=net_tap -b 05:00.0 -b 05:00.1 \ > + --vdev=net_tap0 --vdev=net_tap1 -b 05:00.0 -b 05:00.1 \ > -b 04:00.0 -b 04:00.1 -b 04:00.2 -b 04:00.3 \ > -b 81:00.0 -b 81:00.1 -b 81:00.2 -b 81:00.3 \ > -b 82:00.0 -b 83:00.0 -- -T -P -m [2:3].0 -m [4:5].1 \ > @@ -131,6 +131,6 @@ time with ``start all``. The command ``str`` is an alias > for ``start all`` and > While running you should see the 64 byte counters increasing to verify the > traffic is being looped back. You can use ``set all size XXX`` to change the > -size of the packets after you stop the traffic. Use the pktgen ``help`` > +size of the packets after you stop the traffic. Use pktgen ``help`` > command to see a list of all commands. You can also use the ``-f`` option to > -load commands at startup. > +load commands at startup in command line or Lua script in pktgen. To be consistent. commit title should be "net/tap" The patch looks ok to me, but while in the doc, could you fix the "The interfaced name" into "The interface name"? Regards, Pascal