From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id BF796FFA
 for <dev@dpdk.org>; Sat,  4 Feb 2017 22:51:01 +0100 (CET)
Received: by mail-pf0-f182.google.com with SMTP id f144so14131398pfa.2
 for <dev@dpdk.org>; Sat, 04 Feb 2017 13:51:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=tZoOc7nZKNgWyIFSx/PAb81qB2mcz02dVS4oY1VKToo=;
 b=zu7IMMYFrwM/dD9F/bff5zQVo64YLtf5i87w1694Pd8BpYPooxX1BgyBTsswxMl23A
 i1LasIjXTlmNPGfH9jxXqoPF5fIJk/s/g+Vm1L4gsi2yyE88w/FP+mM4h2s7iJsl+w9U
 kyrJqZ2+5rNOe6xXC2XEDQJVDE1wstxuvYW1Zv6mMzCF3hiX6OBZ7sgxqqjKxb+/badJ
 mRPdEuyg8qhXkUpz+9rpnWFm6AlBOXc2/eVf9o+0HIegJNPaWZGFd+xbyg9ZrhKz8DzF
 AjDqKbAnRWCMdVGx4AWTgQZ+ATEBvVbrCdXYCrZWyq8kyJJiO45VEwR9e5uTgM2Ai9hY
 fIEQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=tZoOc7nZKNgWyIFSx/PAb81qB2mcz02dVS4oY1VKToo=;
 b=Np1859/DWhYFcAWqmS2NDtlex5mII0AisMZ1nynJyHRfWnx5cSetuOHUQJypfIRbNf
 V+1Vahd2X0oaAe7B6qfBPVf+u5DK0xk3e95RwFeGoLfSeRUIEZn7FqFHLsarBq8MANJA
 jA02w/mE+YykuTtNDxkJ3ZRYpSvZ7wcUap9zZ3mzLpsbNeF+nVs91Ssvg74L4ppzMMQm
 XmuNlABL4Zpwx1U+1brKdqvHGqWJw8pyv7RKjwhg/83osDWToGgqSHCKkL1GeTseChW6
 uOCPX10x/vAaRbrNOCPPp9hFoeWJgKG/B7RyA5rwx3I78W/Sdo5Xks6VF2g+dxweZrrW
 y3Yg==
X-Gm-Message-State: AIkVDXJ43ng115r+hwbl5+UQQmAOiB9XZX3/i2oM5vcDFgS3p/75yFLy1qmcx6IQ+XxMEQ==
X-Received: by 10.98.133.202 with SMTP id m71mr4818004pfk.102.1486245060786;
 Sat, 04 Feb 2017 13:51:00 -0800 (PST)
Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65])
 by smtp.gmail.com with ESMTPSA id y23sm77444733pfi.66.2017.02.04.13.51.00
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Sat, 04 Feb 2017 13:51:00 -0800 (PST)
Date: Sat, 4 Feb 2017 13:50:58 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Wei Dai <wei.dai@intel.com>
Cc: dev@dpdk.org, helin.zhang@intel.com, konstantin.ananyev@intel.com
Message-ID: <20170204135058.1cd43023@xeon-e3>
In-Reply-To: <1486197474-53099-1-git-send-email-wei.dai@intel.com>
References: <1486197474-53099-1-git-send-email-wei.dai@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: output details on failure to
 configure filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Feb 2017 21:51:02 -0000

On Sat,  4 Feb 2017 16:37:54 +0800
Wei Dai <wei.dai@intel.com> wrote:

> +		PMD_INIT_LOG(ERR, "If ixgbe MAC type is not X550 or X550EM_x or "
> +			"X550EM_a, the filter mode must be signature or perfect, other mode "
> +			"is not supported ! Current MAC type = %d filter mode = %d",
> +			(int)(hw->mac.type), (int)mode);
>  		return -ENOSYS;

Having better messages is good. Please punctuate correctly, and ! is not necessary.

Please try and keep it to one line, having really long log messages doesn't help.
Also, breaking a string makes it harder to use grep to find the source.