Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

[Tiwei Bie <tiwei.bie@intel.com>]

On Mon, Feb 06, 2017 at 10:09:32AM +0800, Wenzhuo Lu wrote:
[...]
>  static void ixgbe_dcb_init(struct ixgbe_hw *hw, struct ixgbe_dcb_config *dcb_config);
> -static int is_ixgbe_pmd(const char *driver_name);
> +static int is_device_supported(struct rte_eth_dev *dev, struct eth_driver *drv);
>  

Should be:
static bool is_device_supported(struct rte_eth_dev *dev, struct eth_driver *drv);

>  /* For Virtual Function support */
>  static int eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev);
> @@ -4380,16 +4380,14 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
>  	ixgbe_add_rar(dev, addr, 0, 0);
>  }
>  
> -static int
> -is_ixgbe_pmd(const char *driver_name)
> +static bool
> +is_device_supported(struct rte_eth_dev *dev, struct eth_driver *drv)
>  {
> -	if (!strstr(driver_name, "ixgbe"))
> -		return -ENOTSUP;
> +	if (strcmp(dev->driver->pci_drv.driver.name,
> +		   drv->pci_drv.driver.name))
> +		return FALSE;
>  

It would be better to use `false' instead of `FALSE'.

Best regards,
Tiwei Bie