From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tiwei.bie@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id D58A3DE0
 for <dev@dpdk.org>; Mon,  6 Feb 2017 03:31:30 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 05 Feb 2017 18:31:29 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="1091232897"
Received: from debian.sh.intel.com (HELO debian) ([10.239.67.170])
 by orsmga001.jf.intel.com with ESMTP; 05 Feb 2017 18:31:29 -0800
Date: Mon, 6 Feb 2017 10:30:30 +0800
From: Tiwei Bie <tiwei.bie@intel.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org
Message-ID: <20170206023030.GA21315@debian>
References: <1485311962-62335-1-git-send-email-wenzhuo.lu@intel.com>
 <1486346972-30710-1-git-send-email-wenzhuo.lu@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1486346972-30710-1-git-send-email-wenzhuo.lu@intel.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Feb 2017 02:31:31 -0000

On Mon, Feb 06, 2017 at 10:09:32AM +0800, Wenzhuo Lu wrote:
[...]
>  static void ixgbe_dcb_init(struct ixgbe_hw *hw, struct ixgbe_dcb_config *dcb_config);
> -static int is_ixgbe_pmd(const char *driver_name);
> +static int is_device_supported(struct rte_eth_dev *dev, struct eth_driver *drv);
>  

Should be:
static bool is_device_supported(struct rte_eth_dev *dev, struct eth_driver *drv);

>  /* For Virtual Function support */
>  static int eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev);
> @@ -4380,16 +4380,14 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
>  	ixgbe_add_rar(dev, addr, 0, 0);
>  }
>  
> -static int
> -is_ixgbe_pmd(const char *driver_name)
> +static bool
> +is_device_supported(struct rte_eth_dev *dev, struct eth_driver *drv)
>  {
> -	if (!strstr(driver_name, "ixgbe"))
> -		return -ENOTSUP;
> +	if (strcmp(dev->driver->pci_drv.driver.name,
> +		   drv->pci_drv.driver.name))
> +		return FALSE;
>  

It would be better to use `false' instead of `FALSE'.

Best regards,
Tiwei Bie